Patch Detail
Show a patch.
GET /api/patches/10300/?format=api
{ "id": 10300, "url": "https://patchwork.libcamera.org/api/patches/10300/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10300/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201029101629.61798-5-paul.elder@ideasonboard.com>", "date": "2020-10-29T10:16:27", "name": "[libcamera-devel,v3,4/6] pipeline: raspberrypi: Add IPA call tracepoints", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a301261f15cc376e7222b6e9a169c1f46cbde4fe", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10300/mbox/", "series": [ { "id": 1432, "url": "https://patchwork.libcamera.org/api/series/1432/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1432", "date": "2020-10-29T10:16:23", "name": "Tracing", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1432/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10300/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10300/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03E79BDB9B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 29 Oct 2020 10:16:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C72AD6288A;\n\tThu, 29 Oct 2020 11:16:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 257A3627D7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 29 Oct 2020 11:16:48 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 95C1C527;\n\tThu, 29 Oct 2020 11:16:46 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uC5mg+nt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603966607;\n\tbh=vi3OxJ67/22U5qV+aplWDOAjaP8lkXS29F/BZF83+Nk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uC5mg+ntjrO5eGvdEyS7hnywhDeLckq6EfSdaWX9t+qjnE1V/U2zId3TefhB/jRsL\n\tm4rfK+IZhSOzaILlSO0AOlIyF2PQKmI4T1oRERCpu204ToOZxYYU4oRLOzn+RIpVu2\n\tQ4YVClquGApkGxO+SPU4bSIWgC/blfieaoM1qN1w=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 29 Oct 2020 19:16:27 +0900", "Message-Id": "<20201029101629.61798-5-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201029101629.61798-1-paul.elder@ideasonboard.com>", "References": "<20201029101629.61798-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 4/6] pipeline: raspberrypi: Add IPA\n\tcall tracepoints", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Emit tracepoints for IPA calls in the raspberrypi pipeline handler, to\nallow profiling of IPA calls.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nChanges in v3:\n- rename the tracepoints to ipa_call_begin and ipa_call_end\n- remove the char * casts for the strings passed to the tracepoints\n- use the new ipa call tracepoint macros\n\nNew in v2\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 0a5a7288..07c9c25a 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -31,6 +31,7 @@\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n+#include \"libcamera/internal/tracepoints.h\"\n #include \"libcamera/internal/utils.h\"\n #include \"libcamera/internal/v4l2_controls.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n@@ -1240,6 +1241,8 @@ int RPiCameraData::configureIPA(const CameraConfiguration *config)\n \n void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &controls)\n {\n+\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalStatReady);\n+\n \tif (state_ == State::Stopped)\n \t\thandleState();\n \n@@ -1273,6 +1276,8 @@ void RPiCameraData::statsMetadataComplete(uint32_t bufferId, const ControlList &\n \n void RPiCameraData::runIsp(uint32_t bufferId)\n {\n+\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalIspPrepare);\n+\n \tif (state_ == State::Stopped)\n \t\thandleState();\n \n@@ -1406,6 +1411,7 @@ void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n \t * application until after the IPA signals so.\n \t */\n \tif (stream == &isp_[Isp::Stats]) {\n+\t\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalStatReady);\n \t\tipa_->signalStatReady(RPi::BufferMask::STATS | static_cast<unsigned int>(index));\n \t} else {\n \t\t/* Any other ISP output can be handed back to the application now. */\n@@ -1658,7 +1664,9 @@ void RPiCameraData::tryRunPipeline()\n \t * queue the ISP output buffer listed in the request to start the HW\n \t * pipeline.\n \t */\n+\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalQueueRequest);\n \tipa_->signalQueueRequest(request->controls());\n+\tLIBCAMERA_TRACEPOINT_IPA_END(rpi, signalQueueRequest);\n \n \t/* Ready to use the buffers, pop them off the queue. */\n \tbayerQueue_.pop();\n@@ -1677,6 +1685,7 @@ void RPiCameraData::tryRunPipeline()\n \tipa::rpi::IspPreparePayload ispPrepare;\n \tispPrepare.embeddedbufferId_ = RPi::BufferMask::EMBEDDED_DATA | embeddedId;\n \tispPrepare.bayerbufferId_ = RPi::BufferMask::BAYER_DATA | bayerId;\n+\tLIBCAMERA_TRACEPOINT_IPA_BEGIN(rpi, signalIspPrepare);\n \tipa_->signalIspPrepare(ispPrepare);\n }\n \n", "prefixes": [ "libcamera-devel", "v3", "4/6" ] }