Patch Detail
Show a patch.
GET /api/patches/10253/?format=api
{ "id": 10253, "url": "https://patchwork.libcamera.org/api/patches/10253/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10253/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201026140134.44166-2-email@uajain.com>", "date": "2020-10-26T14:01:32", "name": "[libcamera-devel,1/3] android: jpeg: Return encoded bytes size from PostProcessorJpeg", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "7002a0e70d874afe31e8d63af2bf59ab02047810", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": { "id": 12, "url": "https://patchwork.libcamera.org/api/users/12/?format=api", "username": "uajain", "first_name": "Umang", "last_name": "Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10253/mbox/", "series": [ { "id": 1416, "url": "https://patchwork.libcamera.org/api/series/1416/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1416", "date": "2020-10-26T14:01:31", "name": "android: jpeg: exif: Embed a JPEG-encoded thumbnail", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1416/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10253/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10253/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 619DDBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Oct 2020 14:02:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32ADE61E71;\n\tMon, 26 Oct 2020 15:02:37 +0100 (CET)", "from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 073266034E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Oct 2020 15:02:36 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"qaVj33Do\"; dkim-atps=neutral", "From": "Umang Jain <email@uajain.com>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603720955; bh=Qx76a36vIl8KmOYbctsbqlckjakSOy/2qZcc+OEWZh0=;\n\th=From:To:Cc:Subject:In-Reply-To:References;\n\tb=qaVj33DoewAunAUMiUS9YO5X5P5kppRo/+ybF3UmYKsxVGQbj0u+jCuG7tQ4udr7V\n\tjJMolg0UdvMTcZRHU5+3NXdzXQJQgDTKj4fXECPTipXamwl+snj/fMSrHs+/fCSUWd\n\tIPejLa+X07o20f0K25NPSYENjwYw3QfbXiAqr/wAe0Pfl1JaVEpuglIq0AFhpzE8gU\n\t/es182DE9umIuXuRUkSJ1qIYfAHt0GSgy8NZxM/C+g7MI54LKY2HayU4iZbyYObtXm\n\t8dTFV0StbnHNbVqXBm/D2BbjbC+4bTK6afJNtk8FoTJ/p3M9yKKOnE6pJAumgKFcEV\n\taxkYS4T7bAZxw==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 26 Oct 2020 19:31:32 +0530", "Message-Id": "<20201026140134.44166-2-email@uajain.com>", "In-Reply-To": "<20201026140134.44166-1-email@uajain.com>", "References": "<20201026140134.44166-1-email@uajain.com>", "Mime-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] android: jpeg: Return encoded bytes\n\tsize from PostProcessorJpeg", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Returning 0 from PostProcessJpeg::process() is not really helpful.\nAlso, one expects that the process() returns the size of the output\ndata from the processor.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 93acfe5..c56f1b2 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -101,5 +101,5 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n \tconst uint32_t jpeg_orientation = 0;\n \tmetadata->addEntry(ANDROID_JPEG_ORIENTATION, &jpeg_orientation, 1);\n \n-\treturn 0;\n+\treturn jpeg_size;\n }\n", "prefixes": [ "libcamera-devel", "1/3" ] }