Patch Detail
Show a patch.
GET /api/patches/10229/?format=api
{ "id": 10229, "url": "https://patchwork.libcamera.org/api/patches/10229/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10229/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201023171116.24899-11-jacopo@jmondi.org>", "date": "2020-10-23T17:11:14", "name": "[libcamera-devel,v4,10/12] android: camera_device: Handle NOISE_REDUCTION_MODES", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "7d13e49b98e12f75d2884a69337fd41533413c68", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10229/mbox/", "series": [ { "id": 1410, "url": "https://patchwork.libcamera.org/api/series/1410/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1410", "date": "2020-10-23T17:11:04", "name": "libcamera: Introduce draft controls", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1410/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10229/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10229/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE001C3D3D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Oct 2020 17:11:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95625619E2;\n\tFri, 23 Oct 2020 19:11:35 +0200 (CEST)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DF216195B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 19:11:31 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id E7BB91C0004;\n\tFri, 23 Oct 2020 17:11:30 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Oct 2020 19:11:14 +0200", "Message-Id": "<20201023171116.24899-11-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201023171116.24899-1-jacopo@jmondi.org>", "References": "<20201023171116.24899-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 10/12] android: camera_device: Handle\n\tNOISE_REDUCTION_MODES", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Register the ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES\nstatic metadata property inspecting the values retuned by the pipeline\nhandler.\n\nReserve in the static metadata pack enough space to support all the 5\navailable noise reduction modes Android defines.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/android/camera_device.cpp | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 8166b09bb69a..a4d9e6ddc519 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -553,7 +553,7 @@ std::tuple<uint32_t, uint32_t> CameraDevice::calculateStaticMetadataSize()\n \t * Currently: 51 entries, 687 bytes of static metadata\n \t */\n \tuint32_t numEntries = 51;\n-\tuint32_t byteSize = 687;\n+\tuint32_t byteSize = 691;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -830,9 +830,18 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t &minFocusDistance, 1);\n \n \t/* Noise reduction modes. */\n-\tuint8_t noiseReductionModes = ANDROID_NOISE_REDUCTION_MODE_OFF;\n-\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n-\t\t\t\t &noiseReductionModes, 1);\n+\t{\n+\t\tstd::vector<uint8_t> data(5);\n+\t\tconst auto &infoMap = controlsInfo.find(&controls::draft::NoiseReductionMode);\n+\t\tif (infoMap != controlsInfo.end()) {\n+\t\t\tfor (const auto &value : infoMap->second.values())\n+\t\t\t\tdata.push_back(value.get<int32_t>());\n+\t\t} else {\n+\t\t\tdata.push_back(ANDROID_NOISE_REDUCTION_MODE_OFF);\n+\t\t}\n+\t\tstaticMetadata_->addEntry(ANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n+\t\t\t\t\t data.data(), data.size());\n+\t}\n \n \t/* Scaler static metadata. */\n \tfloat maxDigitalZoom = 1;\n", "prefixes": [ "libcamera-devel", "v4", "10/12" ] }