Patch Detail
Show a patch.
GET /api/patches/10216/?format=api
{ "id": 10216, "url": "https://patchwork.libcamera.org/api/patches/10216/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10216/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201023102159.26274-4-david.plowman@raspberrypi.com>", "date": "2020-10-23T10:21:57", "name": "[libcamera-devel,v5,3/5] libcamera: raspberrypi: Initialise the SensorCropMaximum property", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f316365b75df552b86371c37d7288cf13228b060", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10216/mbox/", "series": [ { "id": 1409, "url": "https://patchwork.libcamera.org/api/series/1409/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1409", "date": "2020-10-23T10:21:54", "name": "Digital zoom", "version": 5, "mbox": "https://patchwork.libcamera.org/series/1409/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10216/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10216/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E217C3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Oct 2020 10:22:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8280615D3;\n\tFri, 23 Oct 2020 12:22:08 +0200 (CEST)", "from mail-wm1-x344.google.com (mail-wm1-x344.google.com\n\t[IPv6:2a00:1450:4864:20::344])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52DDF615D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 12:22:06 +0200 (CEST)", "by mail-wm1-x344.google.com with SMTP id l20so266709wme.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 03:22:06 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tr128sm2477831wma.20.2020.10.23.03.22.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 23 Oct 2020 03:22:05 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"EJv8oi4B\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uQQaHb0XmHtsHhkWw0OAl06JWoDByjyQ5++hI8L9kB8=;\n\tb=EJv8oi4BI7vfCDdDCz/8w1hBaQLBDqGqNiHq/a0KpxEGFtYfKbUZo7Ah/z1QhvKWyZ\n\td/riNQ8/pHkY/2m26fsuLUX4Tu/yV2G+j7wEbgNx2ryTK4pIUw7BPjJm69EOQmtxA1id\n\t9Q34rwe3VHQLhKdi/ejHBx8NfUzYsirNQPgrTxaUnh4fjQ0B0uvGAI6vKHlccWvGaGwt\n\tUcDwr8wgtpL/2LCwsVvEtX1e0Qkrk+nVQBGkin/j6ETDvN2+BzV0oftetN5AMEjf7RoQ\n\taz2CWLEZY+aqGx4fZMDu2KS4vJ6Fq5Qaxf1bp5KKSFyE+YjU52Uo+k8GAS7OJnMJHubj\n\tsDFQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uQQaHb0XmHtsHhkWw0OAl06JWoDByjyQ5++hI8L9kB8=;\n\tb=mmFDaaSmGWu87yRuakkhwjTJDG8yIzPGW4vsRvvye2/c1YHEhFtdOLLaHMlGfR6DrX\n\tUwzoJp30X9cvwfE91Kn+zP3lhomNk/IumrSZ6cY43KD5ovrDPHmDhDyXkdSfIQaVLWky\n\tyEiNCK0CSc++W84QuTTAJ+cXjfNHOvSMOv0nO4aywCb/L7/wQahWnrtAi+Qdj4eJvMNM\n\t4KLeHjKpwOgPKuLGyCIM6hBGD5JrvdB7q/N1fEqWamgIaTY2RAsLCQVGAzo6Nakom0mb\n\tFTxnJw6ZSjHaRxo01IPn+pGTUW8EiUKBh1ttkdnE+f1J1omGmlLtF2deRzhOjRZ+SVPh\n\tUaxg==", "X-Gm-Message-State": "AOAM533e4o+wdBnc87KuIdissWg6AaE6qVutBX19gfDTVC9l9hXowDbH\n\t7iY0d/o+wFky9rdEkkelWp0HYHL4V645fg==", "X-Google-Smtp-Source": "ABdhPJwO1BsjvQMns1d3Plw6wG4zmO/luoh8XSPkgieO7pPWT1214MBCuT9tk/J9oPS2SOBiM39AwA==", "X-Received": "by 2002:a1c:7518:: with SMTP id\n\to24mr1623674wmc.137.1603448525868; \n\tFri, 23 Oct 2020 03:22:05 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Oct 2020 11:21:57 +0100", "Message-Id": "<20201023102159.26274-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201023102159.26274-1-david.plowman@raspberrypi.com>", "References": "<20201023102159.26274-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v5 3/5] libcamera: raspberrypi: Initialise\n\tthe SensorCropMaximum property", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Initialise it to show we support its use, however, set it to all\nzeroes to indicate that it's not meaningful yet.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex dd62dfc7..763451a8 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -926,6 +926,13 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t/* Initialize the camera properties. */\n \tdata->properties_ = data->sensor_->properties();\n \n+\t/*\n+\t * Set a default value for the ScalerCropMaximum property to show\n+\t * that we support its use, however, initialise it to zero because\n+\t * it's not meaningful until a camera mode has been chosen.\n+\t */\n+\tdata->properties_.set(properties::ScalerCropMaximum, Rectangle{});\n+\n \t/*\n \t * We cache three things about the sensor in relation to transforms\n \t * (meaning horizontal and vertical flips).\n", "prefixes": [ "libcamera-devel", "v5", "3/5" ] }