Patch Detail
Show a patch.
GET /api/patches/10209/?format=api
{ "id": 10209, "url": "https://patchwork.libcamera.org/api/patches/10209/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10209/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201023051411.81515-2-email@uajain.com>", "date": "2020-10-23T05:14:11", "name": "[libcamera-devel,2/2] android: jpeg: encoder: Use pass-by-value for Exif parameter", "commit_ref": "c430d39d203488cf93ab4f12ff9eb8b3c6380212", "pull_url": null, "state": "accepted", "archived": false, "hash": "4e8ff68970c386fc1d8413f8dd9ffebf840381d3", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10209/mbox/", "series": [ { "id": 1406, "url": "https://patchwork.libcamera.org/api/series/1406/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1406", "date": "2020-10-23T05:14:10", "name": "[libcamera-devel,1/2] android: jpeg: Drop \"libcamera::\" namespace from functions' arguments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1406/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10209/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10209/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2233C3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Oct 2020 05:14:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2CE1615D9;\n\tFri, 23 Oct 2020 07:14:21 +0200 (CEST)", "from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC644615D3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 07:14:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"LRg/yoCo\"; dkim-atps=neutral", "From": "Umang Jain <email@uajain.com>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603430059; bh=WWJRqGWEisSX7a+DKokU3Hs2tKqPMLtdllVbxFFGvoI=;\n\th=From:To:Cc:Subject:In-Reply-To:References;\n\tb=LRg/yoCoApHL3rq4iRYFSc2sUyHg5cazeGjKvp+tW2E7HnU+7LVk7ANFo050yM/S4\n\tYxF1TRyRJIKW0157bxWBDSKK5ZDxZMcm/vRi50nZPPTgZrlJS5qQwbzP1TPEo92+8X\n\tPgO6RCo+PgysxQEAujVvMxHgMO+hLJubI0MNddQKovKhsz3GJfwFWox16mnPzTDWA+\n\tAcBiz/8uBxXRH34Nqg4wU28D0e7K9Wv3c7FimoIMzovcWUHzteYkGvAaLjopzrMP5a\n\tVPmKdj8HB64xfFgBPOT0D/6ujyE5UTwFtO2qLx4P0OI7yC4QUi6/w74yt570EE8HNP\n\t1OSJs4ui4BSNQ==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Oct 2020 10:44:11 +0530", "Message-Id": "<20201023051411.81515-2-email@uajain.com>", "In-Reply-To": "<20201023051411.81515-1-email@uajain.com>", "References": "<20201023051411.81515-1-email@uajain.com>", "Mime-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] android: jpeg: encoder: Use\n\tpass-by-value for Exif parameter", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Following the reasoning of pass-by-value for libcamera::Span\nparameters from 90c193f2a700(\"android: Modify Encoder interface\") i.e.\nthey are easy to copy/move/construct, align the Exif parameter passing\nto the encoder interface in this consistent way.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/android/jpeg/encoder.h | 2 +-\n src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n src/android/jpeg/encoder_libjpeg.h | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\nindex 270ea60..94b3340 100644\n--- a/src/android/jpeg/encoder.h\n+++ b/src/android/jpeg/encoder.h\n@@ -19,7 +19,7 @@ public:\n \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n \tvirtual int encode(const libcamera::FrameBuffer &source,\n \t\t\t libcamera::Span<uint8_t> destination,\n-\t\t\t const libcamera::Span<const uint8_t> &exifData) = 0;\n+\t\t\t libcamera::Span<const uint8_t> exifData) = 0;\n };\n \n #endif /* __ANDROID_JPEG_ENCODER_H__ */\ndiff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\nindex 4bea10c..cfa5332 100644\n--- a/src/android/jpeg/encoder_libjpeg.cpp\n+++ b/src/android/jpeg/encoder_libjpeg.cpp\n@@ -180,7 +180,7 @@ void EncoderLibJpeg::compressNV(const MappedBuffer *frame)\n }\n \n int EncoderLibJpeg::encode(const FrameBuffer &source, Span<uint8_t> dest,\n-\t\t\t const Span<const uint8_t> &exifData)\n+\t\t\t Span<const uint8_t> exifData)\n {\n \tMappedFrameBuffer frame(&source, PROT_READ);\n \tif (!frame.isValid()) {\ndiff --git a/src/android/jpeg/encoder_libjpeg.h b/src/android/jpeg/encoder_libjpeg.h\nindex 391a53c..40505dd 100644\n--- a/src/android/jpeg/encoder_libjpeg.h\n+++ b/src/android/jpeg/encoder_libjpeg.h\n@@ -23,7 +23,7 @@ public:\n \tint configure(const libcamera::StreamConfiguration &cfg) override;\n \tint encode(const libcamera::FrameBuffer &source,\n \t\t libcamera::Span<uint8_t> destination,\n-\t\t const libcamera::Span<const uint8_t> &exifData) override;\n+\t\t libcamera::Span<const uint8_t> exifData) override;\n \n private:\n \tvoid compressRGB(const libcamera::MappedBuffer *frame);\n", "prefixes": [ "libcamera-devel", "2/2" ] }