Patch Detail
Show a patch.
GET /api/patches/10208/?format=api
{ "id": 10208, "url": "https://patchwork.libcamera.org/api/patches/10208/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10208/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201023051411.81515-1-email@uajain.com>", "date": "2020-10-23T05:14:10", "name": "[libcamera-devel,1/2] android: jpeg: Drop \"libcamera::\" namespace from functions' arguments", "commit_ref": "f9e7f55f3b2cdee93a51cf7f39a2e72b4c453e00", "pull_url": null, "state": "accepted", "archived": false, "hash": "ce85f9c205b3f5505b510940e734d777ac0fd2ac", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10208/mbox/", "series": [ { "id": 1406, "url": "https://patchwork.libcamera.org/api/series/1406/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1406", "date": "2020-10-23T05:14:10", "name": "[libcamera-devel,1/2] android: jpeg: Drop \"libcamera::\" namespace from functions' arguments", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1406/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10208/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10208/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BE47C3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Oct 2020 05:14:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A27E6034E;\n\tFri, 23 Oct 2020 07:14:19 +0200 (CEST)", "from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 620BC6034E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 07:14:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"R0tavHqv\"; dkim-atps=neutral", "From": "Umang Jain <email@uajain.com>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1603430056; bh=eC+gq9Q43EnkJP579KhiBi3Is8d/7X536clIy2smHuE=;\n\th=From:To:Cc:Subject;\n\tb=R0tavHqvv7buShWtf+XvnMqj3Ijq29augZE3RruH7Ss692SxsdPE2nXCdUEuNoMgP\n\tAkytx6XlJMh27Mrmb27CApKvmJbSNY1RLyqGWYQydoXUAeSrjeOwu+QfWu4rhO5VEl\n\tUAyJYQEpYY7/ICHwbK0gH79eWLy3mwR44KqjeBuUhuTU/Yfy00Z3LsvzWt5Gq7fAMl\n\t4CCfOpDz3EVsgEUHmgqnHH8GI9RLnPdNni3pmxT2PAvRioWtsJSv4375Glgv9b3BLJ\n\tyHFAxrjaSW35p3sABEgQ5tREdsqawCml6NppebG3vwFZV02Wefr666qHfbuu+RTN29\n\t/QOK2nn4t3E6Q==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Oct 2020 10:44:10 +0530", "Message-Id": "<20201023051411.81515-1-email@uajain.com>", "Mime-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/2] android: jpeg: Drop \"libcamera::\"\n\tnamespace from functions' arguments", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Drop \"libcamera::\" from functions' arguments for *.cpp files as they are\nalready declared via the function signatures in their respective header\nfiles.\n\nSigned-off-by: Umang Jain <email@uajain.com>\n---\n src/android/jpeg/encoder_libjpeg.cpp | 9 ++++-----\n src/android/jpeg/post_processor_jpeg.cpp | 4 ++--\n 2 files changed, 6 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\nindex 5a2f88f..4bea10c 100644\n--- a/src/android/jpeg/encoder_libjpeg.cpp\n+++ b/src/android/jpeg/encoder_libjpeg.cpp\n@@ -104,7 +104,7 @@ int EncoderLibJpeg::configure(const StreamConfiguration &cfg)\n \treturn 0;\n }\n \n-void EncoderLibJpeg::compressRGB(const libcamera::MappedBuffer *frame)\n+void EncoderLibJpeg::compressRGB(const MappedBuffer *frame)\n {\n \tunsigned char *src = static_cast<unsigned char *>(frame->maps()[0].data());\n \t/* \\todo Stride information should come from buffer configuration. */\n@@ -122,7 +122,7 @@ void EncoderLibJpeg::compressRGB(const libcamera::MappedBuffer *frame)\n * Compress the incoming buffer from a supported NV format.\n * This naively unpacks the semi-planar NV12 to a YUV888 format for libjpeg.\n */\n-void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n+void EncoderLibJpeg::compressNV(const MappedBuffer *frame)\n {\n \tuint8_t tmprowbuf[compress_.image_width * 3];\n \n@@ -179,9 +179,8 @@ void EncoderLibJpeg::compressNV(const libcamera::MappedBuffer *frame)\n \t}\n }\n \n-int EncoderLibJpeg::encode(const FrameBuffer &source,\n-\t\t\t libcamera::Span<uint8_t> dest,\n-\t\t\t const libcamera::Span<const uint8_t> &exifData)\n+int EncoderLibJpeg::encode(const FrameBuffer &source, Span<uint8_t> dest,\n+\t\t\t const Span<const uint8_t> &exifData)\n {\n \tMappedFrameBuffer frame(&source, PROT_READ);\n \tif (!frame.isValid()) {\ndiff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex fd1c7be..93acfe5 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -44,8 +44,8 @@ int PostProcessorJpeg::configure(const StreamConfiguration &inCfg,\n \treturn encoder_->configure(inCfg);\n }\n \n-int PostProcessorJpeg::process(const libcamera::FrameBuffer &source,\n-\t\t\t libcamera::Span<uint8_t> destination,\n+int PostProcessorJpeg::process(const FrameBuffer &source,\n+\t\t\t Span<uint8_t> destination,\n \t\t\t CameraMetadata *metadata)\n {\n \tif (!encoder_)\n", "prefixes": [ "libcamera-devel", "1/2" ] }