Patch Detail
Show a patch.
GET /api/patches/10186/?format=api
{ "id": 10186, "url": "https://patchwork.libcamera.org/api/patches/10186/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10186/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201021154148.511505-10-kieran.bingham@ideasonboard.com>", "date": "2020-10-21T15:41:42", "name": "[libcamera-devel,v4,09/15] android: camera_device: Rename shadowed variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b69ba2cf18a60c10b43acdfc1884a5acf13159f3", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10186/mbox/", "series": [ { "id": 1401, "url": "https://patchwork.libcamera.org/api/series/1401/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1401", "date": "2020-10-21T15:41:33", "name": "Shadowed Variables", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1401/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10186/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10186/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C60CBDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Oct 2020 15:42:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 432EE60995;\n\tWed, 21 Oct 2020 17:42:02 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56F4360E31\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Oct 2020 17:41:56 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 014F292;\n\tWed, 21 Oct 2020 17:41:55 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s/Wr8be5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603294916;\n\tbh=7XRIr5RtZR4JrnPX+8VdL17j1FfDzRAPZsCq5A5ApUA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=s/Wr8be5VzhB0W8D3HZn4g5c+HLTM25VFXn4NOC+b6T3nBzW+282hlm9pwqSRwC/B\n\tcwuJVVUrPO/pN/A1vjSM7d6JuwVTzx3LHsr4oozglVG/BqcerE+zn5YQ2v+CEobfEM\n\tBKDIi1VKatUpoXqiVi1yMalMOuYhSBM+Cf5ZPtbs=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Wed, 21 Oct 2020 16:41:42 +0100", "Message-Id": "<20201021154148.511505-10-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201021154148.511505-1-kieran.bingham@ideasonboard.com>", "References": "<20201021154148.511505-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 09/15] android: camera_device: Rename\n\tshadowed variable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "A FrameBuffer *buffer is used to obtain the 'first' buffer from a\nrequest which is used purely to identify the timestamp from the\nmetadata.\n\nThis should be determined by the Request, and set appropriately by the\npipeline handlers, but make sure that this buffer instance is distinct\nfor now.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/android/camera_device.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 9cf1c98410f9..7bb2560025e2 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1488,9 +1488,9 @@ void CameraDevice::requestComplete(Request *request)\n \t * It might be appropriate to return a 'correct' (as determined by\n \t * pipeline handlers) timestamp in the Request itself.\n \t */\n-\tFrameBuffer *buffer = buffers.begin()->second;\n+\tFrameBuffer *timestampBuf = buffers.begin()->second;\n \tresultMetadata = getResultMetadata(descriptor->frameNumber_,\n-\t\t\t\t\t buffer->metadata().timestamp);\n+\t\t\t\t\t timestampBuf->metadata().timestamp);\n \n \t/* Handle any JPEG compression. */\n \tfor (unsigned int i = 0; i < descriptor->numBuffers_; ++i) {\n@@ -1548,7 +1548,7 @@ void CameraDevice::requestComplete(Request *request)\n \n \tif (status == CAMERA3_BUFFER_STATUS_OK) {\n \t\tnotifyShutter(descriptor->frameNumber_,\n-\t\t\t buffer->metadata().timestamp);\n+\t\t\t timestampBuf->metadata().timestamp);\n \n \t\tcaptureResult.partial_result = 1;\n \t\tcaptureResult.result = resultMetadata->get();\n", "prefixes": [ "libcamera-devel", "v4", "09/15" ] }