Patch Detail
Show a patch.
GET /api/patches/10166/?format=api
{ "id": 10166, "url": "https://patchwork.libcamera.org/api/patches/10166/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10166/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201021143635.22846-6-jacopo@jmondi.org>", "date": "2020-10-21T14:36:26", "name": "[libcamera-devel,v3,05/14] libcamera: controls: Rename enumerate values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8c1dada5c1b4619b6c644acf2b8c6f7913963f91", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10166/mbox/", "series": [ { "id": 1399, "url": "https://patchwork.libcamera.org/api/series/1399/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1399", "date": "2020-10-21T14:36:21", "name": "libcamera: Introduce draft controls", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1399/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10166/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10166/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 785D7BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Oct 2020 14:36:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2415C61E4E;\n\tWed, 21 Oct 2020 16:36:49 +0200 (CEST)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2FF861DE9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Oct 2020 16:36:46 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 996BEC0005;\n\tWed, 21 Oct 2020 14:36:46 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 21 Oct 2020 16:36:26 +0200", "Message-Id": "<20201021143635.22846-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201021143635.22846-1-jacopo@jmondi.org>", "References": "<20201021143635.22846-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 05/14] libcamera: controls: Rename\n\tenumerate values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename the enumeration of supported values with the suffix \"Enum\"\nin place of \"Values\" to prepare to re-use the suffix \"Values\"\nfor the vector of Control's value introduced by the next patch.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n utils/gen-controls.py | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 93cb3885c3da..bf681503f86a 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -24,9 +24,9 @@ def format_description(description):\n \n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n- * \\\\enum ${name}Values\n+ * \\\\enum ${name}Enum\n * \\\\brief Supported ${name} values''')\n- enum_doc_value_template = string.Template(''' * \\\\var ${name}Values::${value}\n+ enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n ${description}''')\n doc_template = string.Template('''/**\n * \\\\var ${name}\n@@ -98,7 +98,7 @@ ${description}\n \n \n def generate_h(controls):\n- enum_template_start = string.Template('''enum ${name}Values {''')\n+ enum_template_start = string.Template('''enum ${name}Enum {''')\n enum_value_template = string.Template('''\\t${name} = ${value},''')\n template = string.Template('''extern const Control<${type}> ${name};''')\n \n", "prefixes": [ "libcamera-devel", "v3", "05/14" ] }