Patch Detail
Show a patch.
GET /api/patches/10137/?format=api
{ "id": 10137, "url": "https://patchwork.libcamera.org/api/patches/10137/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10137/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020180534.36855-5-jacopo@jmondi.org>", "date": "2020-10-20T18:05:25", "name": "[libcamera-devel,v2,04/13] libcamera: controls: Construct from values list", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0a465964a72931267d3bf0ac22769d27b82303ef", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10137/mbox/", "series": [ { "id": 1391, "url": "https://patchwork.libcamera.org/api/series/1391/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1391", "date": "2020-10-20T18:05:21", "name": "libcamera: Introduce draft controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1391/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10137/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10137/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D350BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 16:05:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3AF561DC5;\n\tTue, 20 Oct 2020 18:05:19 +0200 (CEST)", "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 387B561DCF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 18:05:17 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 507B1240011;\n\tTue, 20 Oct 2020 16:05:15 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 20:05:25 +0200", "Message-Id": "<20201020180534.36855-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201020180534.36855-1-jacopo@jmondi.org>", "References": "<20201020180534.36855-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 04/13] libcamera: controls: Construct\n\tfrom values list", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a constructor to the ControlInfo class that allows creating\na class instance from the list of the control supported values.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/controls.h | 1 +\n src/libcamera/controls.cpp | 17 +++++++++++++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex d1f6d4490c35..d4fdf5807f1c 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -269,6 +269,7 @@ public:\n \t\t\t const ControlValue &max = 0,\n \t\t\t const ControlValue &def = 0,\n \t\t\t const std::vector<ControlValue> &values = {});\n+\texplicit ControlInfo(const std::vector<ControlValue> &values);\n \n \tconst ControlValue &min() const { return min_; }\n \tconst ControlValue &max() const { return max_; }\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 61feee37a1b8..e80f6116a684 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -493,6 +493,23 @@ ControlInfo::ControlInfo(const ControlValue &min,\n {\n }\n \n+/**\n+ * \\brief Construct a ControlInfo from the list of supported values\n+ * \\param[in] values The control supported values\n+ *\n+ * Construct a ControlInfo from a list of supported values. The ControlInfo\n+ * minimum and maximum values are assigned to the first and last members of\n+ * the values list respectively. The ControlInfo default value is set to be\n+ * equal to the minimum one.\n+ */\n+ControlInfo::ControlInfo(const std::vector<ControlValue> &values)\n+\t: values_(values)\n+{\n+\tmin_ = values_.front();\n+\tmax_ = values_.back();\n+\tdef_ = min_;\n+}\n+\n /**\n * \\fn ControlInfo::min()\n * \\brief Retrieve the minimum value of the control\n", "prefixes": [ "libcamera-devel", "v2", "04/13" ] }