Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 10125,
    "url": "https://patchwork.libcamera.org/api/patches/10125/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/10125/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20201020091505.138898-1-hiroh@chromium.org>",
    "date": "2020-10-20T09:14:58",
    "name": "[libcamera-devel,v2,1/8] test: Omit extra semicolons",
    "commit_ref": "e0fd0169adf928d288f2805754c088874daa1b50",
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "a5cf9ef4be3bdf5e4d175a54b987cccf4f7dcc6b",
    "submitter": {
        "id": 63,
        "url": "https://patchwork.libcamera.org/api/people/63/?format=api",
        "name": "Hirokazu Honda",
        "email": "hiroh@chromium.org"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/10125/mbox/",
    "series": [
        {
            "id": 1390,
            "url": "https://patchwork.libcamera.org/api/series/1390/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1390",
            "date": "2020-10-20T09:14:58",
            "name": "[libcamera-devel,v2,1/8] test: Omit extra semicolons",
            "version": 2,
            "mbox": "https://patchwork.libcamera.org/series/1390/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/10125/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/10125/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12CFBBDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 09:15:15 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99F8061394;\n\tTue, 20 Oct 2020 11:15:14 +0200 (CEST)",
            "from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com\n\t[IPv6:2607:f8b0:4864:20::52c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F16BC6052F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 11:15:13 +0200 (CEST)",
            "by mail-pg1-x52c.google.com with SMTP id x13so707221pgp.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 02:15:13 -0700 (PDT)",
            "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tp8sm1482014pgs.34.2020.10.20.02.15.10\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 02:15:11 -0700 (PDT)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"E8kvtlPb\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=5PEcV1eiUI8e2za3YJ9sykYFk0EVhJhTiZjs/x7iafQ=;\n\tb=E8kvtlPbhv5+KY8N4klDLpk8jiqbRqW1Cpeje8+WLIl+GNcc/hO/B87h0MypKQ8lR7\n\taUsZHPVqBD6ZZrZTdjNfmgORj51sZnKCDBcJwPQB3icEm5rV+1Ejc4940e3Z3FmE47+r\n\t9jP7wYgUp5sEbOfA8y7XfTGojBOEP7AEKzX3A=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=5PEcV1eiUI8e2za3YJ9sykYFk0EVhJhTiZjs/x7iafQ=;\n\tb=U4XgtWygavVSubSqacF6nAF5XM098chvpm3mZ/1o4D1TmhEu6Wbv5fXndWwGUf2eGv\n\tTlzq5gbnE9XxW32RGRenTvHmw46MUtOCb6UJQX9KS3DTSyWoCZLVb2wmriOVCnrov/Ex\n\tuSjSRk9i77TjzteDOOqfACv5XOzY/r+mx+uEQhsfP/OXDQqS8WGWe8yYf/6y5FPIH8qT\n\tzuo/LFukcL737rgQtRaMFGy4PVTAiDf/7QlmOYX157XnoanU3URyvVi/yoeknIOGSouo\n\tFFy200Bp2EkC90S7K4D3c2qFfK29Efct1xqzkE90TemPA+mfTNKsLiW4vDXczniYFz7a\n\tkEoQ==",
        "X-Gm-Message-State": "AOAM531iMkYjQAHV1huTMTl9HPsOf3cGin7veQ6jWelEH6f3zgWzT5Gr\n\t49W3JqvWSfWXxgvBB8pR4nlaSq7eG/tkfQ==",
        "X-Google-Smtp-Source": "ABdhPJwrXVd50fyyAuOBZi29UsZTh6GjTsJV5a7Hh9Pax04fq4CuNGq7EsF+d3oFR+1Ht0fM/Clx8w==",
        "X-Received": "by 2002:a63:3004:: with SMTP id w4mr1817814pgw.249.1603185312202;\n\tTue, 20 Oct 2020 02:15:12 -0700 (PDT)",
        "From": "Hirokazu Honda <hiroh@chromium.org>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Tue, 20 Oct 2020 18:14:58 +0900",
        "Message-Id": "<20201020091505.138898-1-hiroh@chromium.org>",
        "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog",
        "MIME-Version": "1.0",
        "Subject": "[libcamera-devel] [PATCH v2 1/8] test: Omit extra semicolons",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "Content-Type": "text/plain; charset=\"us-ascii\"",
        "Content-Transfer-Encoding": "7bit",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "TEST_REGISTER macro is main function. The end semicolon with the\nmacro is unnecessary.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/camera/buffer_import.cpp                 | 2 +-\n test/camera/capture.cpp                       | 2 +-\n test/camera/configuration_default.cpp         | 2 +-\n test/camera/configuration_set.cpp             | 2 +-\n test/camera/statemachine.cpp                  | 2 +-\n test/mapped-buffer.cpp                        | 2 +-\n test/media_device/media_device_acquire.cpp    | 2 +-\n test/media_device/media_device_link_test.cpp  | 2 +-\n test/media_device/media_device_print_test.cpp | 2 +-\n test/v4l2_subdevice/list_formats.cpp          | 2 +-\n test/v4l2_subdevice/test_formats.cpp          | 2 +-\n test/v4l2_videodevice/buffer_cache.cpp        | 2 +-\n test/v4l2_videodevice/buffer_sharing.cpp      | 2 +-\n test/v4l2_videodevice/capture_async.cpp       | 2 +-\n test/v4l2_videodevice/controls.cpp            | 2 +-\n test/v4l2_videodevice/double_open.cpp         | 2 +-\n test/v4l2_videodevice/formats.cpp             | 2 +-\n test/v4l2_videodevice/request_buffers.cpp     | 2 +-\n test/v4l2_videodevice/stream_on_off.cpp       | 2 +-\n test/v4l2_videodevice/v4l2_m2mdevice.cpp      | 4 ++--\n 20 files changed, 21 insertions(+), 21 deletions(-)",
    "diff": "diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\nindex 72ce7b7..4b626df 100644\n--- a/test/camera/buffer_import.cpp\n+++ b/test/camera/buffer_import.cpp\n@@ -168,4 +168,4 @@ private:\n \n } /* namespace */\n \n-TEST_REGISTER(BufferImportTest);\n+TEST_REGISTER(BufferImportTest)\ndiff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\nindex c077080..f13ca53 100644\n--- a/test/camera/capture.cpp\n+++ b/test/camera/capture.cpp\n@@ -168,4 +168,4 @@ protected:\n \n } /* namespace */\n \n-TEST_REGISTER(Capture);\n+TEST_REGISTER(Capture)\ndiff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\nindex cdd6cb9..c2b2019 100644\n--- a/test/camera/configuration_default.cpp\n+++ b/test/camera/configuration_default.cpp\n@@ -56,4 +56,4 @@ protected:\n \n } /* namespace */\n \n-TEST_REGISTER(ConfigurationDefault);\n+TEST_REGISTER(ConfigurationDefault)\ndiff --git a/test/camera/configuration_set.cpp b/test/camera/configuration_set.cpp\nindex 30f19ba..a1dc446 100644\n--- a/test/camera/configuration_set.cpp\n+++ b/test/camera/configuration_set.cpp\n@@ -102,4 +102,4 @@ protected:\n \n } /* namespace */\n \n-TEST_REGISTER(ConfigurationSet);\n+TEST_REGISTER(ConfigurationSet)\ndiff --git a/test/camera/statemachine.cpp b/test/camera/statemachine.cpp\nindex e63ab29..f0c3d77 100644\n--- a/test/camera/statemachine.cpp\n+++ b/test/camera/statemachine.cpp\n@@ -211,4 +211,4 @@ protected:\n \n } /* namespace */\n \n-TEST_REGISTER(Statemachine);\n+TEST_REGISTER(Statemachine)\ndiff --git a/test/mapped-buffer.cpp b/test/mapped-buffer.cpp\nindex 0279233..5de8201 100644\n--- a/test/mapped-buffer.cpp\n+++ b/test/mapped-buffer.cpp\n@@ -113,4 +113,4 @@ private:\n \n } /* namespace */\n \n-TEST_REGISTER(MappedBufferTest);\n+TEST_REGISTER(MappedBufferTest)\ndiff --git a/test/media_device/media_device_acquire.cpp b/test/media_device/media_device_acquire.cpp\nindex d1e3d74..371e30e 100644\n--- a/test/media_device/media_device_acquire.cpp\n+++ b/test/media_device/media_device_acquire.cpp\n@@ -30,4 +30,4 @@ class MediaDeviceAcquire : public MediaDeviceTest\n \t}\n };\n \n-TEST_REGISTER(MediaDeviceAcquire);\n+TEST_REGISTER(MediaDeviceAcquire)\ndiff --git a/test/media_device/media_device_link_test.cpp b/test/media_device/media_device_link_test.cpp\nindex fe7542b..5c74905 100644\n--- a/test/media_device/media_device_link_test.cpp\n+++ b/test/media_device/media_device_link_test.cpp\n@@ -219,4 +219,4 @@ class MediaDeviceLinkTest : public MediaDeviceTest\n \t}\n };\n \n-TEST_REGISTER(MediaDeviceLinkTest);\n+TEST_REGISTER(MediaDeviceLinkTest)\ndiff --git a/test/media_device/media_device_print_test.cpp b/test/media_device/media_device_print_test.cpp\nindex 1f5e3f3..436d4e8 100644\n--- a/test/media_device/media_device_print_test.cpp\n+++ b/test/media_device/media_device_print_test.cpp\n@@ -151,4 +151,4 @@ int MediaDevicePrintTest::run()\n \treturn ret;\n }\n \n-TEST_REGISTER(MediaDevicePrintTest);\n+TEST_REGISTER(MediaDevicePrintTest)\ndiff --git a/test/v4l2_subdevice/list_formats.cpp b/test/v4l2_subdevice/list_formats.cpp\nindex a6044c0..74ec81a 100644\n--- a/test/v4l2_subdevice/list_formats.cpp\n+++ b/test/v4l2_subdevice/list_formats.cpp\n@@ -79,4 +79,4 @@ int ListFormatsTest::run()\n \treturn TestPass;\n }\n \n-TEST_REGISTER(ListFormatsTest);\n+TEST_REGISTER(ListFormatsTest)\ndiff --git a/test/v4l2_subdevice/test_formats.cpp b/test/v4l2_subdevice/test_formats.cpp\nindex 679f50b..47f979e 100644\n--- a/test/v4l2_subdevice/test_formats.cpp\n+++ b/test/v4l2_subdevice/test_formats.cpp\n@@ -75,4 +75,4 @@ int FormatHandlingTest::run()\n \treturn TestPass;\n }\n \n-TEST_REGISTER(FormatHandlingTest);\n+TEST_REGISTER(FormatHandlingTest)\ndiff --git a/test/v4l2_videodevice/buffer_cache.cpp b/test/v4l2_videodevice/buffer_cache.cpp\nindex b22de88..b3f2bec 100644\n--- a/test/v4l2_videodevice/buffer_cache.cpp\n+++ b/test/v4l2_videodevice/buffer_cache.cpp\n@@ -213,4 +213,4 @@ private:\n \n } /* namespace */\n \n-TEST_REGISTER(BufferCacheTest);\n+TEST_REGISTER(BufferCacheTest)\ndiff --git a/test/v4l2_videodevice/buffer_sharing.cpp b/test/v4l2_videodevice/buffer_sharing.cpp\nindex ba2cc40..5e7e2d9 100644\n--- a/test/v4l2_videodevice/buffer_sharing.cpp\n+++ b/test/v4l2_videodevice/buffer_sharing.cpp\n@@ -200,4 +200,4 @@ private:\n \tunsigned int framesOutput_;\n };\n \n-TEST_REGISTER(BufferSharingTest);\n+TEST_REGISTER(BufferSharingTest)\ndiff --git a/test/v4l2_videodevice/capture_async.cpp b/test/v4l2_videodevice/capture_async.cpp\nindex 13cbcc8..2b38102 100644\n--- a/test/v4l2_videodevice/capture_async.cpp\n+++ b/test/v4l2_videodevice/capture_async.cpp\n@@ -88,4 +88,4 @@ private:\n \tunsigned int frames;\n };\n \n-TEST_REGISTER(CaptureAsyncTest);\n+TEST_REGISTER(CaptureAsyncTest)\ndiff --git a/test/v4l2_videodevice/controls.cpp b/test/v4l2_videodevice/controls.cpp\nindex 9f09d03..8d42508 100644\n--- a/test/v4l2_videodevice/controls.cpp\n+++ b/test/v4l2_videodevice/controls.cpp\n@@ -127,4 +127,4 @@ protected:\n \t}\n };\n \n-TEST_REGISTER(V4L2ControlTest);\n+TEST_REGISTER(V4L2ControlTest)\ndiff --git a/test/v4l2_videodevice/double_open.cpp b/test/v4l2_videodevice/double_open.cpp\nindex 5768d40..7d11f6f 100644\n--- a/test/v4l2_videodevice/double_open.cpp\n+++ b/test/v4l2_videodevice/double_open.cpp\n@@ -38,4 +38,4 @@ protected:\n \n } /* namespace */\n \n-TEST_REGISTER(DoubleOpen);\n+TEST_REGISTER(DoubleOpen)\ndiff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\nindex 043732d..b5020d2 100644\n--- a/test/v4l2_videodevice/formats.cpp\n+++ b/test/v4l2_videodevice/formats.cpp\n@@ -74,4 +74,4 @@ protected:\n \t}\n };\n \n-TEST_REGISTER(Format);\n+TEST_REGISTER(Format)\ndiff --git a/test/v4l2_videodevice/request_buffers.cpp b/test/v4l2_videodevice/request_buffers.cpp\nindex 2f8dfe1..fb57714 100644\n--- a/test/v4l2_videodevice/request_buffers.cpp\n+++ b/test/v4l2_videodevice/request_buffers.cpp\n@@ -26,4 +26,4 @@ protected:\n \t}\n };\n \n-TEST_REGISTER(RequestBuffersTest);\n+TEST_REGISTER(RequestBuffersTest)\ndiff --git a/test/v4l2_videodevice/stream_on_off.cpp b/test/v4l2_videodevice/stream_on_off.cpp\nindex ce48310..4ed99e9 100644\n--- a/test/v4l2_videodevice/stream_on_off.cpp\n+++ b/test/v4l2_videodevice/stream_on_off.cpp\n@@ -33,4 +33,4 @@ protected:\n \t}\n };\n \n-TEST_REGISTER(StreamOnStreamOffTest);\n+TEST_REGISTER(StreamOnStreamOffTest)\ndiff --git a/test/v4l2_videodevice/v4l2_m2mdevice.cpp b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\nindex 44a39d4..616261e 100644\n--- a/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n+++ b/test/v4l2_videodevice/v4l2_m2mdevice.cpp\n@@ -187,7 +187,7 @@ protected:\n \tvoid cleanup()\n \t{\n \t\tdelete vim2m_;\n-\t};\n+\t}\n \n private:\n \tstd::unique_ptr<DeviceEnumerator> enumerator_;\n@@ -201,4 +201,4 @@ private:\n \tunsigned int captureFrames_;\n };\n \n-TEST_REGISTER(V4L2M2MDeviceTest);\n+TEST_REGISTER(V4L2M2MDeviceTest)\n",
    "prefixes": [
        "libcamera-devel",
        "v2",
        "1/8"
    ]
}