Patch Detail
Show a patch.
GET /api/patches/10123/?format=api
{ "id": 10123, "url": "https://patchwork.libcamera.org/api/patches/10123/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10123/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020074229.119151-3-hiroh@chromium.org>", "date": "2020-10-20T07:42:28", "name": "[libcamera-devel,v2,3/4] android: post_processor_jpeg: Make |cameraDevice_| constant", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "8938311cc610273780cd2761c7f2aa6271065b6b", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10123/mbox/", "series": [ { "id": 1389, "url": "https://patchwork.libcamera.org/api/series/1389/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1389", "date": "2020-10-20T07:42:26", "name": "[libcamera-devel,v2,1/4] android: Modify PostProcessor interface", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1389/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10123/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10123/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38D53BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 07:42:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03DDA60353;\n\tTue, 20 Oct 2020 09:42:45 +0200 (CEST)", "from mail-pf1-x435.google.com (mail-pf1-x435.google.com\n\t[IPv6:2607:f8b0:4864:20::435])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AB866052F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 09:42:43 +0200 (CEST)", "by mail-pf1-x435.google.com with SMTP id a200so686986pfa.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 00:42:42 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\td26sm1193684pfo.82.2020.10.20.00.42.39\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 00:42:40 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"EU/ORs1+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QWv+f2AKbdD4kKXg1LU+l+aZjUgqahucd+R0EdJRvEU=;\n\tb=EU/ORs1+f0qX/hsbd1YI5kaV135Ht27jREDNn9CKoT2H1BjGsMyUtMXCUIO8luJaVK\n\tyuNbGOvSI9IRV1R0qpvwZkb+DstbCjR0sHfE6tsqQ5x0m/S+m+g6TbhvRAK3/MU6FzMu\n\tffL4cxrHkQF9jLwcNfhhnYNBU8IOR0o5BQLYQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QWv+f2AKbdD4kKXg1LU+l+aZjUgqahucd+R0EdJRvEU=;\n\tb=mWVBBAbzjr2+EJGb3PgxFD6XHCNZZsrB301xOiHzPtDJXhy1t3fbMeQMieyrrHR79f\n\tM1iirkqKBZFwBF65aR0Ubc8K2i6JO0/iz0M1rwEV8WNQCdeuyV9H9q9f+oXatWGisTPR\n\tlJHBl9x77eSBoy8JiF6UXipF84b1+CZGfewY+mNIQ//dF8hzQIx9kDcPSZUS7408ZyOq\n\tQ/hZwjvXcAM53VvWZJxFQBGNkWx5iK9bcu3NvoasUZwk5gL8BWIpKWvYJ/43jQSE2j2G\n\tQ1kHUYmIBUn7Rofz0aD0ELr6SbK+4S7tYgwV8jMxgymS6RlolfbKzBxuxtRqNEQnIpKv\n\tNL5A==", "X-Gm-Message-State": "AOAM533EJlcqXRDB4hI3JKdeYuksfFEWMM4p5RZxyf6oC8XoRT6+ngVG\n\tzrhEO9wIuUnJJpz7ysJWvPNb2E8fpwUENA==", "X-Google-Smtp-Source": "ABdhPJwkTtTOV9foeilfoWwHJg//Y7rvfAZ+ygBq9Jqchcnu9scjOt3dbYcIQnufB2s4L13/RlDLMw==", "X-Received": "by 2002:a65:4144:: with SMTP id x4mr1580062pgp.432.1603179761527;\n\tTue, 20 Oct 2020 00:42:41 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 16:42:28 +0900", "Message-Id": "<20201020074229.119151-3-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog", "In-Reply-To": "<20201020074229.119151-1-hiroh@chromium.org>", "References": "<20201020074229.119151-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/4] android: post_processor_jpeg: Make\n\t|cameraDevice_| constant", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "PostProcessorJpeg doesn't have the ownership of CameraDevice given\nin the constructor. To clarify it, this makes the member variable\nconstant.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n src/android/jpeg/post_processor_jpeg.h | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 6f33631..f895d1f 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -20,7 +20,7 @@ using namespace libcamera;\n \n LOG_DEFINE_CATEGORY(JPEG);\n \n-PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n+PostProcessorJpeg::PostProcessorJpeg(CameraDevice const *device)\n \t: cameraDevice_(device)\n {\n }\ndiff --git a/src/android/jpeg/post_processor_jpeg.h b/src/android/jpeg/post_processor_jpeg.h\nindex ae636ff..8e25b29 100644\n--- a/src/android/jpeg/post_processor_jpeg.h\n+++ b/src/android/jpeg/post_processor_jpeg.h\n@@ -19,7 +19,7 @@ class CameraDevice;\n class PostProcessorJpeg : public PostProcessor\n {\n public:\n-\tPostProcessorJpeg(CameraDevice *device);\n+\tPostProcessorJpeg(CameraDevice const *device);\n \n \tint configure(const libcamera::StreamConfiguration &incfg,\n \t\t const libcamera::StreamConfiguration &outcfg) override;\n@@ -28,7 +28,7 @@ public:\n \t\t CameraMetadata *metadata) override;\n \n private:\n-\tCameraDevice *cameraDevice_;\n+\tCameraDevice const *cameraDevice_;\n \tstd::unique_ptr<Encoder> encoder_;\n \tlibcamera::Size streamSize_;\n };\n", "prefixes": [ "libcamera-devel", "v2", "3/4" ] }