Patch Detail
Show a patch.
GET /api/patches/10117/?format=api
{ "id": 10117, "url": "https://patchwork.libcamera.org/api/patches/10117/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10117/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020052905.89267-6-hiroh@chromium.org>", "date": "2020-10-20T05:29:02", "name": "[libcamera-devel,5/8] include: libcamera: Omit extra semicolons", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c8b1ad15352a862b049d7417a8d4d0eb8077580d", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10117/mbox/", "series": [ { "id": 1388, "url": "https://patchwork.libcamera.org/api/series/1388/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1388", "date": "2020-10-20T05:28:58", "name": "[libcamera-devel,1/8] test: Omit extra semicolons", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1388/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10117/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10117/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E95ABDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 05:29:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEB15613B7;\n\tTue, 20 Oct 2020 07:29:26 +0200 (CEST)", "from mail-pl1-x643.google.com (mail-pl1-x643.google.com\n\t[IPv6:2607:f8b0:4864:20::643])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A32E60351\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 07:29:25 +0200 (CEST)", "by mail-pl1-x643.google.com with SMTP id 1so418009ple.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Oct 2020 22:29:25 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm779043pfd.101.2020.10.19.22.29.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 22:29:23 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Ous87qis\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=rLJu1kSuY0/Xzy4HAc5K+DxVi4rKB5koCUImmo2buyc=;\n\tb=Ous87qis0O5ztRA0lyVc+6wm8v7hU8nr/GJBsbd+Sn8dmsZUNNqF5iGdLBaC37CVLD\n\tJace/UF/vQY0v6tqibc41l12ppcO0UkZrUqeKM/Ii+pHabXdwVX0OozioCGjI0DJtG72\n\tHJlj9yJihhqkdPseegeW/64naGQsjQg2uC33s=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=rLJu1kSuY0/Xzy4HAc5K+DxVi4rKB5koCUImmo2buyc=;\n\tb=oqMXalmG+7s3YDBBIuZUQRzTxLOhOZAM80V87+NWhsnQkV4CP1gRzInVSDMJr7ldkg\n\tMxCrxAT3Bw1i+m9ML4VeEAxpPHk7aFh/wLO6ZnTIc3ycAGO/ahA3ENHTdjL+05uG1jzz\n\tj7+Y0tsDNyTKmcU+dk3wwcdyj6Fygi1CT6VbDOwC2N+0Tn5aZqtEn5bN7cWDUIvU0Ntf\n\tT09g123lq6HJtoZ5MDbH1/AHhiA+wQaC5Os/R0I25nsv+xVVc01D9B4RZo8P+70V+pDI\n\tbslc8rR335x1hTRxgfwNasjwIbFrO+3xKBYFLCDeXWzbpr6T06t3K6zjFcWBbCpYlQcN\n\tdcVg==", "X-Gm-Message-State": "AOAM530Jl8YruOMA22B2OjScptxIH1GOWTOfR2GMLobBYzJlowTwXbnO\n\tdbpLYkLBluShuaT439i/y7WZSbHayVjSJA==", "X-Google-Smtp-Source": "ABdhPJyBXgxMqE5xGuE3Du90q0aordVtUtGcChPrVoaKkt2DybJK+HqcOoUgmItLihIYW7YhozxNww==", "X-Received": "by 2002:a17:90a:9f90:: with SMTP id\n\to16mr1363720pjp.180.1603171763742; \n\tMon, 19 Oct 2020 22:29:23 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 14:29:02 +0900", "Message-Id": "<20201020052905.89267-6-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog", "In-Reply-To": "<20201020052905.89267-1-hiroh@chromium.org>", "References": "<20201020052905.89267-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 5/8] include: libcamera: Omit extra\n\tsemicolons", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "REGISTER_PIPELINE_HANDLER macro is used with the end semicolon\neverywhere. This removes the end semicolon within the macro.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n include/libcamera/internal/pipeline_handler.h | 2 +-\n include/libcamera/span.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex a4e1b52..818a36a 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -145,7 +145,7 @@ private:\t\t\t\t\t\t\t\t\\\n \t\treturn new handler(manager);\t\t\t\t\\\n \t}\t\t\t\t\t\t\t\t\\\n };\t\t\t\t\t\t\t\t\t\\\n-static handler##Factory global_##handler##Factory;\n+static handler##Factory global_##handler##Factory\n \n } /* namespace libcamera */\n \ndiff --git a/include/libcamera/span.h b/include/libcamera/span.h\nindex a53a80b..c0e4399 100644\n--- a/include/libcamera/span.h\n+++ b/include/libcamera/span.h\n@@ -407,6 +407,6 @@ private:\n \tsize_type size_;\n };\n \n-}; /* namespace libcamera */\n+} /* namespace libcamera */\n \n #endif /* __LIBCAMERA_SPAN_H__ */\n", "prefixes": [ "libcamera-devel", "5/8" ] }