Patch Detail
Show a patch.
GET /api/patches/10114/?format=api
{ "id": 10114, "url": "https://patchwork.libcamera.org/api/patches/10114/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10114/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020052905.89267-3-hiroh@chromium.org>", "date": "2020-10-20T05:28:59", "name": "[libcamera-devel,2/8] v4l2: Omit extra semicolons", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d12a651cdb96014e3ec96914ffdca5b36836c1a1", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10114/mbox/", "series": [ { "id": 1388, "url": "https://patchwork.libcamera.org/api/series/1388/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1388", "date": "2020-10-20T05:28:58", "name": "[libcamera-devel,1/8] test: Omit extra semicolons", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1388/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10114/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10114/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7C23BDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 05:29:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4E856052F;\n\tTue, 20 Oct 2020 07:29:20 +0200 (CEST)", "from mail-pf1-x444.google.com (mail-pf1-x444.google.com\n\t[IPv6:2607:f8b0:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90E88613C2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 07:29:18 +0200 (CEST)", "by mail-pf1-x444.google.com with SMTP id w21so514324pfc.7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Oct 2020 22:29:18 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm779043pfd.101.2020.10.19.22.29.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 22:29:16 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"jtL33FWF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=PzH7cQDn+Pcs0mkUbcwhOx4a/+aAn0/6pkWfRiIf6Ro=;\n\tb=jtL33FWFYSKNKQEpwgoQ3zAhCBu8lxmifvf7GDzjPcWt7SQNoh+RDStRVpAPPp3KeH\n\taYW4Jf8RVYBXGs/xh6ZJl2R+pc6smv+isPfWGZq5MRwyzYGR+bBlICEbc5MrMWDlT5MB\n\tAlt4mbySsIbwOJkBRZGpA4L+xwDZxWYaTQ+LE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=PzH7cQDn+Pcs0mkUbcwhOx4a/+aAn0/6pkWfRiIf6Ro=;\n\tb=i43al3T1WZe+/t+7SYDtMTTvlHuxGhQUEo43Pxuf9SMKsN/mdodVOK2W3DotpbBZYo\n\tHVFPsTXlfqOCI1FTid3Ua69Kagvp1V5F4vv7wAz5w6u5Za1e1la6ZWsCBkCe3+QfPdiz\n\tRKzqNKhXOdqlac26kifsoJnmLsbCewF19GQUC8JfZe5hmoN98Jyi4zHlZCUnBi00zIwz\n\tRikeom7YiduZ18vuHC8CMmcJEckKmGjQ0/vGTJlD7NlVL/h89EuFOTOfP6ag0nAeyNvZ\n\toNzTFDuuDy6pWgGUbMZ5kNKOK3vULVshG5Pjc4HFS1BJ9lXoTlwb+Pvq+VijJNLGiysQ\n\tCQ8w==", "X-Gm-Message-State": "AOAM531Zu1E+eeUVQqRB41MUbp7TFnfWJq44ySv6M5iuDLwx/jsGav2l\n\t/ga0pOBp2ovEHAtF9dkKg2u9cYUY+5hH3Q==", "X-Google-Smtp-Source": "ABdhPJxISGWn3ccFBJ0wFTt36pXEujK0yiLph+DqIX/IO1hXlmP34lDaIG3OBnVLFaaVi3GVJqIHRg==", "X-Received": "by 2002:a63:7d44:: with SMTP id m4mr1288436pgn.223.1603171757025;\n\tMon, 19 Oct 2020 22:29:17 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 14:28:59 +0900", "Message-Id": "<20201020052905.89267-3-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog", "In-Reply-To": "<20201020052905.89267-1-hiroh@chromium.org>", "References": "<20201020052905.89267-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/8] v4l2: Omit extra semicolons", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "LOG_DECLARE_CATEGORY macro contains the semicolon. The end\nsemicolon with the macro is unnecessary.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/v4l2/v4l2_camera.cpp | 2 +-\n src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 35d3bed..97825c7 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -14,7 +14,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(V4L2Compat);\n+LOG_DECLARE_CATEGORY(V4L2Compat)\n \n V4L2Camera::V4L2Camera(std::shared_ptr<Camera> camera)\n \t: camera_(camera), isRunning_(false), bufferAllocator_(nullptr),\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 8ff990f..7803d37 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -32,7 +32,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(V4L2Compat);\n+LOG_DECLARE_CATEGORY(V4L2Compat)\n \n V4L2CameraProxy::V4L2CameraProxy(unsigned int index,\n \t\t\t\t std::shared_ptr<Camera> camera)\n", "prefixes": [ "libcamera-devel", "2/8" ] }