Patch Detail
Show a patch.
GET /api/patches/10089/?format=api
{ "id": 10089, "url": "https://patchwork.libcamera.org/api/patches/10089/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10089/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201016105038.158774-1-naush@raspberrypi.com>", "date": "2020-10-16T10:50:38", "name": "[libcamera-devel] include: linux: Update V4L2_CID_USER_BCM2835_ISP_BASE to match upstream tree", "commit_ref": "696aefe0c9ac0e07541a7dbd9334cb282743d29a", "pull_url": null, "state": "accepted", "archived": false, "hash": "a6aec91adfbe396cfe66c329c775c9ecec045dce", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10089/mbox/", "series": [ { "id": 1380, "url": "https://patchwork.libcamera.org/api/series/1380/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1380", "date": "2020-10-16T10:50:38", "name": "[libcamera-devel] include: linux: Update V4L2_CID_USER_BCM2835_ISP_BASE to match upstream tree", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1380/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10089/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10089/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 272F1BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Oct 2020 10:50:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F24761027;\n\tFri, 16 Oct 2020 12:50:45 +0200 (CEST)", "from mail-wr1-x442.google.com (mail-wr1-x442.google.com\n\t[IPv6:2a00:1450:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BE77603C1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Oct 2020 12:50:44 +0200 (CEST)", "by mail-wr1-x442.google.com with SMTP id n15so2237936wrq.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Oct 2020 03:50:44 -0700 (PDT)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\t205sm2397202wme.38.2020.10.16.03.50.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 16 Oct 2020 03:50:42 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"LyLztT0t\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=sXOXiDlEig7g3pAAp9uzg3jydB9dXDu070Qt8XoB8nY=;\n\tb=LyLztT0tkC1bKkeW5lsGT5B+fXYozGeQU9wzpaAL81kaYApFVJvbYm0pUKltaVpD2N\n\t/Q5InU88vsvDzUG7/th+u1haGE50wp/+HciHK6n5dbs2J074YRuiZPubuWKnLaXGfN/T\n\tbksugRS5aMwgi36IrkurdM5Jlj0+joU8DFr0pKmqdveXG4IaEkA73jX+raEEVo8h0V9Y\n\tILfdC2NHoREruQjFKYKZY0xQk+QsYjpe6qeJIru7cGP/FXWgYbUjuPbXbLQp9xU+FzfW\n\t7iGIiLvcKHCWjdcxx//CM+3ehoj6OfQQc3CbTHItYN9dgGksUlo/4JNTfALcU/4BbyNG\n\tX7Xw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=sXOXiDlEig7g3pAAp9uzg3jydB9dXDu070Qt8XoB8nY=;\n\tb=s6vMhqJvVZyO68S3Rpp5cLuYTq3TqN+saX1jFSr9GlpIXfJp5rlLiUgzYYH3aPZgEj\n\tTmkkLogz3vOUGhqOD5beagJ9UOlj+6Xfm51EibJpZn8otAbMYm/h9Fz5hWvn7GMQTkKO\n\t9U9fSYtAaIk7gldPsb5r6sjtO80pWJO3QBdYJQDFpnHUXz2zVJTcrDtGpogr/hmKkyRK\n\thg/LKqqaBNlA4CUdLL9vpPe2ZxIwDkq6A+5g1obNBgYbq1J3Fi+bJ1x6UqKxaGe1bSSM\n\tfUa0n55aj30M/aXQefiqANtHoEv3gdPcTlwtKVl/qks60ECl1Bc1hzr0PD5/JVMaooWm\n\tW6FA==", "X-Gm-Message-State": "AOAM531rFwiKfd+Orjabi5YHVNz7catAet3Oh8eSgyyS/9QyLgd2e5q4\n\tO6cUHCArfRwmxR3af8YCz3R1XavewCaZUA==", "X-Google-Smtp-Source": "ABdhPJw+r9oYSSyHMp0/I5gZ1DsxqAo/Vxsi9zW0x39GpzzYnyblhv44B1JXnqX1PeEyAEeL72qteg==", "X-Received": "by 2002:adf:e289:: with SMTP id v9mr3279669wri.14.1602845443498; \n\tFri, 16 Oct 2020 03:50:43 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 16 Oct 2020 11:50:38 +0100", "Message-Id": "<20201016105038.158774-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] include: linux: Update\n\tV4L2_CID_USER_BCM2835_ISP_BASE to match upstream tree", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The V4L2_CID_USER_BCM2835_ISP_BASE has changed in the downstream\nRaspberry Pi 5.9 kernel to match the upstream defines, see here:\nhttps://github.com/raspberrypi/linux/pull/3897.\n\nNote, that this will cause an ABI breakage with the current downstream\nRaspberry Pi 5.4 kernel until both this change and the following PR has\nbeen merged: https://github.com/raspberrypi/linux/pull/3897\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n include/linux/v4l2-controls.h | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/linux/v4l2-controls.h b/include/linux/v4l2-controls.h\nindex 24eea2b6..39f4bcb5 100644\n--- a/include/linux/v4l2-controls.h\n+++ b/include/linux/v4l2-controls.h\n@@ -192,9 +192,15 @@ enum v4l2_colorfx {\n * We reserve 16 controls for this driver. */\n #define V4L2_CID_USER_IMX_BASE\t\t\t(V4L2_CID_USER_BASE + 0x10b0)\n \n+/*\n+ * The base for the atmel isc driver controls.\n+ * We reserve 32 controls for this driver.\n+ */\n+#define V4L2_CID_USER_ATMEL_ISC_BASE\t\t(V4L2_CID_USER_BASE + 0x10c0)\n+\n /* The base for the bcm2835-isp driver controls.\n * We reserve 16 controls for this driver. */\n-#define V4L2_CID_USER_BCM2835_ISP_BASE\t\t(V4L2_CID_USER_BASE + 0x10c0)\n+#define V4L2_CID_USER_BCM2835_ISP_BASE\t\t(V4L2_CID_USER_BASE + 0x10e0)\n \n /* MPEG-class control IDs */\n /* The MPEG controls are applicable to all codec controls\n", "prefixes": [ "libcamera-devel" ] }