Patch Detail
Show a patch.
GET /api/patches/10085/?format=api
{ "id": 10085, "url": "https://patchwork.libcamera.org/api/patches/10085/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10085/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201016090014.64703-9-kieran.bingham@ideasonboard.com>", "date": "2020-10-16T09:00:11", "name": "[libcamera-devel,v3,08/11] test: v4l2_videodevice: Prevent variable shadowing of format", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2c7de0271f48396814dfb69455c3330d2894d614", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10085/mbox/", "series": [ { "id": 1379, "url": "https://patchwork.libcamera.org/api/series/1379/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1379", "date": "2020-10-16T09:00:03", "name": "Shadowed Variables", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1379/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10085/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10085/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5B83BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Oct 2020 09:00:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B33F461138;\n\tFri, 16 Oct 2020 11:00:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC1E260E36\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Oct 2020 11:00:21 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A300528;\n\tFri, 16 Oct 2020 11:00:21 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JibmpkON\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602838821;\n\tbh=2IB8YBJyKf6x09Crq7uZi+6ocaB1ViPcANsn9MyxMZY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JibmpkONfpAZM4nJo2bDPVJ8DqETKr45s5l41ER5AOSjRFnZWVMIWodG9LZHynFm+\n\tL6jiuyS7pYlNml+jdsGG7sACc8CKuEVkiLiBD6R5GQyRkdJDBuzWrvcpJCiE+iJKXm\n\ts2ckqH3UaOIr7KOG28d4nA8liYJ7ORVAm4jMPyEE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 16 Oct 2020 10:00:11 +0100", "Message-Id": "<20201016090014.64703-9-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201016090014.64703-1-kieran.bingham@ideasonboard.com>", "References": "<20201016090014.64703-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 08/11] test: v4l2_videodevice: Prevent\n\tvariable shadowing of format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename the scoped usage of the variable format while iterating the formats\nas it shadows the outer scoped format which is used for specific testing.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/formats.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\nindex 043732dcaba1..e3283cf92bff 100644\n--- a/test/v4l2_videodevice/formats.cpp\n+++ b/test/v4l2_videodevice/formats.cpp\n@@ -55,10 +55,10 @@ protected:\n \t\t\t{ V4L2_PIX_FMT_Y16_BE, \"Y16 -BE\" }\n \t\t};\n \n-\t\tfor (const auto &format : formats) {\n-\t\t\tif (V4L2PixelFormat(format.first).toString() != format.second) {\n+\t\tfor (const auto &fmt : formats) {\n+\t\t\tif (V4L2PixelFormat(fmt.first).toString() != fmt.second) {\n \t\t\t\tcerr << \"Failed to convert V4L2PixelFormat\"\n-\t\t\t\t << utils::hex(format.first) << \"to string\"\n+\t\t\t\t << utils::hex(fmt.first) << \"to string\"\n \t\t\t\t << endl;\n \t\t\t\treturn TestFail;\n \t\t\t}\n", "prefixes": [ "libcamera-devel", "v3", "08/11" ] }