Patch Detail
Show a patch.
GET /api/patches/10069/?format=api
{ "id": 10069, "url": "https://patchwork.libcamera.org/api/patches/10069/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10069/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201015223750.58563-9-kieran.bingham@ideasonboard.com>", "date": "2020-10-15T22:37:47", "name": "[libcamera-devel,v2,08/11] test: v4l2_videodevice: Prevent variable aliasing of format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2c7de0271f48396814dfb69455c3330d2894d614", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10069/mbox/", "series": [ { "id": 1376, "url": "https://patchwork.libcamera.org/api/series/1376/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1376", "date": "2020-10-15T22:37:39", "name": "Shadowed Variables", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1376/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10069/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10069/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59415BEEE1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 Oct 2020 22:38:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 25F17610B6;\n\tFri, 16 Oct 2020 00:38:03 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F2F960F23\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Oct 2020 00:37:58 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 186CFA42;\n\tFri, 16 Oct 2020 00:37:58 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PykETNe3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602801478;\n\tbh=lEYqiJu9Sp8Dx7iDZU/u0JSJSg82Bc5v9e9XOg6YxVU=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PykETNe3kpp9Di/HRY0l/Xp4xablFROe89qEvuSGtrl/5gO3ub3X6WDA9wdXUdxXN\n\txbREgkwu6L0N+GUmOzyOUdAJmPEvweAjq1PsstcYI2QA9UAwQa4+2k0eRX+BIp6mY0\n\tu3INljgSfHM2SMMYgc6SlzodUvrYKW2GDSdMG0HI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 15 Oct 2020 23:37:47 +0100", "Message-Id": "<20201015223750.58563-9-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201015223750.58563-1-kieran.bingham@ideasonboard.com>", "References": "<20201015223750.58563-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 08/11] test: v4l2_videodevice: Prevent\n\tvariable aliasing of format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename the scoped usage of the variable format while iterating the formats\nas it aliases the outer scoped format which is used for specific testing.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/v4l2_videodevice/formats.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\nindex 043732dcaba1..e3283cf92bff 100644\n--- a/test/v4l2_videodevice/formats.cpp\n+++ b/test/v4l2_videodevice/formats.cpp\n@@ -55,10 +55,10 @@ protected:\n \t\t\t{ V4L2_PIX_FMT_Y16_BE, \"Y16 -BE\" }\n \t\t};\n \n-\t\tfor (const auto &format : formats) {\n-\t\t\tif (V4L2PixelFormat(format.first).toString() != format.second) {\n+\t\tfor (const auto &fmt : formats) {\n+\t\t\tif (V4L2PixelFormat(fmt.first).toString() != fmt.second) {\n \t\t\t\tcerr << \"Failed to convert V4L2PixelFormat\"\n-\t\t\t\t << utils::hex(format.first) << \"to string\"\n+\t\t\t\t << utils::hex(fmt.first) << \"to string\"\n \t\t\t\t << endl;\n \t\t\t\treturn TestFail;\n \t\t\t}\n", "prefixes": [ "libcamera-devel", "v2", "08/11" ] }