Patch Detail
Show a patch.
GET /api/patches/10056/?format=api
{ "id": 10056, "url": "https://patchwork.libcamera.org/api/patches/10056/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10056/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201013151241.3557005-11-kieran.bingham@ideasonboard.com>", "date": "2020-10-13T15:12:41", "name": "[libcamera-devel,10/10] meson: Enable shadowed variable warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "82b3b6f97c0f2c60b9440ae381c7af196b4cce87", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10056/mbox/", "series": [ { "id": 1374, "url": "https://patchwork.libcamera.org/api/series/1374/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1374", "date": "2020-10-13T15:12:31", "name": "Shadowed Variables", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1374/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10056/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10056/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B8E6BEEE1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Oct 2020 15:12:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5FB5C60F23;\n\tTue, 13 Oct 2020 17:12:56 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7E7860E93\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Oct 2020 17:12:49 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 743A4B87;\n\tTue, 13 Oct 2020 17:12:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fL2tRdH9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602601969;\n\tbh=Qb0y0wA4CM9Ublmc76aHkTODF0WRJjLWfxGy9vHQtOg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fL2tRdH9+s63BhTTue6T2nFBN+ZfVUFT/R+uKV3vaUz8X3hsBKRQrBrUJ31aZ66zt\n\tZaMUodq9CD/KVDVKdJ7HIBUC5Zwvgil4H6RAt1V4aHmCOtQOdT0+WrTr9eLRSbyZeZ\n\tWmNMGHd81kqRsfxIzIkrsYGIXmYENwS+WdSN162o=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 13 Oct 2020 16:12:41 +0100", "Message-Id": "<20201013151241.3557005-11-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>", "References": "<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 10/10] meson: Enable shadowed variable\n\twarning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Shadowing variables can lead to unexpected bugs where a code path\nutilises a variable that may not have been intended by the developer,\nleading to hard to find bugs.\n\nEnable warnings for shadowed variables as defined at:\n https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wshadow\n\nAs an effect of utilising -Werror, this will cause variable or type\nshadowing to become a build-time error.\n\nSuggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nThe reference here is that I lost around 2 hours digging into a bug that\nlooked like some other code path was calling a destructor or such, but\nwas because I had accidentally aliased a private member variable in the\nconstructor, so all my initialisation was lost after the constructor\ncompleted.\n\n meson.build | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/meson.build b/meson.build\nindex de15cc16da81..10423f523ca5 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -38,6 +38,7 @@ if cc.has_header_symbol('stdlib.h', 'secure_getenv', prefix : '#define _GNU_SOUR\n endif\n \n common_arguments = [\n+ '-Wshadow',\n '-include', 'config.h',\n ]\n \n", "prefixes": [ "libcamera-devel", "10/10" ] }