Patch Detail
Show a patch.
GET /api/patches/10032/?format=api
{ "id": 10032, "url": "https://patchwork.libcamera.org/api/patches/10032/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10032/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201009122101.73858-6-jacopo@jmondi.org>", "date": "2020-10-09T12:20:56", "name": "[libcamera-devel,05/10] libcamera: ipu3: Register pipeline properties", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "40fd86f914c5d4c1dee9f17ad51b1c019257f337", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10032/mbox/", "series": [ { "id": 1370, "url": "https://patchwork.libcamera.org/api/series/1370/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1370", "date": "2020-10-09T12:20:51", "name": "android: Introduce draft controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1370/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10032/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10032/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A295BEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 9 Oct 2020 12:17:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E3ED609EE;\n\tFri, 9 Oct 2020 14:17:15 +0200 (CEST)", "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9C0860358\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 9 Oct 2020 14:17:11 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 8527DC0004;\n\tFri, 9 Oct 2020 12:17:11 +0000 (UTC)" ], "X-Originating-IP": "93.34.118.233", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 9 Oct 2020 14:20:56 +0200", "Message-Id": "<20201009122101.73858-6-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.28.0", "In-Reply-To": "<20201009122101.73858-1-jacopo@jmondi.org>", "References": "<20201009122101.73858-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 05/10] libcamera: ipu3: Register pipeline\n\tproperties", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Register three pipeline properties in the IPU3 pipeline handler:\n- properties::draft::PipelineMaxDepth\n- properties::draft::AvailableNoiseReductionModes\n- properties::draft::AvailableColorCorrectionAberrationModes\n- properties::draft::AvailableLensShadingMapModes\n\nIPU3 reports a maximum of 3 processing stages: exposure, capture and\nISP processing. It does not support noise reduction, color\naberration and lens shading map modes.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex f5a20d30fd03..f7ade2a6d5f3 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -13,6 +13,7 @@\n \n #include <libcamera/camera.h>\n #include <libcamera/formats.h>\n+#include <libcamera/property_ids.h>\n #include <libcamera/request.h>\n #include <libcamera/stream.h>\n \n@@ -770,6 +771,13 @@ int PipelineHandlerIPU3::registerCameras()\n \n \t\t/* Initialize the camera properties. */\n \t\tdata->properties_ = cio2->sensor()->properties();\n+\t\tdata->properties_.set(properties::draft::PipelineMaxDepth, 3);\n+\t\tdata->properties_.set(properties::draft::AvailableNoiseReductionModes,\n+\t\t\t\t { static_cast<int32_t>(properties::draft::NoiseReductionModeOff) });\n+\t\tdata->properties_.set(properties::draft::AvailableColorCorrectionAberrationModes,\n+\t\t\t\t { static_cast<int32_t>(properties::draft::ColorCorrectionAberrationOff) });\n+\t\tdata->properties_.set(properties::draft::AvailableLensShadingMapModes,\n+\t\t\t\t { static_cast<int32_t>(properties::draft::LensShadingMapModeOff) });\n \n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n", "prefixes": [ "libcamera-devel", "05/10" ] }