Patch Detail
Show a patch.
GET /api/patches/10009/?format=api
{ "id": 10009, "url": "https://patchwork.libcamera.org/api/patches/10009/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10009/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201007110743.55561-4-tomi.valkeinen@iki.fi>", "date": "2020-10-07T11:07:42", "name": "[libcamera-devel,3/4] ipa: raspberrypi: fix access to uninitialized variables", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "17aab4484b61bfd18503d95eda14b2bbdd76d50d", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10009/mbox/", "series": [ { "id": 1362, "url": "https://patchwork.libcamera.org/api/series/1362/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1362", "date": "2020-10-07T11:07:39", "name": "ipa: raspberrypi: fix uninit variables", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1362/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10009/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10009/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B75EBEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Oct 2020 11:08:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1589E60589;\n\tWed, 7 Oct 2020 13:08:10 +0200 (CEST)", "from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD2BE60589\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Oct 2020 13:08:07 +0200 (CEST)", "by mail-lf1-x144.google.com with SMTP id l2so1830790lfk.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Oct 2020 04:08:07 -0700 (PDT)", "from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tx14sm287445lfc.93.2020.10.07.04.08.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 04:08:06 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"UkU7GzzR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=OySjD9dnYgzNLor4izMnFRzCScZeaXOazSafFJr+/L0=;\n\tb=UkU7GzzRwnkDTsbAtI90N/xVtwVY22eEnF2jOvgGgder98edWLcr3GM7Y7uWdut+HM\n\tT6Ga93/64v/BqUUimI+t1heDgIW2dMGscwtiovaM5nvCc+WehxjMKs2K5T8WN5X5Xp+F\n\tO6mWR1E5QuIBu/d7tIReDivWUtNxFAqPtRJD1eEdrPXKA3JIK7AebFSzvGbx2nJ7OofL\n\tMGsSLqnb9SrsFPI/rJV94Qog+T/ZJw3Ad3IOFQCTYFO32r0qbxJ5RgfCgBNuaOM/qCPF\n\t1j5ftD3nePdAWGBtWSuWDU4LFaf4LxY1jvJV9KOaDVxEiCjBAhB1mRg2khKuyR/9gWrU\n\tTL3A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=OySjD9dnYgzNLor4izMnFRzCScZeaXOazSafFJr+/L0=;\n\tb=mVeECvlffp7wZG+QlUY27twkrursVdzNKN75UlQyWgMqRD1K66hCppIRbb3CBy26EQ\n\t1U4hkdfX5LRmypBfloroKBnaqXP+1G29roQIOUwhPre+mGQOuvwjyml5LuJiCBtbpN5r\n\tBH1EeII5ZX2zZmI4mhQ0SHaPzzk6kd1qv9/vhHW41ORw5tQhk8lxGZCVko6wUPuT+0cm\n\tAl6JjUF1GAPQ0LpXbaAhtHWbVsMw8VHEAyllJ/9tPEw+LpdANwrqSYQnRIiFaGhnFMPP\n\tATGj1aBEaP1VCm5v2bQJ/x4LQX7gcfXDESFRVdCwYn6YAaz1pi4uzr2GjQRoyq4bgeP/\n\t840A==", "X-Gm-Message-State": "AOAM532xwQQq37jw2t+KI+t3L4XqN3ieBUPQQqNwmD7so6LBjrdYzSbu\n\tie6PaQMKcROa5WSKLN/qyQAVfNnLJzx9lA==", "X-Google-Smtp-Source": "ABdhPJxUcsU4PKZ2QaCgvxm4cHEFIvdtQhne9ZBFhcr5fdf/VxvLkWL1A01bs6gSgK/4ihNHfSNmMw==", "X-Received": "by 2002:a19:8286:: with SMTP id\n\te128mr729245lfd.307.1602068887019; \n\tWed, 07 Oct 2020 04:08:07 -0700 (PDT)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>", "Date": "Wed, 7 Oct 2020 14:07:42 +0300", "Message-Id": "<20201007110743.55561-4-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007110743.55561-1-tomi.valkeinen@iki.fi>", "References": "<20201007110743.55561-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/4] ipa: raspberrypi: fix access to\n\tuninitialized variables", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set span_r and span_b to -1 so that when they are passed to Pwl::Eval()\nthey won't cause access to uninitialized memory.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\nindex a5536e4..469d0e5 100644\n--- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n@@ -430,7 +430,7 @@ double Awb::coarseSearch(Pwl const &prior)\n \n void Awb::fineSearch(double &t, double &r, double &b, Pwl const &prior)\n {\n-\tint span_r, span_b;\n+\tint span_r = -1, span_b = -1;\n \tconfig_.ct_r.Eval(t, &span_r);\n \tconfig_.ct_b.Eval(t, &span_b);\n \tdouble step = t / 10 * config_.coarse_step * 0.1;\n", "prefixes": [ "libcamera-devel", "3/4" ] }