Cover Letter Detail
Show a cover letter.
GET /api/covers/9898/?format=api
{ "id": 9898, "url": "https://patchwork.libcamera.org/api/covers/9898/?format=api", "web_url": "https://patchwork.libcamera.org/cover/9898/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201002093309.109180-1-naush@raspberrypi.com>", "date": "2020-10-02T09:33:04", "name": "[libcamera-devel,0/5] RFQ: Pass controls on camera:start()", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/9898/mbox/", "series": [ { "id": 1345, "url": "https://patchwork.libcamera.org/api/series/1345/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1345", "date": "2020-10-02T09:33:04", "name": "RFQ: Pass controls on camera:start()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1345/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/9898/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A76BC3B5B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 2 Oct 2020 09:33:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E56363AF7;\n\tFri, 2 Oct 2020 11:33:15 +0200 (CEST)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4C3D60394\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 2 Oct 2020 11:33:13 +0200 (CEST)", "by mail-wm1-x332.google.com with SMTP id w2so947968wmi.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 02 Oct 2020 02:33:13 -0700 (PDT)", "from naushir-VirtualBox.pitowers.org\n\t([2a00:1098:3142:14:a00:27ff:fe4d:f6a2])\n\tby smtp.gmail.com with ESMTPSA id\n\tt203sm1101145wmg.43.2020.10.02.02.33.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 02 Oct 2020 02:33:12 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cURLDfZT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ICiUxvshAnfj1HO7dRQlVd3uXCE26lhA/MqB89nwzM8=;\n\tb=cURLDfZTyYxMP/bD/gYtGxITtJiYCb1hGDVfhGkEyF5QVWbc1Lb4ggE5c4JYS5VmCW\n\tAd9LdgSbKyVpOphrTF0KA0d32MxVIoq76FGeOedju0E+PI3fBphiPglYp+CWihxjJj8d\n\t1j+ByO2YbrvEXj/ZaWfb8Vz8Sowd1AXxODFmA6gDzt2OfnZuBf9ZQY/k4iae0pSChwht\n\tJgjwjAvoq11gSbPe9ws8d1YDkde2okTY01Wuib2I9nFPKyQkq53UUbNyn7lAMkARbo+l\n\tLbCg51yiz8aiaYW72HCQfUwH6N2s1eNryRJJ1Ajeca2ajOeTxPbVXbnSMhxMzwNAVHsm\n\tQIVg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ICiUxvshAnfj1HO7dRQlVd3uXCE26lhA/MqB89nwzM8=;\n\tb=hzOr6a5fuTipQnF2F6fBG40WNGLduXjqMJr7Tuev8NAB/hTw25BMaesq7VdnEMiy9C\n\tzQ2clm2+UKfpVFkP1N9CjoGyr7MZ7M7t5RMNOtxbXYHcoKngqTsFzi4VahbMZ7Mjq68O\n\tjSt3hkJFSlSGHzQ2LAqwxV8PkutH5j3/9iy5D2UC0uvMckCbG00XXh27DN01gJ2vrwTh\n\tOGnKxSUX+xKz5LuXpaLgLhFinTAd0Iyn1YKW/DrHyL4BlrwO8i6Yl5YmNH+rVsdzzqEI\n\tlZuIDksrEuTwHgDSNcENCR5HzBIXglL0FVlw5lYHO/gfdFKeIWtE+LTtvW5zvcnvqhJV\n\tG5nQ==", "X-Gm-Message-State": "AOAM5311eAdNc9oLylKQlEQlt0WOTCb9YFUPzNQaaqtp+wqa8wwM4LI1\n\tfocgwKNCOUUdO/hNOA4LUO8iqgDceLXHmg==", "X-Google-Smtp-Source": "ABdhPJy95UxQdUMUoyzlMOufT3OMNK2I2vnRrl3LAt1iNAERfwYWW57LSIhfvZiSFBjMgvTbISvDhA==", "X-Received": "by 2002:a1c:7f0f:: with SMTP id a15mr1783751wmd.97.1601631193051;\n\tFri, 02 Oct 2020 02:33:13 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 2 Oct 2020 10:33:04 +0100", "Message-Id": "<20201002093309.109180-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 0/5] RFQ: Pass controls on camera:start()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi all,\n\nI would like to resurrect the topic of passing controls to the pipeline handlers and ipas on startup. We talked about this some time back, and unfortunately it drifted off my radar.\n\nAttached is some work I've done to resurrect this discussion. I have added the ability for an application to pass in controls through the camera::start() public API. This is similar to how controls are passed in though Requests, the only difference being that if we do pass it in the latter, we could incur multiple frames of delay before they are applied. This would be unsuitable for a lot of users I feel. This change gives us a huge jump in getting to feature parity with the existing Raspberry Pi camera stack.\n\nThere are a couple of things to address in these changes:\n- I have modified the camera::start() public API with the following signature: int start(ControlList *controls = nullptr). I know the convention is to use a reference here, but I wanted to keep API backward compatible, and a pointer can have a default value nullptr. I could also overload start and keep the old and new signature perhaps, but not sure on the policy for public methods having multiple signatures.\n\n- the IPA context wrapper code needs the ability to serialise IPAOperationData structures. This is needed for this code, as well as for configure() as part of an earlier set of changes.\n\nPlease note, this patch set is for discussion to start with and not ready to submit as-is. Happy to hear your thoughts.\n\nRegards,\nNaush\n\nNaushir Patuck (5):\n pipeline: raspberrypi: Sensor flips should be applied unconditionally\n libcamera: pipeline: Pass libcamera controls into\n pipeline_handler::start()\n libcamera: ipa: Pass a set of controls and return results from\n ipa::start()\n pipeline: ipa: raspberrypi: Pass controls to IPA on start\n DNI: qcam: Simple test to pass controls on camera::start()\n\n Documentation/guides/pipeline-handler.rst | 4 +-\n include/libcamera/camera.h | 2 +-\n .../libcamera/internal/ipa_context_wrapper.h | 3 +-\n include/libcamera/internal/pipeline_handler.h | 2 +-\n include/libcamera/ipa/ipa_interface.h | 3 +-\n include/libcamera/ipa/raspberrypi.h | 1 +\n src/ipa/libipa/ipa_interface_wrapper.cpp | 4 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 50 ++++++++++++-------\n src/ipa/rkisp1/rkisp1.cpp | 3 +-\n src/ipa/vimc/vimc.cpp | 6 ++-\n src/libcamera/camera.cpp | 11 ++--\n src/libcamera/ipa_context_wrapper.cpp | 6 ++-\n src/libcamera/ipa_interface.cpp | 7 +++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 46 ++++++++++-------\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++--\n src/libcamera/pipeline/simple/simple.cpp | 4 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 7 +--\n src/libcamera/pipeline_handler.cpp | 1 +\n src/libcamera/proxy/ipa_proxy_linux.cpp | 3 +-\n src/libcamera/proxy/ipa_proxy_thread.cpp | 13 +++--\n src/qcam/main_window.cpp | 7 ++-\n test/ipa/ipa_interface_test.cpp | 3 +-\n test/ipa/ipa_wrappers_test.cpp | 5 +-\n 25 files changed, 134 insertions(+), 74 deletions(-)" }