Cover Letter Detail
Show a cover letter.
GET /api/covers/9348/?format=api
{ "id": 9348, "url": "https://patchwork.libcamera.org/api/covers/9348/?format=api", "web_url": "https://patchwork.libcamera.org/cover/9348/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200821155641.11839-1-david.plowman@raspberrypi.com>", "date": "2020-08-21T15:56:36", "name": "[libcamera-devel,v3,0/5] 2D transforms", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/9348/mbox/", "series": [ { "id": 1228, "url": "https://patchwork.libcamera.org/api/series/1228/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1228", "date": "2020-08-21T15:56:36", "name": "2D transforms", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1228/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/9348/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81FE6BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 21 Aug 2020 15:57:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 988FD620D6;\n\tFri, 21 Aug 2020 17:57:04 +0200 (CEST)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC28360383\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Aug 2020 17:57:02 +0200 (CEST)", "by mail-wm1-x332.google.com with SMTP id p14so2401230wmg.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 21 Aug 2020 08:57:02 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl11sm5627385wme.11.2020.08.21.08.57.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 21 Aug 2020 08:57:01 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"o4V+HaR4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YglxDJdogXz2ctaY3bq0Lb1aXaeHP2cNz/4ZKmf+hbA=;\n\tb=o4V+HaR4MdxxvxrFxu9ALkVpbFTBrrMqtZczLVjTmO6smv9gFLksCxER0LMFjyznzP\n\tiRnqlOgYPAEJFKDiyGPxIuwE7AU13dC09PeRqNv6dz+ANBeW/MXDq50NzQjdUpKMlHGS\n\tuBdjZzdhS5uHfocq/ht7vs2Ne5d62+gUy9pQmFSBJtVsp8+GNdHznhDNfIKo8xwe68fj\n\tQAQKqspm+87SGEaEYl3j8XE9VK6M8mfg5Nz30ojw6axtODjxDgOvOvjXDTA27hg4fQp0\n\tySyQzlCTyOarOoWxVjVeoA0SIdfgeetuAVlgbfPqn4zhrHFmzQ/Ctb0d3NJf5XtZTMgO\n\txm4g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=YglxDJdogXz2ctaY3bq0Lb1aXaeHP2cNz/4ZKmf+hbA=;\n\tb=TJdY9TYdQbOHK7bGLdC9nM7FjDRKuk8MBVaKFKVcfqX7XzpsKbtID2w9Auu8eXxcUY\n\t14vC7Qq6JkSduCG/zdYStC/aWX0Psk47B+QmTsYUitLxHdFP1JPVjajdZOrcTA/HVTVw\n\tgo720gtrbapYgBS2KV/Zz9Q8uklb7hCrS2ZceN+IZdIQw+7pZonFgBLXcS9JtZy0IbqB\n\truVdOdqpPT7DajxzGnV7UcIhkN7N5zf7K9ZfBtoTLyxKSpAMsPRmFzUb9FuQn5UFE/EA\n\tP3Cq/UqHmEk1r/CLixC0/7kp/liWa54xsoZ+Qn/pX1F20toN32zbS47eO6N37vORDk6A\n\tvR7g==", "X-Gm-Message-State": "AOAM530oilKIJC3c1JFCL3zpweuZ3eEcwC6liRDjXx1eMFhct88spJEF\n\te9RT6xvIctMRwhbSwlQ/f5wHQfIK/YXnJA==", "X-Google-Smtp-Source": "ABdhPJy33cvAtz/3lTJm7nMVaFkuDS8DEEtvh70Dvzm+2VkJZjpeJQRJxZ0mYiGx08WY1Z5MeDXs1A==", "X-Received": "by 2002:a1c:4944:: with SMTP id\n\tw65mr4314466wma.169.1598025421964; \n\tFri, 21 Aug 2020 08:57:01 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 21 Aug 2020 16:56:36 +0100", "Message-Id": "<20200821155641.11839-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 0/5] 2D transforms", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi everyone\n\nHere's the latest version of the implementation of 2D transforms,\ntaking feedback on board and adding the missing documentation. It's\nset out in the same 5 commits as before, and the functionality is\nbasically identical, just a couple of changes to point out.\n\nFirstly, in the third patch there was a question about what to do if\nthe camera is listed as having a rotation that's not 0 or 180 degrees.\n\nIf a 90/270 rotation is found, the code will expect a user transform\nto be specified that \"undoes\" the transposition. If the combined\nrotation and user transform _doesn't_ undo the transposition, then the\nuser transform will be \"adjusted\" so that it does.\n\nIf there's a non-90-degree rotation (it seems to be possible, if a bit\nhard to imagine), I wasn't sure what to do about that. Failing\nwould seem unhelpful as there's nothing the application can do to make\nit work. There's no \"adjustment\" we can perform to make it valid. So\nI've ended up printing a warning and ignoring the rotation. Under the\ncircumstances maybe that's the most reasonable thing to do?\n\nFinally, the documentation ran into a Doxygen problem with\nstrongly-typed enums. The table of enumeration values simply vanishes,\nso instead I've just included that as text in the description. It's\neasy to change if the Doxygen situation improves.\n\nI think that's everything! Improvements - especially to the new\ndocumentation - welcome as always.\n\nThanks and best regards\nDavid\n\nDavid Plowman (5):\n libcamera: Add Transform enum to represet 2D plane transforms.\n libcamera: Add user Transform to CameraConfiguration\n libcamera: raspberrypi: Set camera flips correctly from user transform\n libcamera: raspberrypi: Plumb user transform through to IPA\n libcamera: ipa: raspberrypi: ALSC: Handle user transform\n\n include/libcamera/camera.h | 3 +\n include/libcamera/meson.build | 1 +\n include/libcamera/transform.h | 73 +++++\n src/ipa/raspberrypi/controller/camera_mode.h | 4 +\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 13 +-\n src/ipa/raspberrypi/raspberrypi.cpp | 48 +--\n src/libcamera/camera.cpp | 16 +-\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 5 +\n .../pipeline/raspberrypi/raspberrypi.cpp | 40 ++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n src/libcamera/pipeline/simple/simple.cpp | 5 +\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +\n src/libcamera/pipeline/vimc/vimc.cpp | 5 +\n src/libcamera/transform.cpp | 301 ++++++++++++++++++\n 15 files changed, 499 insertions(+), 26 deletions(-)\n create mode 100644 include/libcamera/transform.h\n create mode 100644 src/libcamera/transform.cpp" }