Cover Letter Detail
Show a cover letter.
GET /api/covers/795/?format=api
{ "id": 795, "url": "https://patchwork.libcamera.org/api/covers/795/?format=api", "web_url": "https://patchwork.libcamera.org/cover/795/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190326083902.26121-1-jacopo@jmondi.org>", "date": "2019-03-26T08:38:43", "name": "[libcamera-devel,v5,00/19] libcamera: ipu3: Add ImgU support", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/795/mbox/", "series": [ { "id": 219, "url": "https://patchwork.libcamera.org/api/series/219/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=219", "date": "2019-03-26T08:38:43", "name": "libcamera: ipu3: Add ImgU support", "version": 5, "mbox": "https://patchwork.libcamera.org/series/219/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/795/comments/", "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2FAAA610D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Mar 2019 09:38:29 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 9BA8F240005;\n\tTue, 26 Mar 2019 08:38:28 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Mar 2019 09:38:43 +0100", "Message-Id": "<20190326083902.26121-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 00/19] libcamera: ipu3: Add ImgU support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Mar 2019 08:38:29 -0000" }, "content": "Hello,\n patch count reduced a bit, from the 31 of v4+multiple-stream to this\n19 for v5 of ImgU support series only.\n\nQuite some changes compared to v4 mostly suggested by Laurent during review:\n- Made CIO2Device and ImgUDevice classes and moved most of the code in class\n methods. The pipeline handler code now mostly interacts with a 'cio2' and\n an 'imgu' objects, and call methods on them to perform format configuration,\n memory allocation and start/stop of video devices.\n- Removed buffer queueing from viewfinder and stat: the nodes need to be linked\n and configured but buffers might not be queued there.\n- Profiled buffer sharing between CIO2 and ImgU input: requests for output\n buffers can be queued asynchronously without stalling the pipeline\n- Cache camera sizes and format at camera creation time\n- Add a few patches for geometry and v4l2_subdevice, to generalize helpers\n methods previously implemented for IPU3 pipeline only\n\nTwo points remain to be clarified:\n- It is not yet clear to me how to calculate the sizes in the capture pipeline\n based on the requested output resolutions. Upstream pointed us to an XML\n file with all sizes hardcoded, which is an unacceptable solution as sizes\n have to be calculated dynamically based on requested stream configurations.\n -> upstream will provide a programmatic way to do so\n- When operating on one of the two ImgU pipes, if the other one is still linked\n from a previous capture operation, the whole ImgU unit stall.\n Please see 19/19 I try to explain the issue in a lengthy comment.\n -> to be notified to upstream\n\nI will send multiple stream support separately, to ease integration of ImgU\nsupport first.\n\nThanks\n j\n\nJacopo Mondi (19):\n libcamera: formats: Add toString() methods\n libcamera: formats: Define FormatEnum type\n libcamera: geometry: Add 0-initialized SizeRange constructor\n libcamera: geometry: Add toString to Rectangle\n libcamera: v4l2_subdevice: Rename deviceName() method\n libcamera: v4l2_device: Create device from entity name\n libcamera: v4l2_subdevice: Create device from entity name\n libcamera: ipu3: Cache the camera sizes\n libcamera: ipu3: Set stream configuration from sensor\n libcamera: ipu3: Create CIO2Device class\n libcamera: ipu3: Create ImgUDevice class\n libcamera: ipu3: Apply image format to the pipeline\n libcamera: ipu3: Implement memory handling\n libcamera: ipu3: Implement camera start/stop\n libcamera: ipu3: Queue requests to ImgU\n libcamera: ipu3: Connect CIO2 and ImgU bufferReady signals\n libcamera: ipu3: Use NV12 as default image format\n libcamera: ipu3: Limit resolution to 2560x1920\n libcamera: ipu3: Enable ImgU media links\n\n src/libcamera/formats.cpp | 27 +\n src/libcamera/geometry.cpp | 27 +-\n src/libcamera/include/formats.h | 22 +\n src/libcamera/include/geometry.h | 13 +-\n src/libcamera/include/v4l2_device.h | 6 +\n src/libcamera/include/v4l2_subdevice.h | 15 +-\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1183 ++++++++++++++++++++----\n src/libcamera/v4l2_device.cpp | 40 +\n src/libcamera/v4l2_subdevice.cpp | 49 +-\n test/v4l2_subdevice/list_formats.cpp | 6 +-\n 11 files changed, 1203 insertions(+), 186 deletions(-)\n create mode 100644 src/libcamera/formats.cpp\n create mode 100644 src/libcamera/include/formats.h\n\n--\n2.21.0" }