Cover Letter Detail
Show a cover letter.
GET /api/covers/26705/?format=api
{ "id": 26705, "url": "https://patchwork.libcamera.org/api/covers/26705/?format=api", "web_url": "https://patchwork.libcamera.org/cover/26705/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<177827984964.786021.2242634090011461397@jetm.me>", "date": "2026-05-08T21:35:24", "name": "[v2,0/2] libcamera: Vector right-shift operators and SwStatsCpu use site", "submitter": { "id": 261, "url": "https://patchwork.libcamera.org/api/people/261/?format=api", "name": "Javier Tia", "email": "floss@jetm.me" }, "mbox": "https://patchwork.libcamera.org/cover/26705/mbox/", "series": [ { "id": 5929, "url": "https://patchwork.libcamera.org/api/series/5929/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5929", "date": "2026-05-08T21:35:24", "name": "libcamera: Vector right-shift operators and SwStatsCpu use site", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5929/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/26705/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B5A03BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 8 May 2026 22:37:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6B3EA63026;\n\tSat, 9 May 2026 00:37:36 +0200 (CEST)", "from fhigh-a5-smtp.messagingengine.com\n\t(fhigh-a5-smtp.messagingengine.com [103.168.172.156])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57FB562010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 9 May 2026 00:37:33 +0200 (CEST)", "from phl-compute-02.internal (phl-compute-02.internal\n\t[10.202.2.42])\n\tby mailfhigh.phl.internal (Postfix) with ESMTP id 758551400106;\n\tFri, 8 May 2026 18:37:32 -0400 (EDT)", "from phl-imap-07 ([10.202.2.97])\n\tby phl-compute-02.internal (MEProxy); Fri, 08 May 2026 18:37:32 -0400", "by mailuser.phl.internal (Postfix, from userid 501)\n\tid 29F761EA006C; Fri, 8 May 2026 18:37:32 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=jetm.me header.i=@jetm.me header.b=\"FUyVLTJO\";\n\tdkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"ATvRgRdu\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=jetm.me; h=cc:cc\n\t:content-transfer-encoding:content-type:content-type:date:date\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm2; t=1778279852;\n\tx=1778366252; bh=pWwlo6720Nqw9qAZolKlDOrT9crU4MKLBJSHwaKqF24=; b=\n\tFUyVLTJONycGRRVn8RFHJY6XUgoLgIlAuYm12RHSUD8Cjfssc3OYc505KTsn4Qsg\n\tkDhv2PDd6oXbO8cxQ6mpRRvGbJfYmR/EPi2wuSPuTESIv72he/OHt/PK1QBVrPjN\n\toFP1zAW6ZOb6Aek+et4UzM8pz91KtmHr6vWFWRIlWspMreWu1pNYbtV03OYEXcOT\n\t8rwuV/vQm+VsSQnSyKdgvgM26L8Qdxd6DFUXgZ4dRxrgwlaDWbIE7TD1smGNh8IY\n\tX+PlycwMGJqr2nO9AJUGDF7jiWTyfeAN4QP0inT4CKRGwzNEMsu3y+HTFWgWB+2k\n\tpLn01aItuhqJBkBgEllKvQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1778279852; x=\n\t1778366252; bh=pWwlo6720Nqw9qAZolKlDOrT9crU4MKLBJSHwaKqF24=; b=A\n\tTvRgRduGQCZoYH213d2VwKMQW9p+wUNNpuYyw9YUjjlr4HlxRSTNZo/shMpnLXGn\n\tCR619wZBN6xGs11+Zy5Zf5S+ktNr4FqjqR2zKkakQFZ5bPyURzYFhU/AfVcrQ1FR\n\tMkdLkiHoQGKBChKQoR+EZP8ASryWDH4vnoNcTTU2NVqzQcN4AQlDGNOe2v2jJn/B\n\t6qAtIpHPZj3xGPoL+BeT7GP2xSWfMaQZPU5e0dMZPuR/bg221xIjTWndzy9KulhD\n\tjS1KSdse21bh8SlgZGjxAxccotZUXVHiHl8Jdf6qyUWP9OTwj9e7+aRbycX+tVBT\n\t7xpSwFfb4RZYgYkmPMqKA==" ], "X-ME-Sender": "<xms:rGX-aSAFUMNIz2H0eu413EFV_MCYgAAvvmo3G7MTPH0Btjj3l-k4mg>\n\t<xme:rGX-aXXCu2JKlhqdyLYHVvaBnDpDKQy1SrjxW4GLGfJ7ZIkRaXVJUK9l0-YGOMQjG\n\tuVD3gADasuU9CUBK_8nzgR40qK3ClWPHlerjAgdL978zhyXQkSVo1E>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgdduudduheejucetufdoteggodetrf\n\tdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu\n\trghilhhouhhtmecufedttdenucenucfjughrpefotggggffhvfffufevjghfkfesthekre\n\tdtredtjeenucfhrhhomheplfgrvhhivghrucfvihgruceofhhlohhsshesjhgvthhmrdhm\n\tvgeqnecuggftrfgrthhtvghrnhepgeehvdegudffffdtgfdtudeludefveeihfejfeelff\n\tegtdekueefgeejgeekgedunecuffhomhgrihhnpehlihgstggrmhgvrhgrrdhorhhgnecu\n\tvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepfhhlohhssh\n\tesjhgvthhmrdhmvgdpnhgspghrtghpthhtohepjedpmhhouggvpehsmhhtphhouhhtpdhr\n\ttghpthhtoheprhhosggvrhhtrdhmrgguvghrsegtohhllhgrsghorhgrrdgtohhmpdhrtg\n\thpthhtohepsggrrhhnrggsrghsrdhpohgtiigvsehiuggvrghsohhnsghorghrugdrtgho\n\tmhdprhgtphhtthhopehkihgvrhgrnhdrsghinhhghhgrmhesihguvggrshhonhgsohgrrh\n\tgurdgtohhmpdhrtghpthhtoheplhgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghs\n\tohhnsghorghrugdrtghomhdprhgtphhtthhopehflhhoshhssehjvghtmhdrmhgvpdhrtg\n\thpthhtoheplhhisggtrghmvghrrgdquggvvhgvlheslhhishhtshdrlhhisggtrghmvghr\n\trgdrohhrghdprhgtphhtthhopehmiigrmhgriigrlhesrhgvughhrghtrdgtohhm", "X-ME-Proxy": "<xmx:rGX-aa6q1-50qZimQ_jcy0-8mfvDrHieVJPl242keJItg9ty62T25A>\n\t<xmx:rGX-aUluQ0AszXYrSIS9xU37HCra-16BMTJuRzJHKfqKBl-0OhWTRg>\n\t<xmx:rGX-aXpfzDIBRryU8Un918Fqw0BPO53TrR-lWFBaYi10EC7WWY0THQ>\n\t<xmx:rGX-abuikWFhr0enZi3QtsjNfz_7q0KYPqhsd_Cd6vyjffjOZ_alxA>\n\t<xmx:rGX-aTbfZDRfT7pJhflm_eYSbpOB56jl7qwETc2cbgor-VFLNtkHal98>", "Feedback-ID": "i9dde48b3:Fastmail", "X-Mailer": "MessagingEngine.com Webmail Interface", "Content-Type": "text/plain; charset=\"utf-8\"", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "From": "Javier Tia <floss@jetm.me>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 08 May 2026 15:35:24 -0600", "Subject": "[PATCH v2 0/2] libcamera: Vector right-shift operators and\n\tSwStatsCpu use site", "Cc": "mzamazal@redhat.com, kieran.bingham@ideasonboard.com,\n\tlaurent.pinchart@ideasonboard.com, barnabas.pocze@ideasonboard.com,\n\trobert.mader@collabora.com", "In-Reply-To": "<177826797798.345005.11618565886801750854@jetm.me>", "References": "<177826797798.345005.11618565886801750854@jetm.me>", "Message-ID": "<177827984964.786021.2242634090011461397@jetm.me>", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Small follow-up suggested by Barnabás and Laurent during review of the\nsumShift_ cleanup in the OV2740 v2 series:\n\n https://patchwork.libcamera.org/project/libcamera/list/?series=5926\n\nPatch 1/2 adds operator>> and operator>>= to the Vector class.\nPatch 2/2 uses the new operator in SwStatsCpu::finishFrame() to\ncollapse the three per-component right-shifts on RGB<uint64_t>::sum_\ninto a single sum_ >>= sumShift_ statement.\n\nDepends on the v2 OV2740 series above (specifically v2 1/3, which\nremoves the if (sumShift_) guard around the three right-shifts that\n2/2 here further simplifies). It does not apply on top of master\nwithout v2.\n\nChanges since v1:\n- Patch 1/2: rewrote operator>> and operator>>= to use the existing\n apply() helper for consistency with the other Vector operators;\n templated apply() on the scalar type to accept unsigned int. Added\n Doxygen \\fn blocks for both operators in src/libcamera/vector.cpp.\n Verified with -Ddocumentation=enabled -Ddoc_werror=true.\n- Patch 1/2: added static_assert(std::is_integral_v<T>) in both shift\n operators to enforce integer element type, per Laurent's follow-up\n review.\n- Patch 2/2: picked up Laurent's Reviewed-by.\n\nLink to v1: https://patchwork.libcamera.org/project/libcamera/list/?series=5927\n\nJavier Tia (2):\n libcamera: libipa: Add right-shift operators to Vector\n libcamera: software_isp: Use Vector operator>>= in finishFrame\n\n include/libcamera/internal/vector.h | 22 ++++++++++++++++++----\n src/libcamera/software_isp/swstats_cpu.cpp | 4 +---\n src/libcamera/vector.cpp | 14 ++++++++++++++\n 3 files changed, 33 insertions(+), 7 deletions(-)" }