Cover Letter Detail
Show a cover letter.
GET /api/covers/26232/?format=api
{ "id": 26232, "url": "https://patchwork.libcamera.org/api/covers/26232/?format=api", "web_url": "https://patchwork.libcamera.org/cover/26232/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260224193745.106186-1-johannes.goede@oss.qualcomm.com>", "date": "2026-02-24T19:37:41", "name": "[v3,0/4] software_isp: debayer_cpu: Add multi-threading support", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "mbox": "https://patchwork.libcamera.org/cover/26232/mbox/", "series": [ { "id": 5811, "url": "https://patchwork.libcamera.org/api/series/5811/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5811", "date": "2026-02-24T19:37:41", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5811/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/26232/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A231BC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Feb 2026 19:37:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3731622A4;\n\tTue, 24 Feb 2026 20:37:51 +0100 (CET)", "from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n\t[205.220.180.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D92AC62080\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 20:37:49 +0100 (CET)", "from pps.filterd (m0279872.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t61OINYu22560032 for <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 19:37:48 GMT", "from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n\t[209.85.222.200])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ch4e3auhd-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 19:37:48 +0000 (GMT)", "by mail-qk1-f200.google.com with SMTP id\n\taf79cd13be357-8cb3ad1b81aso7729226685a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Feb 2026 11:37:48 -0800 (PST)", "from shalem\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\ta640c23a62f3a-b9084e8cb3fsm458232866b.48.2026.02.24.11.37.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Feb 2026 11:37:46 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"jqKu1BjO\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"WlXWEgf5\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=64rlEuOYdbviyNQw0A2s83CgL5GfBgbapEf\n\tiAU7QnnM=; b=jqKu1BjOygCEVmjEZ8mVyIhlcK8isi3wypx2FPVelZQSXsrN3hr\n\tVUh30kGoJ0Yb/nyhPZPRs1WeqcHomyRUHvovcBgrOd60EcFhA7e1VJjlKsobckDh\n\tnpMgZgm1YmBsUO9YA1G4M0l7o+6bML4Yu9lIhX7n3DsnOV2ET0hMuZXftvdusmsV\n\tXACPX/I4W5iIfkufba0gJM+syQgRDsH90RXHP403JT23KxvynUvouaiaZDeiUNOY\n\tf62LfwK79SPi7B+WqVsYGAFagMeXz6sst6Sdzboyy52sSBayogKuO/Ycn/Hwp5ub\n\t/GFmVQnhfrVAB39O9g4C5DWlPRkopGVkIqg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1771961868; x=1772566668;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=64rlEuOYdbviyNQw0A2s83CgL5GfBgbapEfiAU7QnnM=;\n\tb=WlXWEgf5oVd9A9Nsj1pIKztT1AXeHx+Thfia3tsNvmCHX7u0mSKhkaBgH8Vnq0+AJX\n\tHkEG5QgU8SdhrNSea2eJwj3zDiwZ+3qXuRyIRfR/fxHq0HjcpNo6a5J7ikugUHF8fNqJ\n\twySycJSTETm6Mqs9/9p+prZPJcBJu81LP/6PJyZ0I2FV9P3fYXiRrRchUompkHypqP6A\n\tWukq8pdddjfbbPgEKWWEZb0h0CBGhwZ0vWqJlth6Wgu80aNTjI5K0940bgooPYeijPR5\n\tkWpEJ8kOwk2W3foSO8+M1AgaIkMrO7hGgYHikpu5qsl2NcSNXAsdt16fJ8+km1qdmec3\n\t/I1Q==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1771961868; x=1772566668;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=64rlEuOYdbviyNQw0A2s83CgL5GfBgbapEfiAU7QnnM=;\n\tb=FT5mAt1l17whuHaJAKGsLXSWAlwKubquF50GAqVdSjByQYUH6DJ8BzFk22GssDYaAG\n\trezrYWEus01+ZZjQzVn84nWZiAP3ddU3gaNL/ygspbRL5jpFKF+xyyBEk0QLI/E/gO6V\n\tB8nEWQR9kLHb5iGIDKyEllDx1FLIEMFYwibEPOXOkg3opWXLCVBWsBbz+ioVQWZvEsrR\n\tBXZ69vL4iIJoaRXOHfPoME2NofT0/d9liDpcZww1fAq0PlSBUU8DyETPDPS3sOGBz+9K\n\tqs+N0clXApoLhK5vBgfozAKTRVKU7u952pxiagpCSG5jnk1JF9rA8Y9kXgq8/bKHl7hm\n\tzQxQ==", "X-Gm-Message-State": "AOJu0YzsPBrnl3vTTed91yHFnlJ/+jc3oKbvEEVlIkQzNirEwT5tlAfE\n\t2LlME1COWKTNZZTgpL0deqWTAyEirzsNmp5SNzEjBqKSeOYzeqot/LeQqP0cqK1uBPbm7U3F4PN\n\tbAFMYRaSYBR/B0TW4SotBlEQyZY6q1+QheO0MVQT6DIbawQi31lIIPwExGkHbrcPpTHYcYy3bvm\n\tt9brjB34pt", "X-Gm-Gg": "AZuq6aIE03XSO+T11R4PwZRjBqlZECq27vsqnXy8SVmjTuBqYB39sVFoFg3MjkuvOF9\n\tWIkfcR9BiltB+C14vhVFyc8hQk/cD2kn0/GdF0lBXJhJAhWp5Qj5bL78QRuNjRk7aqaE26CsYiq\n\t/jDsOrFwCvW48Plp5GFEnMwnUgj2rWSR3WA7kxiOH6XrlXwcijoLUWuTiMkuQ+y43y8dbe5L8S6\n\tpej4/JNqxAbCLduiOVP5u9kzSGyzbqsyuACGPJCyq/z1HhJFfsGHEwKnhLFoFFor6Sc79wZO7ki\n\tvIiIOKQNO3Wz8dwze3HFidWutLh0DyWnEcodsEF9OPf22vPB7WhCz1eDmM+M98weQu9KKYLBXEK\n\t6bKKWiwDxEV5lim9bkywyHmFBFsLFeL3gDn4U+oF2ChrFlqUZ4Ifb/Dqko0JzoTWhGXdIWeaE6G\n\tBnnWMp4R1mQTTY9iS/gq/NrHKReq4l+memOn+Y", "X-Received": [ "by 2002:a05:620a:4444:b0:8c8:8126:7770 with SMTP id\n\taf79cd13be357-8cb8ca8bf9bmr1547868085a.67.1771961867623; \n\tTue, 24 Feb 2026 11:37:47 -0800 (PST)", "by 2002:a05:620a:4444:b0:8c8:8126:7770 with SMTP id\n\taf79cd13be357-8cb8ca8bf9bmr1547864185a.67.1771961867040; \n\tTue, 24 Feb 2026 11:37:47 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org, Milan Zamazal <mzamazal@redhat.com>", "Cc": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v3 0/4] software_isp: debayer_cpu: Add multi-threading\n\tsupport", "Date": "Tue, 24 Feb 2026 20:37:41 +0100", "Message-ID": "<20260224193745.106186-1-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Authority-Analysis": "v=2.4 cv=UtFu9uwB c=1 sm=1 tr=0 ts=699dfe0c cx=c_pps\n\ta=hnmNkyzTK/kJ09Xio7VxxA==:117 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=yx91gb_oNiZeI1HMLzn7:22 a=41hSnr9hGZ3gkYn28OYA:9\n\ta=PEH46H7Ffwr30OY-TuGO:22", "X-Proofpoint-GUID": "VjKi4v_zZmkrhbJc8mDhsVXbEHP8BnC4", "X-Proofpoint-ORIG-GUID": "VjKi4v_zZmkrhbJc8mDhsVXbEHP8BnC4", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMjI0MDE2OCBTYWx0ZWRfX7WiNc3G3k4B8\n\tNS07eP+Olzle8NszaNsCeDY+4nLd7JlMW8S+nOyGqi4Lm+SR0EY6n+F8MERmeF1FKsQmb0BfrWT\n\tsT6sNuDrMnbJ2WIZhBP9epjoJJMaS43zGCx+lQG/K/y5Q4mf6j0/Zx+o8w7Vh0EOstsxHgMt+nD\n\tjrEcK1OqjImzBaDWUaRG9yDnKuo2EBszTSY2h8zPOkeRvPPb/6DaWg1owIhRR/aExTk0W7FB73o\n\tB1tWaAloOmmYfHh2EcjQ0r2ktBCfRvL1+2HwsMTcf0ccq1QIj+guLYfCuB64nknmXU06OZ6SjfL\n\tgh0pmioqbXXxr+lK0DsU5p2XxYLWWvCL3LV8gYWLO80nEAYqThx1X+abJGRvOr3gGdVv9ZKfBzq\n\tYSdj+EA9CxTYcwvEvYPJ82GDdl/eoDZouCL6KPzpbWJK/vEGGO4sa38H7MKTy7IJFTlc/vHwksH\n\t8cas6sGV/lQVZErJEMA==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-02-24_02,2026-02-23_03,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tpriorityscore=1501 impostorscore=0 spamscore=0 adultscore=0\n\tmalwarescore=0\n\tsuspectscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0\n\tbulkscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2602240168", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi All,\n\nThe QCM2290 SoC used on the Arduino Uno-Q seems to have a weak GPU, so weak\nthat it is barely faster then a single CPU core (CPU without CCM).\n\nThis has made me code-up the long envisioned multi-threading support\nfor the CPU softISP.\n\nChanges in v3:\n- Use std::unique_ptr for the DebayerCpuThread pointers\n- Document new DebayerCpuThread class\n- Make DebayerCpuThread inherit from both Thread and Object\n- Use for (auto &thread : threads_)\n- Use for (auto &s : stats_) {}\n- Move input format logging from DebayerCpu::configure() to\n SoftwareIsp::configure()\n\nChanges in v2:\n- Quite a bit of refactoring based on v1 feedback, dropped patch 3/5 and 4/5\n from v2 since these now no longer make sense\n- Move the allocation of the vector of SwIspStats objects to inside\n the SwStatsCpu class, controlled by a configure() arguments instead\n of making the caller allocate the objects\n- Replace the DebayerCpuThreadData struct from v1 with a DebayerCpuThread\n class, derived from Object to allow calling invokeMethod for thread re-use\n in followup patches\n- As part of this also move a bunch of methods which primarily deal with\n per thread data: setupInputMemcpy(), shiftLinePointers(), memcpyNextLine(),\n process*() to the new DebayerCpuThread class\n- Re-use threads instead of starting new threads every frame\n- Add a new patch adding some extra DebayerCpu input format logging\n\nBenchmark results for the Uno-Q + IMX219 running at 3280x2464 -> 3272x2464\nwithout CCM:\n\n1 thread : 147ms / frame, ~6.5 fps\n2 threads: 80ms / frame, ~12.5 fps\n3 threads: 65ms / frame, ~15 fps\nGPU: 130ms / frame, ~7,5 fps\nGPU 0-copy: 110ms / frame, ~9.5 fps (requires pipeline + camss hacks)\nGPU lite: 85ms / frame, ~12 fps (CCM, contrast and gamma disabled)\n\nRegards,\n\nHans\n\n\nHans de Goede (4):\n software_isp: swstats_cpu: Prepare for multi-threading support\n software_isp: debayer_cpu: Add DebayerCpuThread class\n software_isp: debayer_cpu: Add multi-threading support\n software_isp: Log input config from configure()\n\n .../internal/software_isp/swstats_cpu.h | 25 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 283 ++++++++++++++----\n src/libcamera/software_isp/debayer_cpu.h | 26 +-\n src/libcamera/software_isp/software_isp.cpp | 12 +-\n src/libcamera/software_isp/swstats_cpu.cpp | 54 ++--\n 5 files changed, 294 insertions(+), 106 deletions(-)" }