Cover Letter Detail
Show a cover letter.
GET /api/covers/25601/?format=api
{ "id": 25601, "url": "https://patchwork.libcamera.org/api/covers/25601/?format=api", "web_url": "https://patchwork.libcamera.org/cover/25601/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251218123524.130886-1-naush@raspberrypi.com>", "date": "2025-12-18T12:31:22", "name": "[v2,0/2] RPi: Internal buffer alloaction rework", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/25601/mbox/", "series": [ { "id": 5671, "url": "https://patchwork.libcamera.org/api/series/5671/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5671", "date": "2025-12-18T12:31:22", "name": "RPi: Internal buffer alloaction rework", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5671/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/25601/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2722FBD7D8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 18 Dec 2025 12:35:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16E1B61AA8;\n\tThu, 18 Dec 2025 13:35:33 +0100 (CET)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB23F61603\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Dec 2025 13:35:31 +0100 (CET)", "by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-47928022b93so1320125e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 18 Dec 2025 04:35:31 -0800 (PST)", "from naush-dell.pitowers.org\n\t([2a00:1098:3142:1f:1670:643a:b830:51f7])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-4324493fd73sm4769434f8f.13.2025.12.18.04.35.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 18 Dec 2025 04:35:30 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"nwblTTZs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1766061331; x=1766666131;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=ygQYMov/C/Gup2/jN2wTz9BaA9TotbSoNj7nn4tBTUU=;\n\tb=nwblTTZsK7yCoyhzrew2DwV7GTxGqSMFVmo6R9zqVYi61aYWN/hz3EYSlbBKppLwG7\n\tvXW02Y4B333ej0+0ppAYeZkuFoR+IodtXT6HAgr1PPVZjiXOQOkwEdTu8TUkeG7vrlux\n\t7ky8JhymQg64Gk1y21Ey4PwqjY1jNiPAijyf2mSYxOO5dvXB1Ad8qwhybvEStOxtM7z/\n\toob7Bdhd/juIaDcDOBS29+8RgNd6ZkB9qfdbF0TRpTcZEnIcplZ+DEoW59OWDufliyCS\n\tZ9ddrvvEWT9g5z0yr2EaShi/lQs5wF7GaM2O85HkKK7AZa52JSA5XQ/poV5EcCPH7B3W\n\tiVfQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1766061331; x=1766666131;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ygQYMov/C/Gup2/jN2wTz9BaA9TotbSoNj7nn4tBTUU=;\n\tb=WI77ScryNoxu7J0603lyyhxl9AhTUF97QY5cflHcZBwc4JpGu5jW4EreQy7HUKXnrb\n\trFXa8evWPvOiY9Hw2BYeGp3pyjkyLalOyVcGnbvx5rqaO9LDvmxfHxM4DqE5wTV0oT4i\n\tUCccoPDixbyh813MkPMtIo1J0EXBxJ9K6kf3i0lXz9/sDem17A4h0flzIrH8cNqmp5tn\n\tRmCmTDPfN28bm2xcu8tUTbo0LT9IyWGz3M+X5lH8Mu2eqXryo9I8MvEmEGhd+dapedWD\n\tCeQ6m2PQnfE1LDz7msrwxELtsDQmU54sBLOo629UExIoSHEKrbKoY2bQEwbUSIUSwig0\n\tCmng==", "X-Gm-Message-State": "AOJu0Yy72aAk1tNiy9bbWKJDMrtqzVVAzAe83QDwBL4y7EIN5jcOwvWB\n\tp8d9r9GX9s5EWSKGu/YJVA0h+0M2HAHxQzScuVo4yLBNTLLR9nhGW9eL932PCYmApeEiTYWeW7r\n\t+vaQR", "X-Gm-Gg": "AY/fxX7fSAAGIbDEwtPX9c1R44uHZRgRRGj3UuUpdccDc7c8dlTnHJ+OyfzYE6+aw5M\n\tsptKoif2c1CPG2Y8IZvcyBdZSuzuTwVCbJN1+exiJVQUkEb2ktiU+T38dCneFs/px37KL3OGXBs\n\tGWfHuVJfV0osuRv639AjAjtjDXswOzADmI4W9sX1dORmS/NjtU/joR+iu8rj1N25ILrJuQoL61u\n\tEYO4wbZN7PGQHEqbu/PO09VmiDdIvIYg97lq5dH6lTk/lQJlruP/ETucgDKmC27D7fkbiF69NZ9\n\tIKE6EJs99PHebhnnS2fRAsng2ZnBfpIdbCPkezpfEEFaCLynVs4ygbGBww0ytAwyChyScMQMVby\n\tRpj6J9xP+5Z8UCOR6GgQdFkuapGTIxEXJNukAbTxrD4gEwOu7ejJWVuZomlBDBh+p+nEADBqQMS\n\tb/wpKWjBHX+gmh+q2jCWONLUaDD4SC3iI=", "X-Google-Smtp-Source": "AGHT+IHFy6Yx6LKW/0n+9RvCxs8ZpKGvjcJwPptJZz6J1xpYHbDNIIj09lFxZBGkgYRruH5ORjqEkQ==", "X-Received": "by 2002:a05:600c:4e8a:b0:477:a6f1:499d with SMTP id\n\t5b1f17b1804b1-47ce8776b26mr9499025e9.3.1766061330940; \n\tThu, 18 Dec 2025 04:35:30 -0800 (PST)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tNaushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v2 0/2] \tRPi: Internal buffer alloaction rework ", "Date": "Thu, 18 Dec 2025 12:31:22 +0000", "Message-ID": "<20251218123524.130886-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nNo code changes in v2, only tags added.\n\nJacopo, I thought it would be a trival change to address your comment regarding\ncalling importBuffers() unconditionally for disabled nodes. Turns out it's not,\nand will need a bit of quite annoying plumbing since the base pipeline handler\nclass knows nothing about TDN and Sitch device nodes which are PiSP specific.\nIn the interest of getting this merged quickly I suggest we keep this as-is as\nthe unconditional call only does allocation of v4l2 slots, so is not a big deal.\nIf you are ok with that, we can go ahead and merge this.\n\nRegards,\nNaush\n\nNaushir Patuck (2):\n pipeline: rpi: Rename Stream::prepareBuffers to\n Stream::allocateBuffers\n pipeline: rpi: Rework internal buffer allocations\n\n .../pipeline/rpi/common/pipeline_base.cpp | 10 ++++++--\n .../pipeline/rpi/common/pipeline_base.h | 2 +-\n .../pipeline/rpi/common/rpi_stream.cpp | 25 ++++++-------------\n .../pipeline/rpi/common/rpi_stream.h | 3 +--\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 ++---\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 ++---\n 6 files changed, 24 insertions(+), 28 deletions(-)" }