Cover Letter Detail
Show a cover letter.
GET /api/covers/24980/?format=api
{ "id": 24980, "url": "https://patchwork.libcamera.org/api/covers/24980/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24980/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251106164239.460738-1-stefan.klug@ideasonboard.com>", "date": "2025-11-06T16:42:24", "name": "[v2,0/3] libipa: agc: Fix constraints yTarget handling and add PWL support", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/24980/mbox/", "series": [ { "id": 5567, "url": "https://patchwork.libcamera.org/api/series/5567/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5567", "date": "2025-11-06T16:42:24", "name": "libipa: agc: Fix constraints yTarget handling and add PWL support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5567/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24980/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78AC1BDE4C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 6 Nov 2025 16:42:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90E4760A8B;\n\tThu, 6 Nov 2025 17:42:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D5F30606E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 6 Nov 2025 17:42:43 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:1d00:3bae:f27:7601])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A816F6AF;\n\tThu, 6 Nov 2025 17:40:48 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a0wPU7P1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1762447248;\n\tbh=s94Ms0z5emjQLXxcBnHiZe+je3imskF5ZlWQm9wmn2w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=a0wPU7P1JxaG/pwQPCgqon7+3aZkrSV6bytI1Imw0YkIfbQXWI3d/ySf0Sazqbt1b\n\tCRO31vktlJEw4/Jdz/+pz3isO7pQQJdFsLgXgziCTpSxVRm2ZeJmAEXzq7USqffLaI\n\tMleDPSab9oVVXph8TDz/idLZ/oUdBMK4qHcpeYKU=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v2 0/3] libipa: agc: Fix constraints yTarget handling and add\n\tPWL support", "Date": "Thu, 6 Nov 2025 17:42:24 +0100", "Message-ID": "<20251106164239.460738-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi all,\n\nThis series introduces support for specifying the\nrelativeLuminanceTarget based on the current lux level by using a PWL\nfor the mapping. The typical use case is to ensure that images in a\nbright environment are regulated a tad brighter than images taken in a\ndark environment. This is a very subjective setting and should therefore\nbe left to the user/camera designer. Mainlining this feature was already\ntried in [1] but got rejected at that time because there was no direct\nuser of it. Meanwhile the lux algorithm got upstreamed and we have users\nthat actually miss that feature. So I start another try of upstreaming\nit (patch 2).\n\nDuring implementation it turned out that the yTarget of AGC constraints\nnever worked at all. So patches 3 fixes that and also add PWL support\nfor the constraints which is sensible to do if we support it for the\nrelativeLuminanceTarget.\n\nChanges in v2:\n- Dropped patch 1 that implemented Pwl::swap() as the intended use can\n already be achieved using the autogenerated move assignment operator\nand move constructor together with std::move()\n- Dropped the addition of a initializer_list based constructor to Pwl as\n this can be achieved in a bit more verbose way already.\n- Added patch 1 that extends the yaml PWL reading code to support plain\n values. This also simplified the subsequent patches.\n\nBest regards,\nStefan\n\n\nStefan Klug (3):\n ipa: libipa: pwl: Allow to parse a plain yaml value as single point\n PWL\n ipa: libipa: agc_mean_luminance: Change luminance target to piecewise\n linear function\n ipa: libipa: agc_mean_luminance: Fix yTarget handling in constraints\n\n src/ipa/libipa/agc_mean_luminance.cpp | 92 +++++++++++++++++++++------\n src/ipa/libipa/agc_mean_luminance.h | 16 +++--\n src/ipa/libipa/pwl.cpp | 9 +++\n src/ipa/rkisp1/algorithms/agc.cpp | 1 +\n src/ipa/rkisp1/algorithms/wdr.cpp | 3 +-\n 5 files changed, 97 insertions(+), 24 deletions(-)" }