Cover Letter Detail
Show a cover letter.
GET /api/covers/24697/?format=api
{ "id": 24697, "url": "https://patchwork.libcamera.org/api/covers/24697/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24697/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251017102704.3887-1-david.plowman@raspberrypi.com>", "date": "2025-10-17T10:05:36", "name": "[0/5] Fix and improve full image Y statistics", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/24697/mbox/", "series": [ { "id": 5509, "url": "https://patchwork.libcamera.org/api/series/5509/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5509", "date": "2025-10-17T10:05:36", "name": "Fix and improve full image Y statistics", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5509/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24697/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CD3BC3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 17 Oct 2025 10:27:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD0CD606AD;\n\tFri, 17 Oct 2025 12:27:09 +0200 (CEST)", "from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90EEB60697\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Oct 2025 12:27:08 +0200 (CEST)", "by mail-wm1-x32f.google.com with SMTP id\n\t5b1f17b1804b1-47114a40161so17063875e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 17 Oct 2025 03:27:08 -0700 (PDT)", "from localhost.localdomain ([2a06:61c0:f337:0:8aba:2a85:b765:a23e])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47114428dedsm73811905e9.7.2025.10.17.03.27.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 17 Oct 2025 03:27:07 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"UAmrRe9o\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1760696828; x=1761301628;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=FOuj0EWFAuykVD/HHPch7Lkl11X3dJ1hzUyfv+tY05o=;\n\tb=UAmrRe9oJV64a4ommZTqSNnLAk1TUanKgQoz+fxZSaYAC+nGgxlpezv8+b0VFz6EfF\n\tyKjQB42siWU6a2eZKHuxtx9mRgoiLVBxruC8mMmcNPsgay7bWPIcZP2w8xlk2sPnVZCv\n\t4ccmSJGraRmussd4M+yaU8WUivLCk/3XuOKcSUDmgIaIORAlouEoWW+bOPte1paKWwpu\n\tSCeWGFjyCRvZhVHiNW40HimyrOicXV5NA0qpCK2IGBOUM3ufrY/R2xSTQ5a3M9n/xQLB\n\t0BOaW5+zSteIaquWgoiMAmXpOHhMq8/eHv5CboeqR6R8ssqRnxzqrWkeNn2XLIoZ/2BJ\n\tEXtA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1760696828; x=1761301628;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=FOuj0EWFAuykVD/HHPch7Lkl11X3dJ1hzUyfv+tY05o=;\n\tb=BAiRgW3t2cn5yWiIoQoYiPetu6Pm0LEFQbjqE1gy0A1zL1QjJ2zljp+2VcRA33ULwU\n\tVhkbqmmadyZ5D/eixNkHEaMIFShYn6v11vabPHvmJQnIf5qyvdl8icBSy84T0gpZvugZ\n\tH/3+ViUSw+QcKuAuJYCwsW3oOPrwZQ6mzJYZ2bcsx1pYWxmTlgoe9mdGG3oWFuDulqO1\n\t52KAkMt2kDjL/gtbE2oSLGC34on80iAPyhq5oSXWtzEWNoLCDeLtIKU6O1UyBu1/n3ZX\n\tlUUkfLBgoGCCYVvBOmtyK43ZuXXMudWP6EAWKX1mlgbhRNjCm31RAadq8vsa+8zLhcbx\n\tCmiw==", "X-Gm-Message-State": "AOJu0Yz6ZvKL4GXhTho8aZ8jIwmjE+qD3WJ+O+T6HfHGOubGNKeoCDn8\n\twPBU0SncLJsMwWHSJLjtDIGPjsmbvVP3XPvnDvcx+Mwf1lmfHKwIGMXRpHnCPg5TaAyif+UPvS3\n\tlJV38I2o=", "X-Gm-Gg": "ASbGnctMvXqC068uNnfdApngac69lml9Yyh6GhkwNK1NhnUeU/xsbGhTNZ5CBj94U/Y\n\trDqQD8U2cwcXaW4vVZqT1OUkIGRa5wEYFwvwyDqnUu1eonGFa9+PZuWn/Pq0Xyxwin2v0bwhv/+\n\tuhAyhixlh2QKR3k6pjIUhtj3QEBay+UPHea09/9CcWfJEovXnzIwVOAMTEvpkpvSNy6JAVGj83N\n\tgoM05vXApStf+HD9vbPzz8vYH+sJTeqHCMXyRkrfJ2oMywIJGUeL4BY9xK15TpoFtZBYkm6+hRu\n\tkqJQKuWHx7HI3KLDQQhtNqAOCxlF1D6jSTQbUmWc3O0on8p8AbzNsKWrAgGVRIdYUAc5iQrFL1+\n\txN9XR2X9vx+p8vh0pODh1IEJDrvekkjpRQpmHDB17YsM9/c0wd05f7+9CEkxh53u6e0niP324b+\n\tedWIOVnukHQZEZTuoAwa7di7czR15cuf8U8O5xY9zpeFLwhxMB8YMDXkgzuK9dSgIdL7lE7NmqQ\n\t4KY/3D2rvNUU22g4S19K420UQ==", "X-Google-Smtp-Source": "AGHT+IE2x4WJJ38Yosvls2T/qWJNLoY6DSLvBS/bLv47dle0i5poYzJ+tqnBxnM/AvoBe9E5Fpq51Q==", "X-Received": "by 2002:a05:600c:37ce:b0:471:ff3:a87e with SMTP id\n\t5b1f17b1804b1-4711791d205mr24317035e9.36.1760696827520; \n\tFri, 17 Oct 2025 03:27:07 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH 0/5] Fix and improve full image Y statistics", "Date": "Fri, 17 Oct 2025 11:05:36 +0100", "Message-ID": "<20251017102704.3887-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.47.3", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi\n\nThis small set of patches improves the calculation of the scene\naverage Y value as used by the \"lux\" algorithm.\n\nThe previous calculation had some problems, most glaringly that it\nwasn't invariant to the AGC metering mode - and the whole point of the\n\"lux\" algorithm is supposed to be to calculate a purely scene\ndependent number!\n\nSo we update both VC4 and PiSP platforms to have a \"floating\nstatistics region\" where we can accumulate a full image Y value. We\nactually have hardware for this on the PiSP, but for VC4 we are able\nto \"synthesize\" such a floating region from the other statistics that\nwe have.\n\nThese changes are good in themselves, but were also motivated by\nwanting more reliable lux measurements for the forthcoming neural\nnetwork AWB algorithm.\n\nA couple of other minor related things are fixed in passing, such as\nmaking the lux algorithm use the camera mode sensitivity correctly (as\nit was simply being ignored).\n\nThanks!\n\nDavid\n\nDavid Plowman (5):\n ipa: rpi: Fix the set function for floating statistics regions\n ipa: rpi: lux: Handle camera mode sensitivity correctly\n ipa: rpi: pisp: Use a floating region to get whole image Y statistics\n ipa: rpi: vc4: Use a floating statistics region for a full image Y sum\n ipa: rpi: lux: Use floating statistics region to obtain the current Y\n value\n\n src/ipa/rpi/controller/region_stats.h | 2 +-\n src/ipa/rpi/controller/rpi/lux.cpp | 24 +++++++++++++++----\n src/ipa/rpi/controller/rpi/lux.h | 3 +++\n src/ipa/rpi/pisp/pisp.cpp | 8 ++++++-\n src/ipa/rpi/vc4/vc4.cpp | 33 +++++++++++++++++++++++++--\n 5 files changed, 62 insertions(+), 8 deletions(-)" }