Cover Letter Detail
Show a cover letter.
GET /api/covers/24472/?format=api
{ "id": 24472, "url": "https://patchwork.libcamera.org/api/covers/24472/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24472/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250926-v4l2-params-v3-0-ee114782c1be@ideasonboard.com>", "date": "2025-09-26T14:39:32", "name": "[v3,0/5] ipa: libipa: Introduce V4L2Params", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/24472/mbox/", "series": [ { "id": 5461, "url": "https://patchwork.libcamera.org/api/series/5461/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5461", "date": "2025-09-26T14:39:32", "name": "ipa: libipa: Introduce V4L2Params", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5461/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24472/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C193DC328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 26 Sep 2025 14:39:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 999896B5FB;\n\tFri, 26 Sep 2025 16:39:53 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 822CB613AB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Sep 2025 16:39:51 +0200 (CEST)", "from [192.168.1.100] (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D15714B0;\n\tFri, 26 Sep 2025 16:38:25 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OJ+anvYq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758897506;\n\tbh=pKFSSqNy59k24zA1evXTSrFHgptmIC2Tt3P5f751qsM=;\n\th=From:Subject:Date:To:Cc:From;\n\tb=OJ+anvYqELA1vFWChA/ukZTlNl2MbxWtuBdoYdo01D98rT/BdOrd0q8QJ0jJPFx1h\n\tGX6u01JlIjffR4Qz1PcKSOP0wCosWZDHcD6mTwb6EePwImVaheh6JJZYoZEvWcrgp2\n\tZmDDTXA+WvE3rZSlRXwleaDM1vr6Ph3MFmLxPMx8=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 0/5] ipa: libipa: Introduce V4L2Params", "Date": "Fri, 26 Sep 2025 16:39:32 +0200", "Message-Id": "<20250926-v4l2-params-v3-0-ee114782c1be@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIAKSl1mgC/23M0QqDIBiG4VsJj+cwNc0d7T7GDv7ydwkrQ4dsR\n\tPc+62QMOnw/+J6FJIweE7lUC4mYffJhKiFOFekHmB5IvS1NOOMNa7mhWT45nSHCmKiVHKAxBnU\n\tLpDzmiM6/d+12Lz349Arxs+O53tZjJ9eUUSGZ1sJ1yjh39RYhhakLEO25DyPZuMx/hKnVP8ELo\n\tZWUukarpGgOiHVdv0TFYTjwAAAA", "X-Change-ID": "20250829-v4l2-params-d42aa599e78a", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tAntoine Bouyer <antoine.bouyer@nxp.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=3838;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=pKFSSqNy59k24zA1evXTSrFHgptmIC2Tt3P5f751qsM=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBo1qW1Nv+X9NfB9AvYJSrTZbSc2r0QBcOl7kT8k\n\tPcVvgTgEe6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaNaltQAKCRByNAaPFqFW\n\tPMNNEACNZhNW/3RXkG0APnN3KDhlDohTzZg5z+crgVEpb/c0oltoz2PZqYTm4OMjrGoAcfYcaIb\n\toQnEpeHRRlyARHLTWlag3psdcfncG9Nzpr1o2/hNrhuxsYlqUxUCraRDoux5dRov1t+waMgHUk3\n\tpANoqxV5BoPXEc5SScL9XZcW5PNRKiJ7N6XFT76Ne42VMPvUqPTBhcCQIJsM4KOi7hkfoKRfw1x\n\tF0Jn9jc5aVB/NLaGaYTSMOPABNVbORJn9GKFD4YXDbDUWxBm295dqnRKRVZfVNPyGjBS43S8KGm\n\tPFpwj28KZGbsT2SW6MPBOyqLK49aatg0Jq0NG81AAPdDtOIdZ4b2vrRzYLRGIUwkGK0n8BF593g\n\t1+oj2QcPtfspNSESTKcmnh8kbS2L70EvKx38TDqx2e6Cal3KhkUaB1HnTuSXBazyYYKyat2yADP\n\tAJMTwiKx2Y39dfYuLgL5lMfhgVFs6IjJW6awnWBm6lymWqa4I5tPkig5hrnn34cGiil4ruan9Ih\n\tsz0vaiocErsiIotYT72eVfbIdDHRz4LOoXMMBJ13/t2G6WMI9PGkRFIKmt+5rPgcGOhcaO1PvLH\n\tuZLjnXsmPDwkcEFaZLYNfwjyOtrvE4nRIoOZPtM+8H3siPMVKxpw5bKhAqFTHSG7CAKQijQMVNM\n\txFFMDWQ+CGE9jqw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the introduction of v4l2-isp.h in the Linux kernel currently in\nprogress:\nhttps://lore.kernel.org/all/20250915-extensible-parameters-validation-v5-0-e6db94468af3@ideasonboard.com/\n\nthe MaliC55 ISP driver at version in v11 has been ported to use a\nparameters format compatible with the one defined by v4l2 extensible\nparameters:\nhttps://lore.kernel.org/all/20250714-c55-v11-0-bc20e460e42a@ideasonboard.com/\n\nThis series\n1) Imports v4l2-isp in libcamera\n2) Update the Mali C55 header and IPA to compile with v11 of the patch\n series that introduces MaliC55 support in Linux\n3) Introduces V4L2Params by generalizing RkISP1Params\n4) Ports the Mali C55 IPA to use the newly introduced V4L2Params\n\nTested on rkisp1 and rzv2h\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\nChanges in v3:\n- Fix Mali-C55 and re-work RkISP1\n The Mali and RkISP1 IPA have a different requirements:\n\n\tstruct mali_c55_params_awb_gains {\n\t\tstruct v4l2_params_block_header header;\n\t\t__u16 gain00;\n\t\t__u16 gain01;\n\t\t__u16 gain10;\n\t\t__u16 gain11;\n\t};\n\n\tstruct rkisp1_ext_params_awb_gain_config {\n\t\tstruct rkisp1_ext_params_block_header header;\n\t\tstruct rkisp1_cif_isp_awb_gain_config config;\n\t} __attribute__((aligned(8)));\n\n The RkISP1 IPA needs to support legacy and extensible parameter\n formats, and wants to operate on 'struct rkisp1_cif_isp_' basically\n discarding the header.\n\n The Mali IPA (and all other IPA compatible with v4l2-isp) operates on\n the whole structure and do not need to discard the header.\n\n Rework V4L2ParamsBlock to return a Span<> matching the whole structure\n (header included) to support Mali correctly.\n\n This means the RkISP1ParamsBlock derived class has to override all the\n dereference operators to discard the header and allow the IPA to work\n with both the legacy and extensible formats.\n\n Tested with Mali C55, RkISP1 in extensible and legacy modes.\n\n- Link to v2: https://lore.kernel.org/r/20250916-v4l2-params-v2-0-764471ed6435@ideasonboard.com\n\nChanges in v2:\n- Address Barnabas' reviwe that allows to remove the block() overload in\n MaliC55\n- Link to v1: https://lore.kernel.org/r/20250829-v4l2-params-v1-0-340773fb69ff@ideasonboard.com\n\n---\nJacopo Mondi (5):\n include: linux: Add v4l2-isp.h\n include: linux: v4l2-isp: Provide __counted_by()\n ipa: Update Mali C55 header file and adjust IPA\n ipa: libipa: Introduce V4L2Params\n ipa: mali-c55: Introduce MaliC55Params\n\n include/linux/mali-c55-config.h | 162 +++-----------------\n include/linux/media/v4l2-isp.h | 118 ++++++++++++++\n src/ipa/libipa/meson.build | 2 +\n src/ipa/libipa/v4l2_params.cpp | 262 ++++++++++++++++++++++++++++++++\n src/ipa/libipa/v4l2_params.h | 142 +++++++++++++++++\n src/ipa/mali-c55/algorithms/agc.cpp | 87 +++++------\n src/ipa/mali-c55/algorithms/agc.h | 14 +-\n src/ipa/mali-c55/algorithms/algorithm.h | 2 +-\n src/ipa/mali-c55/algorithms/awb.cpp | 64 ++++----\n src/ipa/mali-c55/algorithms/awb.h | 10 +-\n src/ipa/mali-c55/algorithms/blc.cpp | 20 +--\n src/ipa/mali-c55/algorithms/blc.h | 3 +-\n src/ipa/mali-c55/algorithms/lsc.cpp | 58 +++----\n src/ipa/mali-c55/algorithms/lsc.h | 8 +-\n src/ipa/mali-c55/mali-c55.cpp | 19 +--\n src/ipa/mali-c55/module.h | 3 +-\n src/ipa/mali-c55/params.h | 83 ++++++++++\n src/ipa/rkisp1/params.cpp | 93 +-----------\n src/ipa/rkisp1/params.h | 175 ++++++++++++---------\n 19 files changed, 849 insertions(+), 476 deletions(-)\n---\nbase-commit: 22f6edc686c86904c3843ec19c8af5ba19c93298\nchange-id: 20250829-v4l2-params-d42aa599e78a\n\nBest regards," }