Cover Letter Detail
Show a cover letter.
GET /api/covers/24341/?format=api
{ "id": 24341, "url": "https://patchwork.libcamera.org/api/covers/24341/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24341/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250912-flash_reco-v2-0-d5bb80a2e619@emfend.at>", "date": "2025-09-12T07:13:19", "name": "[v2,0/5] Support for v4l2 flash devices", "submitter": { "id": 134, "url": "https://patchwork.libcamera.org/api/people/134/?format=api", "name": "Matthias Fend", "email": "matthias.fend@emfend.at" }, "mbox": "https://patchwork.libcamera.org/cover/24341/mbox/", "series": [ { "id": 5437, "url": "https://patchwork.libcamera.org/api/series/5437/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5437", "date": "2025-09-12T07:13:19", "name": "Support for v4l2 flash devices", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5437/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24341/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52E26C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Sep 2025 07:13:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 38109613A3;\n\tFri, 12 Sep 2025 09:13:30 +0200 (CEST)", "from lx20.hoststar.hosting (lx20.hoststar.hosting [168.119.41.54])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 949D5613A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Sep 2025 09:13:27 +0200 (CEST)", "from 194-208-208-245.tele.net ([194.208.208.245]:58477\n\thelo=[127.0.1.1]) by lx20.hoststar.hosting with esmtpsa (TLS1.3) tls\n\tTLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93)\n\t(envelope-from <matthias.fend@emfend.at>)\n\tid 1uwxyI-008cBW-A6; Fri, 12 Sep 2025 09:13:26 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=emfend.at header.i=@emfend.at\n\theader.b=\"EWUcqFDy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=emfend.at;\n\ts=mail;\n\th=Cc:To:Content-Transfer-Encoding:Content-Type:MIME-Version:\n\tMessage-Id:Date:Subject:From:Sender:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=wzSnx12OEWJt2URK59JhJ1eyr/d+RYPz3MrAxbdJ8JQ=;\n\tb=EWUcqFDyCKPwsFMw1WZcPeGQeQ\n\tm+6UGBmjseIhDwhqLY06ouu5cFS2W/41IVGr08zNv6zU2iMR4EgU8e8z1PsFygY+GZYaaOm6EqJHW\n\tJ+2nlmDHZzAve+vGkYpKlh6xu69S5MQ9ZbBfZLqnBiNu6WiIQQPHqjvTqDnxbtlt83jQ=;", "From": "Matthias Fend <matthias.fend@emfend.at>", "Subject": "[PATCH v2 0/5] Support for v4l2 flash devices", "Date": "Fri, 12 Sep 2025 09:13:19 +0200", "Message-Id": "<20250912-flash_reco-v2-0-d5bb80a2e619@emfend.at>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIABDIw2gC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyjHQUlJIzE\n\tvPSU3UzU4B8JSMDI1MDS0Mj3bScxOKM+KLU5HzdlBRjU3ODlERDgxRjJaCGgqLUtMwKsGHRsbW\n\t1ALqRa5pcAAAA", "X-Change-ID": "20250912-flash_reco-dd3570da10d3", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Matthias Fend <matthias.fend@emfend.at>", "X-Mailer": "b4 0.14.2", "X-Spam-Score": "", "X-Spam-Bar": "", "X-Spam-Report": "", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\neven though the API contained here is considered too low-level and the\nseries will therefore probably never be merged, I have nevertheless decided\nto include the feedback I have already received and send an updated series.\nPerhaps this will be helpful to someone in the meantime, until a new API\nexists.\n\n-\n\nThis series brings initial support for v4l2 flash devices.\n\nWith these patches, v4l2 flash devices can be controlled by applications\nvia libcamera controls. Applications therefore only require one API and do\nnot have to worry about details such as finding the appropriate v4l2 flash\ndevice.\n\nThe controls are currently quite transparent and no advanced flash\nsequences (pre-flash, AGC precorrection, etc.) are supported.\n\nThis functionality should be easy to integrate into the various pipeline\nhandlers and is implemented as an example for the RKSIP1 pipeline.\n\nSigned-off-by: Matthias Fend <matthias.fend@emfend.at>\n---\nChanges in v2:\n- Move controls from draft to core\n- Improve documentation for new controls\n- CameraFlash::Consistently use controlInfoMap_ \n- CameraFlash: add error checking in getSubdevControl()\n- CameraFlash: make return value getX() optional\n- CameraFlash: remove model() and controls()\n- CameraFlash: use class enums\n- FlashControl: also map values for metadata controls\n\n---\nMatthias Fend (5):\n libcamera: control_ids_core: Add flash controls\n libcamera: Add support for camera flash devices\n Documentation: Add flash driver requirements\n libcamera: Add flash helpers for pipeline handlers\n rkisp1: Add support for camera flash devices\n\n Documentation/documentation-contents.rst | 1 +\n Documentation/flash_driver_requirements.rst | 40 +++++\n Documentation/index.rst | 1 +\n Documentation/meson.build | 1 +\n include/libcamera/internal/camera_flash.h | 72 ++++++++\n include/libcamera/internal/camera_sensor.h | 2 +\n include/libcamera/internal/flash_control.h | 23 +++\n src/libcamera/camera_flash.cpp | 249 ++++++++++++++++++++++++++\n src/libcamera/control_ids_core.yaml | 78 ++++++++\n src/libcamera/flash_control.cpp | 148 +++++++++++++++\n src/libcamera/meson.build | 2 +\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +\n src/libcamera/sensor/camera_sensor_legacy.cpp | 13 ++\n src/libcamera/sensor/camera_sensor_raw.cpp | 13 ++\n 14 files changed, 648 insertions(+)\n---\nbase-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\nchange-id: 20250912-flash_reco-dd3570da10d3\n\nBest regards," }