Cover Letter Detail
Show a cover letter.
GET /api/covers/23394/?format=api
{ "id": 23394, "url": "https://patchwork.libcamera.org/api/covers/23394/?format=api", "web_url": "https://patchwork.libcamera.org/cover/23394/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250520123158.44237-1-mzamazal@redhat.com>", "date": "2025-05-20T12:31:45", "name": "[v5,00/12] Enable raw streams with software ISP", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "mbox": "https://patchwork.libcamera.org/cover/23394/mbox/", "series": [ { "id": 5184, "url": "https://patchwork.libcamera.org/api/series/5184/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5184", "date": "2025-05-20T12:31:45", "name": "Enable raw streams with software ISP", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5184/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/23394/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D2DFC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 May 2025 12:32:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DE4968D85;\n\tTue, 20 May 2025 14:32:16 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EE9C614DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 May 2025 14:32:14 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-646-9Mc9-_koOqyTaoTrafkMeg-1;\n\tTue, 20 May 2025 08:32:08 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 615D7180087F; Tue, 20 May 2025 12:32:05 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.214])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id B780219560B0; Tue, 20 May 2025 12:32:02 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"foO65/5d\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1747744333;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=C/LXFY59LUWN4gw621ReyZX6kGA09xN7E8s3RA9XmR0=;\n\tb=foO65/5dpWWVJigwLyYq3WwMNHzlWbjCkWpK1QGMO8xawfFTjNVpzZ4HiWJ9EXNlFrgrGE\n\tyJrFdi7OxLpCVVlCUE2Je+rXjvAQiU5ELRqaDnuM71tiVsIrwWmuiCRIFqbjie3AX7v4SG\n\tDUA02f308QkSCrLH2aDsgQWPtJGD7BM=", "X-MC-Unique": "9Mc9-_koOqyTaoTrafkMeg-1", "X-Mimecast-MFC-AGG-ID": "9Mc9-_koOqyTaoTrafkMeg_1747744325", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>, Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH v5 00/12] Enable raw streams with software ISP", "Date": "Tue, 20 May 2025 14:31:45 +0200", "Message-ID": "<20250520123158.44237-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "U98nm4zau8a3eWuF8l8Uyu3UtG3dkoaxa47edZMIqp4_1747744325", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This makes raw streams working again in ‘simple’ pipeline when software\nISP is enabled for the given device. At most one raw stream and one\nprocessed stream (possibly both at once) are supported.\n\nAn example ‘cam’ invocation requesting a raw stream rather than a debayered stream:\n\n cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw\n\nOr for both raw and processed streams:\n\n cam -c1 -C8 -Ffile# \\\n -s role=viewfinder,width=1920,height=1080,pixelformat=RGB888 \\\n -s role=raw,width=3280,height=2464,pixelformat=SRGGB8 \\\n\nWhen only a raw stream is requested, there are no exposure/gain\nadjustments applied. This could be improved in future, once software\nISP gets a mechanism to gather image statistics without processing and\nusing them to make the adjustments, or once manual exposure controls are\nadded to software ISP. In the meantime, exposure must be changed\nexternally.\n\nTested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: Robert Mader<robert.mader@collabora.com>\n\nChanges in v5:\n- Possible temporary segfault in the patch adding plain output\n configurations avoided.\n- PixelFormatInfo::isRaw() helper added.\n- SimplePipelineHandler::setUpFormatSizes replaced with a lambda\n function.\n- SimpleCameraData::{rawRequested_,processedRequested_} are set in\n SimpleCameraConfiguration first and copied to SimpleCameraData only\n after successful configure().\n\nChanges in v4:\n- Broken range pruning due to passing a value rather than a reference\n fixed.\n- New common function isFormatRaw introduced.\n- The patch assigning colour spaces in the simple pipeline, previously\n posted separately, included in this series, as the first patch. It\n can still be handled separately; in any case the rest sort of depends\n on it.\n- Setting metadataRequired to false where needed to prevent freezes and\n assertion errors; related to metadata reporting support merged to\n master since v3.\n\nChanges in v3:\n- Significantly reworked, with both functional and clarity improvements.\n The level of guesswork and confusion is hopefully reduced enough now\n to drop the RFC prefix.\n- The number of streams is set to 2 only with software ISP.\n- SimpleCameraData::pipeConfig_ nullptr check patch dropped.\n- PPM/raw file output patch dropped from this series. Let’s handle this\n separately as the patch series is already complex enough.\n\nChanges in v2:\n- Completely reworked.\n- Extended to be able to produce a raw stream together with a processed\n stream.\n\nMilan Zamazal (12):\n libcamera: software_isp: Assign colour spaces in configurations\n libcamera: simple: Set the number of software ISP streams to 2\n libcamera: formats: Add a helper to check for a raw pixel format\n libcamera: formats: Add a helper to check for a raw pixel info\n libcamera: simple: Don't use raw output formats with conversions\n libcamera: simple: Add plain output configurations\n libcamera: simple: Identify requested stream roles\n libcamera: simple: Consider raw output configurations\n libcamera: simple: Validate raw stream configurations\n libcamera: simple: Don't enforce conversion with an added raw stream\n libcamera: simple: Require metadata only when software ISP is used\n libcamera: simple: Make raw streams working\n\n include/libcamera/internal/formats.h | 3 +\n src/libcamera/formats.cpp | 16 ++\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 11 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +-\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 10 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 11 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 7 +-\n src/libcamera/pipeline/simple/simple.cpp | 261 +++++++++++++-----\n 8 files changed, 231 insertions(+), 92 deletions(-)" }