Cover Letter Detail
Show a cover letter.
GET /api/covers/22846/?format=api
{ "id": 22846, "url": "https://patchwork.libcamera.org/api/covers/22846/?format=api", "web_url": "https://patchwork.libcamera.org/cover/22846/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250224185235.43381-1-mzamazal@redhat.com>", "date": "2025-02-24T18:52:30", "name": "[v2,0/5] Fix occasional software ISP assertion error on stop", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "mbox": "https://patchwork.libcamera.org/cover/22846/mbox/", "series": [ { "id": 5016, "url": "https://patchwork.libcamera.org/api/series/5016/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5016", "date": "2025-02-24T18:52:30", "name": "Fix occasional software ISP assertion error on stop", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5016/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/22846/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C3B5C32A9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Feb 2025 18:52:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 810A9686F5;\n\tMon, 24 Feb 2025 19:52:51 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5807861856\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Feb 2025 19:52:49 +0100 (CET)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-479-Ubh24ILnMaWMCOf9BkeAVQ-1;\n\tMon, 24 Feb 2025 13:52:44 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8C04419373D9; Mon, 24 Feb 2025 18:52:43 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.225.60])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A39CC180087D; Mon, 24 Feb 2025 18:52:41 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"FbZst+Pu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1740423168;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=rHGO7oDuvITilIbIcnGDlpIdYb6tJ2najftlJxhZzO4=;\n\tb=FbZst+PudbBi63AMvx6TisfTQt8HgTPdx5/5dGkGcbJdjN22oUpCXnW1qQfmCHLFc9kveE\n\teeYsW4qBEcLdT58CbNEVnwJfXkt41e+Z9M6j5qnwdi66Mg/VJ/amZH8jOuQFHQs0tMovtH\n\t/WGQtYp+sY6i0B+PjiLXBYzOqthE2CY=", "X-MC-Unique": "Ubh24ILnMaWMCOf9BkeAVQ-1", "X-Mimecast-MFC-AGG-ID": "Ubh24ILnMaWMCOf9BkeAVQ_1740423164", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tStanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 0/5] Fix occasional software ISP assertion error on stop", "Date": "Mon, 24 Feb 2025 19:52:30 +0100", "Message-ID": "<20250224185235.43381-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "8eznbE3mleqCribDidSL9wQJC6ebx8FM4EFSV1Own3w_1740423164", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When software ISP is stopped, there can be pending messages in the\nmessage queue that will attempt to call the already stopped IPA,\nresulting in an assertion error like this:\n\n FATAL default soft_ipa_proxy.cpp:456 assertion \"state_ == ProxyRunning\" failed in processStatsThread()\n\nThis patch series fixes the problem and also attempts to prevent other\nproblems related to message handling when or after software ISP is\nstopped.\n\nChanges in v2:\n- The receiver check in Thread::dispatchMessages moved to the right\n place.\n\nMilan Zamazal (5):\n libcamera: software_isp: Emit ispStatsReady only if IPA is running\n libcamera: software_isp: Handle queued output buffers on stop\n libcamera: software_isp: Handle queued input buffers on stop\n libcamera: base: Fix formatting in thread.cpp\n libcamera: software_isp: Modify dispatching messages on stop\n\n include/libcamera/base/thread.h | 3 +-\n .../internal/software_isp/software_isp.h | 3 ++\n src/libcamera/base/thread.cpp | 20 ++++----\n src/libcamera/software_isp/software_isp.cpp | 46 +++++++++++++++++--\n .../libcamera_templates/proxy_functions.tmpl | 2 +-\n 5 files changed, 59 insertions(+), 15 deletions(-)" }