Cover Letter Detail
Show a cover letter.
GET /api/covers/22639/?format=api
{ "id": 22639, "url": "https://patchwork.libcamera.org/api/covers/22639/?format=api", "web_url": "https://patchwork.libcamera.org/cover/22639/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250124215806.158024-1-mzamazal@redhat.com>", "date": "2025-01-24T21:57:51", "name": "[RFC,v2,00/13] Enable raw streams with software ISP", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "mbox": "https://patchwork.libcamera.org/cover/22639/mbox/", "series": [ { "id": 4970, "url": "https://patchwork.libcamera.org/api/series/4970/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4970", "date": "2025-01-24T21:57:51", "name": "Enable raw streams with software ISP", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4970/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/22639/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26B5ABD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 265616855D;\n\tFri, 24 Jan 2025 22:58:30 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 699AB68556\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 22:58:28 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-663-n0xxgWZzMx-SMxf2hHWu3w-1;\n\tFri, 24 Jan 2025 16:58:25 -0500", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS\n\tid 125281801F14 for <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Jan 2025 21:58:25 +0000 (UTC)", "from mzamazal-thinkpadp1gen3.tpbc.com (unknown [10.39.192.49])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id AF1611800344; Fri, 24 Jan 2025 21:58:23 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"bUxWXCDy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1737755907;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=CZFk/zOy0vlnJt5fsSnlTimhoeGuzHc0LPAtzRXtToc=;\n\tb=bUxWXCDyTMIUb2G4B1MJgo0ezkhDnls32KtQoGo4WGmn16Qf31W4ISNbgOoCi8yC123swS\n\td7drBgeZn710FHXAUBLhfjhEmMqtkEvpWa5U2x47d3LKXZJutxf6Yi88e5mAgmYEjVrgje\n\tLWUCE6czBxLnDtDLvAM4XZtqD+asFio=", "X-MC-Unique": "n0xxgWZzMx-SMxf2hHWu3w-1", "X-Mimecast-MFC-AGG-ID": "n0xxgWZzMx-SMxf2hHWu3w", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>", "Subject": "[RFC PATCH v2 00/13] Enable raw streams with software ISP", "Date": "Fri, 24 Jan 2025 22:57:51 +0100", "Message-ID": "<20250124215806.158024-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "eUcxYKZ5q-2sC9WkMsqlRkXsjZYgNK4AZeM7nXlr4JM_1737755905", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This makes raw streams working again in ‘simple’ pipeline when software\nISP is enabled for the given device. At most one raw stream and one\nprocessed stream (possibly both at once) are supported.\n\nAn example ‘cam’ invocation requesting a raw stream rather than a debayered stream:\n\n cam -c1 -C8 -s role=raw,width=1920,height=1080 -Ffile#.raw\n\nOr for both raw and processed streams:\n\n cam -c1 -C8 -s role=raw,width=1920,height=1080,pixelformat=SRGGB8 -s role=viewfinder,width=1920,height=1080,pixelformat=RGB888 -Ffile#\n\nWhen only a raw stream is requested, there are no exposure/gain\nadjustments applied. This could be improved in future, once software\nISP gets a mechanism to gather image statistics without processing and\nusing them to make the adjustments, or once manual exposure controls are\nadded to software ISP. In the meantime, exposure must be changed\nexternally.\n\nA part of the patches is a small change to ‘cam’ PPM file handling, to\nbe able to produce PPM files together with raw files when both processed\nand raw streams are requested.\n\nThe patches are RFC because I’m not sure whether they are implemented\nproperly. It’s also necessary to determine the right balance between\nthe requested functionality (single raw + processed streams should be\nenough for current needs), cleanness of the implementation and the\ncomplexity of the patches.\n\nChanges in v2:\n- Completely reworked.\n- Extended to be able to produce a raw stream together with a processed\n stream.\n\nMilan Zamazal (13):\n libcamera: software_isp: Move a non-loop condition out of the loop\n libcamera: simple: Increase the default number of streams to 2\n libcamera: simple: Don't use raw output formats with conversions\n libcamera: simple: Add plain output configurations to software ISP\n libcamera: simple: Identify requested stream roles\n libcamera: simple: Protect against null maxPipeConfig\n libcamera: simple: Consider raw output configurations\n libcamera: simple: Handle adjusted and raw configurations separately\n libcamera: simple: Don't use conversion with an added raw stream\n libcamera: simple: Make raw streams working\n apps: ppm_writer: Add a missing include\n apps: ppm_writer: Return EIO on I/O errors\n apps: cam: Write raw file if PPM cannot be written\n\n src/apps/cam/file_sink.cpp | 16 +-\n src/apps/common/ppm_writer.cpp | 7 +-\n src/libcamera/pipeline/simple/simple.cpp | 188 ++++++++++++++++----\n src/libcamera/software_isp/software_isp.cpp | 7 +-\n 4 files changed, 168 insertions(+), 50 deletions(-)" }