Cover Letter Detail
Show a cover letter.
GET /api/covers/21425/?format=api
{ "id": 21425, "url": "https://patchwork.libcamera.org/api/covers/21425/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21425/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240930141415.8857-1-naush@raspberrypi.com>", "date": "2024-09-30T14:14:08", "name": "[v2,0/7] Raspberry Pi: Add controls::rpi::ScalerCrops", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/21425/mbox/", "series": [ { "id": 4639, "url": "https://patchwork.libcamera.org/api/series/4639/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4639", "date": "2024-09-30T14:14:08", "name": "Raspberry Pi: Add controls::rpi::ScalerCrops", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4639/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21425/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58490C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Sep 2024 14:14:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53CD263517;\n\tMon, 30 Sep 2024 16:14:00 +0200 (CEST)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1053D63502\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 16:13:58 +0200 (CEST)", "by mail-wr1-x42e.google.com with SMTP id\n\tffacd0b85a97d-37cdab63866so197114f8f.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 07:13:58 -0700 (PDT)", "from naush-laptop.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-37cd56e65c3sm9142524f8f.60.2024.09.30.07.13.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 30 Sep 2024 07:13:56 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"TwsyUmDu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1727705637; x=1728310437;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=B7WPZNdYU2uNOmbeEmCbgZKfWT8isMBstgyiSCZDgXE=;\n\tb=TwsyUmDuw8cvvs9BJF7Tfi625PLYVNJUXdIV9Ti4y6wLGtTiGI5nTJ49Z0XuOVSr2e\n\tA4wwRJxobeNhlvO+HluEJ8bzMYh/+MrMFnfoJQUmhD307/EyuX2mp5+KPQ4u8nTKNONu\n\tUapAEKY/CF6qjcvqSNZ5fxb1GpXC1YfhS3ukr8HiUvMAAf08M2is18ohE2+CnxpT6NR1\n\taisZ+AKphWjkPDpqzDaF1TfqMUEFrT6U0CTE/rQeTEu5l8u2VSIVZ2nZZ8NHkMevfLKN\n\tbccIip4r7Dfthx7k5p2KDKbsor5ekFJGgLRJ4sxOe6TStc6GbJL1XMKm8qlXqdStRddD\n\tuSTw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727705637; x=1728310437;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=B7WPZNdYU2uNOmbeEmCbgZKfWT8isMBstgyiSCZDgXE=;\n\tb=nD9i2qfsm/ryz4FGykOsgh2rUbUQFAQTLGhXWiUpUyK7qBwn1c3/+1RZVKxdSvunxZ\n\tYaSAJygtHdMV6GkdTvPIreJGIBCq5kVp0ddTe10c62mc1RvA8Vl5GTjBvBuuPq8QnBgw\n\tn+NuloCu26BI80AYrNUbHmsQN+1ASuHtvCbh+0FMpBeFXOicpjq3Z8VDjDbl/kYPhsEV\n\tbbLoWbgatBudK3/4o3qaMa638AANyX9+llNP0JtlEeXTJD+fnwXlZg709/8Bh59lyfOC\n\t9rRPr9E8jy0W8rBio6n2lFz5lCjgZlVEaL5wDnaC9JEfyX+rg3TlUlWJuk36/ppWIcTp\n\tOJ+g==", "X-Gm-Message-State": "AOJu0YxictkxJYIa+64NRZhruKOVyiJi53ODHvLUdpHIkhKtTP0ps6qi\n\tSFR/DcvBoPdFgtG6ZY4+PunIGvxKwn8yxNsPIh8KZJSrekI0yevg+fPvQ8ooA8a2fv50uSegzfI\n\tp", "X-Google-Smtp-Source": "AGHT+IHO1LScb776M/5f65RE/hhu+UcQenQzG86y9p/GwIr0mh1tQAQKN0Z88gVhD9qTWlLJ5oZUJQ==", "X-Received": "by 2002:a05:6000:bc2:b0:376:2e3e:e6d4 with SMTP id\n\tffacd0b85a97d-37cde3d36a4mr1871897f8f.5.1727705637109; \n\tMon, 30 Sep 2024 07:13:57 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v2 0/7] Raspberry Pi: Add controls::rpi::ScalerCrops", "Date": "Mon, 30 Sep 2024 15:14:08 +0100", "Message-Id": "<20240930141415.8857-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nApologies for the delay in preparing the second version of this series.\nHopefully I've addressed all the feedback from the first revision, particularly:\n\n- The rpi::ScalerCrops control is not advertised for the VC4/BCM2835 platform.\n This will only be available on the VC5/pisp platform.\n\n- In the control documentation I've noted that this control will be a temporary\n measure until the libcamera API support per-stream controls.\n\n\nThe PISP implementation (available only downstream for now) still needs to\nadapt to this revision, but I'll handle that once this is merged and our\ndownstream tree is rebased.\n\nThanks,\nNaush\n\nNaushir Patuck (7):\n controls: rpi: Add a vendor rpi::ScalerCrops control\n pipeline: rpi: Remove CameraData::scalerCrop_\n pipeline: rpi: Pass crop rectangle as a parameter to\n platformSetIspCrop()\n pipeline: rpi: Introduce CameraData::CropParams\n pipeline: rpi: Track which ISP output is configured for a stream\n pipeline: rpi: Pass ISP output index into platformSetIspCrop()\n pipeline: rpi: Handler controls::rpi::ScalerCrops\n\n src/ipa/rpi/common/ipa_base.cpp | 14 +++\n src/libcamera/control_ids_rpi.yaml | 21 +++++\n .../pipeline/rpi/common/pipeline_base.cpp | 94 +++++++++++++------\n .../pipeline/rpi/common/pipeline_base.h | 26 ++++-\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 17 +++-\n 5 files changed, 136 insertions(+), 36 deletions(-)" }