Cover Letter Detail
Show a cover letter.
GET /api/covers/21376/?format=api
{ "id": 21376, "url": "https://patchwork.libcamera.org/api/covers/21376/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21376/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240926093623.94136-1-umang.jain@ideasonboard.com>", "date": "2024-09-26T09:36:19", "name": "[v8,0/4] rkisp1: Plumb the DW100 dewarper as converter", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/21376/mbox/", "series": [ { "id": 4629, "url": "https://patchwork.libcamera.org/api/series/4629/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4629", "date": "2024-09-26T09:36:19", "name": "rkisp1: Plumb the DW100 dewarper as converter", "version": 8, "mbox": "https://patchwork.libcamera.org/series/4629/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21376/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEE11C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Sep 2024 09:36:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A801C6350F;\n\tThu, 26 Sep 2024 11:36:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED414634F2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Sep 2024 11:36:33 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1AA928D4;\n\tThu, 26 Sep 2024 11:35:04 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vNrT99sa\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1727343305;\n\tbh=qkHungXqD0jng6ZyKemwvyK2JOEGD2OSJ2GHjNAs++M=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=vNrT99saQ33lfb1zwSRUbPTsV4ZMD+1jSq3YwYxmdvyZ+KrwbzDqONAophffEgIbl\n\t9A+LhwERyiQ0cNV2BhoM+GUjKsPZZol1IF+E3BIhJkBkm7k9erHvW/cORGCMTdxKDl\n\t5/J5Kt+7yrDopSyQXXm2l1z4byo0nGQY4Nbmd3nw=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v8 0/4] rkisp1: Plumb the DW100 dewarper as converter", "Date": "Thu, 26 Sep 2024 15:06:19 +0530", "Message-ID": "<20240926093623.94136-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This series intends to support i.MX8MP DW100 dewarper in rkisp1\npipeline handler. It is modelled as a V4L2M2MConverter and has a\nhelper to support scaler crop control. Extensions to the base converter\ninterface has also been done initially in the series.\n\nPatch 1/4 add ability to add features to the Converter interface.\nEach Converter can dictate its own features it can support\n\nPatch 2/4 adds crop feature enumeration and virtual functions and\ngets implemented in the V4L2 M2M converter. \n\nPatch 3/4 prepares the rkisp1 pipeline handler to register controls\nfor the camera, outside of the IPA. The dw100 converter will let us\nsupport scaler crop - which will be registered as one of the camera\ncontrols.\n\nPatch 4/4 plumbs the DW100 as converter in the rkisp1 pipeline handler\n\nSeries is based on top of \n[PATCH] libcamera: v4l2_videodevice: Add getSelection() function\n\nTesting:\n--------\nThe series is tested on i.MX8MP and cam utility, by setting scaler crop\ncontrol via capture script with IMX283 attached to isp0.\n\nChanges in v8:\n- Fix subject to \"rkisp1: Plumb the DW100 dewarper as converter\"\n- Fix documentation in 2/4\n- Drop features_ member variable in 2/4 in V4L2M2MStream class\n- Use V4L2_SEL_TGT_CROP_BOUNDS for querying max crop bound (2/4)\n- Introduce V4L2M2MStream::getSelection() helper as well (2/4)\n- Fix race while setting scalercrop metadata in 4/4\n- Format debug logs in 2/4 and 4/4\n- Reduce indentation in 2/4 for discovering input crop\n\nChanges in v7:\n- Documentation improvements for input crop (1/4)\n- Crop feature now discovered dynamically at construction (2/4)\n- Handling of scaler crop control is deferred. Now scaler\n crop is applied at dewarper after buffer from ISP is ready (4/4)\n- Add explanatory comments about dw100/i.MX8MP platform (4/4)\n- Drop dw100 Converter sub-classing from v6\n- lower indentation (4/4)\n- report scaler crop value for all frames now. (4/4)\n- Use ScopeExitActions on dewarp cleanup paths (4/4)\n- copy updateControls() documentation from IPU3 (3/4)\n\nChanges in v6:\n- clarify crop expectations - set on input side\n- Rename setCrop() to setInputCrop\n- Rename getFeatures() to features()\n- Rename getCropBounds() to inputCropBounds()\n- rename Features::Crop to Features::InputCrop\n- Document crop functionality properly\n- Improve error paths\n- exportsBuffers() between RkISP1Path<>dewarper instead of\n allocateBuffers.\n\nChanges in v5:\n- Return -ENOTSUP for base implementation for virtual setCrop() in 2/5\n- Return configured size for base implemention for virtual getCropBounds\n in 2/5.\n- Fix a bug in getting crop bounds when streams are not configured\n- drop getSelection() V4L2VideoDevices additions from v4. we can get\n bounds by setSelection by setting 1x1 and UINT_MAX x UINT_MAX\n rectangles.\n\nchanges in v4:\n- rework Converter Interface to expose Features\n- Add Crop Feature interface in Converter setCrop and setCropBound\n- Implement cropping in V4L2M2MConverter for V4L2 M2M based converters\n- Introduce useDewarper_ to denote when to use dewarper (simplied code\n reading).\n- Trivial typo fixing.\n\nChanges in v3:\n- Base on top of [2]\n- Model dewarper class as converter, so can be used with Simple\n pipeline-handler/ISI\n\nChanges in v2:\n- Fix raw capture configuration, disable dewarper in that case\n\nUmang Jain (4):\n libcamera: converter: Add interface for feature flags\n libcamera: converter: Add interface to support cropping capability\n libcamera: rkisp1: Prepare for additional camera controls\n libcamera: rkisp1: Plumb the dw100 dewarper as V4L2M2M converter\n\n include/libcamera/internal/converter.h | 19 +-\n .../internal/converter/converter_v4l2_m2m.h | 11 +\n src/libcamera/converter.cpp | 64 ++++-\n .../converter/converter_v4l2_m2m.cpp | 114 +++++++++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 228 +++++++++++++++++-\n 5 files changed, 424 insertions(+), 12 deletions(-)" }