Cover Letter Detail
Show a cover letter.
GET /api/covers/21173/?format=api
{ "id": 21173, "url": "https://patchwork.libcamera.org/api/covers/21173/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21173/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240906120927.4071508-1-mzamazal@redhat.com>", "date": "2024-09-06T12:09:09", "name": "[v6,00/18] Software ISP refactoring", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "mbox": "https://patchwork.libcamera.org/cover/21173/mbox/", "series": [ { "id": 4566, "url": "https://patchwork.libcamera.org/api/series/4566/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4566", "date": "2024-09-06T12:09:09", "name": "Software ISP refactoring", "version": 6, "mbox": "https://patchwork.libcamera.org/series/4566/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21173/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CD76C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Sep 2024 12:09:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 589D0634E5;\n\tFri, 6 Sep 2024 14:09:55 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 185DE633CC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Sep 2024 14:09:52 +0200 (CEST)", "from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-190-oQDlvFNCMky4-jvd8l2Fhw-1;\n\tFri, 06 Sep 2024 08:09:46 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 8E71319560BD; Fri, 6 Sep 2024 12:09:45 +0000 (UTC)", "from nuthatch.redhat.com (unknown [10.45.224.65])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 1D4951956086; Fri, 6 Sep 2024 12:09:42 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Ws0VARC9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1725624591;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=QRsBcdjQdR/1LUjbsTAwtv2eKkaAU0qiD4C4IMYRqvQ=;\n\tb=Ws0VARC91kyVqEGK9sVKRkPaP/HmLnP9QPJ/m4+NalkdzmgHPd29/JPxImjVZ79ghYRW+L\n\tju0CVHXzZhTJsWnEUhogxZ0mOiIWqR1jDBtXbCCIcgvtP4IN/uNmP+DVEFACz8oE6u382Y\n\tCv5GKOQa2NKfbcCBWS+gM/3b3IPOOOc=", "X-MC-Unique": "oQDlvFNCMky4-jvd8l2Fhw-1", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v6 00/18] Software ISP refactoring", "Date": "Fri, 6 Sep 2024 14:09:09 +0200", "Message-ID": "<20240906120927.4071508-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The purpose of this patch series is to bring software ISP code\nstructuring closer to the hardware pipelines. Most notably, the API\naround algorithm.h is used now. This should make software ISP easier to\nunderstand, extend, maintain, and code-share with the other pipelines.\n\nWhat is omitted in the patch series:\n\n- Any bigger or unrelated functional changes. The purpose of this\n series is code restructuring, which is enough already.\n- Stats and params buffers are still used in the original way. Making\n their handling closer to the hardware pipelines will be a subject of\n followup patches. This series is a preparation step for that.\n- Any IPA code sharing with hardware pipelines. If there is an\n opportunity for this, it can be addressed in followup patches.\n\nAvailable in git at\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/pdm-algorithm\n\nPending, more input from reviewers needed (see v3 review discussions):\n- Should `frame' argument name be kept for consistency with other\n pipelines for now or already renamed to something like\n `sequenceNumber'?\n- Should black level be stored as a 0..1 number or a pixel value\n number?\n\nChanges in v6:\n\n- Use data->swIsp_ only if it is defined.\n- IPASoftSimple::prepare renamed to IPASoftSimple::fillParamsBuffer.\n- soft_ipa_interface.h include moved to the right patch.\n- Unneeded includes in algorithm *.h files dropped.\n- Duplicate kGammaLookupSize constant removed and gammaTable.size() used\n instead.\n- Gamma algorithm merged to Lut algorithm.\n- Duplicate logging of AWB gains removed.\n- Miscellaneous formatting and cosmetic changes suggested by Laurent.\n\nChanges in v5:\n- Construction of color lookup tables moved to a separate algorithm.\n\nChanges in v4:\n- Removed the mistakenly included patches by Umang.\n- IPASoftInterface::prepare() is async now.\n- IPAConfigInfo definition moved to an earlier patch to avoid\n unnecessary confusion.\n- colors.cpp/h split to gamma and awb.\n- Using the right black level variable in Agc::process.\n- Documentation of the newly introduced SwStatsCpu::finishFrame\n arguments added.\n- Formatting changes as requested.\n- A forgotten obsolete source code comment removed.\n- Improvements to some commit messages.\n\nChanges in v3:\n- SoftwareIsp::queueRequest changed to async.\n- IPAActiveState docstring reworded.\n- Minor formatting fixes.\n\nChanges in v2:\n- Several cosmetic changes and patch arrangement problems pointed out by\n Umang applied.\n- Added ipa_context.cpp, as a documentation file for ipa_context.h.\n- Added a clarification source comment why SoftwareIsp::queueBuffers needs\n to get the frame number as a separate argument.\n- core_ipa_interface.h no longer included in module.h.\n- The context used by \"14/19 Move black level to an algorithm module\"\n was changed and the black level changes tracking was put closer to the\n pre-refactoring version, which makes more sense.\n\nMilan Zamazal (18):\n libcamera: software_isp: Remove superfluous includes\n libcamera: software_isp: Move BlackLevel to libcamera::ipa::soft\n libcamera: software_isp: Define skeletons for IPA refactoring\n libcamera: software_isp: Let IPASoftSimple inherit Module\n libcamera: software_isp: Make stats frame and buffer aware\n libcamera: software_isp: Remove final dots in debayer.cpp docstrings\n libcamera: software_isp: Track and pass frame ids\n libcamera: software_isp: Create algorithms\n libcamera: software_isp: Call Algorithm::configure\n libcamera: software_isp: Call Algorithm::queueRequest\n libcamera: software_isp: Call Algorithm::prepare\n libcamera: software_isp: Call Algorithm::process\n libcamera: software_isp: Move black level to an algorithm module\n libcamera: software_isp: Move color handling to an algorithm module\n libcamera: software_isp: Use floating point for color parameters\n libcamera: software_isp: Use DelayedControls\n libcamera: software_isp: Move exposure+gain to an algorithm module\n libcamera: software_isp: Update black level only on exposure changes\n\n .../internal/software_isp/software_isp.h | 15 +-\n include/libcamera/ipa/soft.mojom | 12 +-\n src/ipa/simple/algorithms/agc.cpp | 139 +++++++++\n src/ipa/simple/algorithms/agc.h | 33 ++\n src/ipa/simple/algorithms/algorithm.h | 22 ++\n src/ipa/simple/algorithms/awb.cpp | 69 +++++\n src/ipa/simple/algorithms/awb.h | 32 ++\n src/ipa/simple/algorithms/blc.cpp | 78 +++++\n src/ipa/simple/algorithms/blc.h | 36 +++\n src/ipa/simple/algorithms/lut.cpp | 81 +++++\n src/ipa/simple/algorithms/lut.h | 35 +++\n src/ipa/simple/algorithms/meson.build | 8 +\n src/ipa/simple/black_level.cpp | 88 ------\n src/ipa/simple/black_level.h | 29 --\n src/ipa/simple/data/uncalibrated.yaml | 5 +\n src/ipa/simple/ipa_context.cpp | 102 +++++++\n src/ipa/simple/ipa_context.h | 69 +++++\n src/ipa/simple/meson.build | 9 +-\n src/ipa/simple/module.h | 30 ++\n src/ipa/simple/soft_simple.cpp | 283 ++++++------------\n src/libcamera/pipeline/simple/simple.cpp | 48 ++-\n src/libcamera/software_isp/TODO | 39 ---\n src/libcamera/software_isp/debayer.cpp | 51 ++--\n src/libcamera/software_isp/debayer.h | 2 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 9 +-\n src/libcamera/software_isp/debayer_cpu.h | 2 +-\n src/libcamera/software_isp/software_isp.cpp | 43 ++-\n src/libcamera/software_isp/swstats_cpu.cpp | 6 +-\n src/libcamera/software_isp/swstats_cpu.h | 4 +-\n 29 files changed, 955 insertions(+), 424 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/agc.cpp\n create mode 100644 src/ipa/simple/algorithms/agc.h\n create mode 100644 src/ipa/simple/algorithms/algorithm.h\n create mode 100644 src/ipa/simple/algorithms/awb.cpp\n create mode 100644 src/ipa/simple/algorithms/awb.h\n create mode 100644 src/ipa/simple/algorithms/blc.cpp\n create mode 100644 src/ipa/simple/algorithms/blc.h\n create mode 100644 src/ipa/simple/algorithms/lut.cpp\n create mode 100644 src/ipa/simple/algorithms/lut.h\n create mode 100644 src/ipa/simple/algorithms/meson.build\n delete mode 100644 src/ipa/simple/black_level.cpp\n delete mode 100644 src/ipa/simple/black_level.h\n create mode 100644 src/ipa/simple/ipa_context.cpp\n create mode 100644 src/ipa/simple/ipa_context.h\n create mode 100644 src/ipa/simple/module.h" }