Cover Letter Detail
Show a cover letter.
GET /api/covers/20192/?format=api
{ "id": 20192, "url": "https://patchwork.libcamera.org/api/covers/20192/?format=api", "web_url": "https://patchwork.libcamera.org/cover/20192/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240603140806.90045-1-stefan.klug@ideasonboard.com>", "date": "2024-06-03T14:06:27", "name": "[v3,0/3] libcamera: Add gamma control for rkisp1", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/20192/mbox/", "series": [ { "id": 4354, "url": "https://patchwork.libcamera.org/api/series/4354/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4354", "date": "2024-06-03T14:06:27", "name": "libcamera: Add gamma control for rkisp1", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4354/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/20192/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B61A9BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 3 Jun 2024 14:08:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97307634CA;\n\tMon, 3 Jun 2024 16:08:27 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C0FC61A3B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 3 Jun 2024 16:08:25 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6067:153a:95aa:2e07])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F8D1BC0;\n\tMon, 3 Jun 2024 16:08:18 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NIXSwNjZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717423698;\n\tbh=9Okq4pbEwsV9TR2BYOEpxjfR2Lxx7pan6cDMgvHe43s=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NIXSwNjZQOS/EQkgwlzE/l4OV2foLxu+2OdwhhhOzxoOlZBy1llAgU9lSdl96lSUi\n\tpo1uGSLIxp4WWGb/rggJe/DK15ZsjywzYrJHg7dMApPmrr37AYdGeRCrRqttH0KS5X\n\tsAhJJBvYUiKo520a7ihLk1glBK0zoU7hA1yTnfYM=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 0/3] libcamera: Add gamma control for rkisp1", "Date": "Mon, 3 Jun 2024 16:06:27 +0200", "Message-ID": "<20240603140806.90045-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This patchset adds a gamma algorithm and the corresponding control for rkisp1.\nA camera gamma of roughly 2.2 is necessary to produce correct output images on\na standard monitor and to comply with sRGB.\n\nFurther information is available here:\nhttps://en.wikipedia.org/wiki/SRGB\nhttps://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n\nv2 -> v3:\n- Renamed the algorithm to GammaOutCorrection which seems to be more in line\n with the other algorithms. (This got clearer to me after writing the schema file)\n- Added ability to configure the default gamma value in the tuning file\n- Squashed patch 1/4 and 4/4 to make it easier to review\n- Applied feedback from reviews\n\nv1 -> v2:\n- fixed some stylistic issues from review\n- added gamma control only if algorithm is present\n\nStefan Klug (3):\n libcamera: Add gamma control id\n ipa: rkisp1: Fix algorithm controls vanish after configure\n ipa: rkisp1: Add GammaOutCorrection algorithm\n\n src/ipa/rkisp1/algorithms/goc.cpp | 161 ++++++++++++++++++++++++++\n src/ipa/rkisp1/algorithms/goc.h | 48 ++++++++\n src/ipa/rkisp1/algorithms/meson.build | 1 +\n src/ipa/rkisp1/ipa_context.h | 4 +\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/libcamera/control_ids_core.yaml | 7 ++\n 6 files changed, 222 insertions(+), 1 deletion(-)\n create mode 100644 src/ipa/rkisp1/algorithms/goc.cpp\n create mode 100644 src/ipa/rkisp1/algorithms/goc.h" }