Cover Letter Detail
Show a cover letter.
GET /api/covers/20112/?format=api
{ "id": 20112, "url": "https://patchwork.libcamera.org/api/covers/20112/?format=api", "web_url": "https://patchwork.libcamera.org/cover/20112/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240529070248.12186-1-umang.jain@ideasonboard.com>", "date": "2024-05-29T07:02:44", "name": "[v2,0/4] libcamera: converter: Replace usage of stream index by Stream pointer", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/20112/mbox/", "series": [ { "id": 4331, "url": "https://patchwork.libcamera.org/api/series/4331/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4331", "date": "2024-05-29T07:02:44", "name": "libcamera: converter: Replace usage of stream index by Stream pointer", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4331/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/20112/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10498BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 29 May 2024 07:03:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 917A3634B2;\n\tWed, 29 May 2024 09:02:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F305261A46\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 29 May 2024 09:02:57 +0200 (CEST)", "from fedora.local (unknown\n\t[IPv6:2409:4055:4e99:4251:f523:b915:4362:f847])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9BFC866F;\n\tWed, 29 May 2024 09:02:52 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DYQN1Gsp\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716966174;\n\tbh=NF+ph4HFAce3hJk0tVK+tAFpcdYKDl0jEH2UzGNB0Ag=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=DYQN1GspE/+3nlV0dcRDIckMzSgd9wD7c0uXl8r5Xd4auoPeBAxFxRWNkv09Z/xj1\n\toEa+cG0z60AirTtq0i8ifdpX/k8SzG3Rz67o6ktT/TBQ4sY4T0aGBb7HuesjuB+OD1\n\tQjKFahJOt2/bID9l60N+ZnDHEXk99iCetjiDX7KE=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tAndrey Konovalov <andrey.konovalov@linaro.org>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[PATCH v2 0/4] libcamera: converter: Replace usage of stream index\n\tby Stream pointer", "Date": "Wed, 29 May 2024 12:32:44 +0530", "Message-ID": "<20240529070248.12186-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The converter interface uses the unsigned int output stream index to map\nto the output frame buffers. This is cumbersome to implement new\nconverters because one has to keep around additional book keeping\nto track the streams with their correct indexes.\n\nThis patch (still an RFC) intends to drop stream index usage.\nThe index is replaced by Stream pointer. This is convenient since\nStream pointers are easily accessible at configuration time (from\nStreamConfiguration) and from Request objects.\n\nThe v4l2_converter_m2m and simple pipeline handler are adapt to\nuse the new interface. This work roped in software ISP as well,\nwhich also seems to use indexes (although it doesn't implement converter\ninterface) because of a common conversionQueue_ queue used for\nconverter_ and swIsp_.\n\nPatch 1/4 and 2/4 drop redundant validation of outputs std::map<>.\n\nPatch 3/4 renames private class V4L2M2MConverter::Stream to\nV4L2M2Mconverter::V4L2M2MStream\n\nPatch 4/4 replaces the stream index usage from converter interface and\nsoft isp.\n\nchanges in v2:\n- Split out patches 1/4 and 2/4 to tackle validation/sanity check\n- Rename V4L2M2MConverter::Stream to V4L2M2Mconverter::V4L2M2MStrea\n\nUmang Jain (4):\n converter: converter_v4l2_m2m: Rectify streams sanity check\n libcamera: software_isp: Drop unnecessary sanity check\n converter: converter_v4l2_m2m: Rename private Stream class\n libcamera: converter: Replace usage of stream index by Stream pointer\n\n include/libcamera/internal/converter.h | 5 +-\n .../internal/converter/converter_v4l2_m2m.h | 13 ++--\n .../internal/software_isp/software_isp.h | 5 +-\n .../converter/converter_v4l2_m2m.cpp | 77 ++++++++++---------\n src/libcamera/pipeline/simple/simple.cpp | 14 ++--\n src/libcamera/software_isp/software_isp.cpp | 22 ++----\n 6 files changed, 67 insertions(+), 69 deletions(-)" }