Cover Letter Detail
Show a cover letter.
GET /api/covers/19945/?format=api
{ "id": 19945, "url": "https://patchwork.libcamera.org/api/covers/19945/?format=api", "web_url": "https://patchwork.libcamera.org/cover/19945/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240424234224.9658-1-laurent.pinchart@ideasonboard.com>", "date": "2024-04-24T23:42:18", "name": "[v1,0/6] vimc scaling improvements", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/19945/mbox/", "series": [ { "id": 4271, "url": "https://patchwork.libcamera.org/api/series/4271/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4271", "date": "2024-04-24T23:42:18", "name": "vimc scaling improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4271/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/19945/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C0C1C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Apr 2024 23:42:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F7C0633FD;\n\tThu, 25 Apr 2024 01:42:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C36BC61A94\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Apr 2024 01:42:31 +0200 (CEST)", "from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D06EB1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 25 Apr 2024 01:41:39 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VSmm0hv0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714002099;\n\tbh=l7wUfn6VwyvUPUVegPb+myygSqGHy6bh0tHxQKHHqm0=;\n\th=From:To:Subject:Date:From;\n\tb=VSmm0hv0ehWe17iOOY4AiXXrwe41NzREcqr3c9pNkFAmj475UQM0oWNgSdFCmMjY6\n\tlQRZT3vz7orJdM6DiTIZRG2GkanT5zkRI+2bi/U//gEWW3KICSNccJkTRCTINrIZC7\n\toQXKwK+0OFZeQgD9jZbpCgfoG1TRx9T5wAN1sP9c=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1 0/6] vimc scaling improvements", "Date": "Thu, 25 Apr 2024 02:42:18 +0300", "Message-ID": "<20240424234224.9658-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis series improves the vimc pipeline handler to avoid the weird\nalignment constraints related to the vimc scaler on recent kernels.\n\nStarting in v5.16, the vimc scaler doesn't hardcoded a x3 scaling ratio,\nbut makes the scaling configurable by userspace through the sink pad\ncrop rectangle. Take advantage of this feature to lift the strange\nalignment to a multiple of 6 for the stream output size. This allows\ncapturing all common display resolutions from the vimc pipeline handler,\nwhich is handy to test the DRM sink in the cam application.\n\nThe improvement, in patch 6/6, breaks 4 unit tests. The series starts\nwith improvements and fixes to the tests to avoid those breakages\n(patches 1/6 to 5/6), before changing the vimc pipeline handler\nbehaviour. Those test improvements would in my opinion make sense even\nwithout patch 6/6, as they fix a race condition (3/6) or accelerate the\ntest runs (1/6, 4/6 and 5/6) on fast machines.\n\nThe series has been tested with the unit tests, running on my\ndevelopment machine, in a local VM, and in the gitlab.freedesktop.org CI\nVM.\n\nLaurent Pinchart (6):\n test: camera: Increase timeout for vimc capture tests\n test: fence: Turn class member variable into local variable\n test: fence: Fix race condition\n test: fence: Increase timeout for fence test\n test: v4l2_videodevice: Increase timeout for vimc capture tests\n pipeline: vimc: Don't hardcode scaling factor with recent kernels\n\n src/libcamera/pipeline/vimc/vimc.cpp | 47 +++++++++++++++++--------\n test/camera/buffer_import.cpp | 21 +++++++----\n test/camera/capture.cpp | 22 +++++++-----\n test/fence.cpp | 42 +++++++++++-----------\n test/v4l2_videodevice/capture_async.cpp | 11 +++---\n 5 files changed, 90 insertions(+), 53 deletions(-)\n\n\nbase-commit: fb74bb7df66b96dbe28702155cddfc96a1b30f78" }