Cover Letter Detail
Show a cover letter.
GET /api/covers/19305/?format=api
{ "id": 19305, "url": "https://patchwork.libcamera.org/api/covers/19305/?format=api", "web_url": "https://patchwork.libcamera.org/cover/19305/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20231212115046.102726-1-andrey.konovalov@linaro.org>", "date": "2023-12-12T11:50:39", "name": "[libcamera-devel,RFC,v2,0/7] libcamera: introduce Software ISP and Software IPA", "submitter": { "id": 25, "url": "https://patchwork.libcamera.org/api/people/25/?format=api", "name": "Andrey Konovalov", "email": "andrey.konovalov@linaro.org" }, "mbox": "https://patchwork.libcamera.org/cover/19305/mbox/", "series": [ { "id": 4114, "url": "https://patchwork.libcamera.org/api/series/4114/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4114", "date": "2023-12-12T11:50:39", "name": "libcamera: introduce Software ISP and Software IPA", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4114/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/19305/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C48F1BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 Dec 2023 11:51:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA20C62B32;\n\tTue, 12 Dec 2023 12:51:14 +0100 (CET)", "from mail-lf1-x134.google.com (mail-lf1-x134.google.com\n\t[IPv6:2a00:1450:4864:20::134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 07E34629BD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Dec 2023 12:51:13 +0100 (CET)", "by mail-lf1-x134.google.com with SMTP id\n\t2adb3069b0e04-50c222a022dso5989943e87.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Dec 2023 03:51:12 -0800 (PST)", "from Lat-5310.. ([87.116.161.153]) by smtp.gmail.com with ESMTPSA\n\tid\n\ttx17-20020a1709078e9100b00a1b75e0e061sm6213188ejc.130.2023.12.12.03.51.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 12 Dec 2023 03:51:11 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1702381874;\n\tbh=LAXwjRZ5b+9xXTYr6AdLk2aQxO96bQdvdoo7bmAAeBE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=zZ9ZReuNd2l9FG5OHd8RA/TgTj8S3oTLKPV3WuNiQVYcMBK1uKj5kdkmp9/4KOyHh\n\tHgEHRgpyvJ98hYL5Pn9fzbNaU89WgiGS+PZ0PEpjY9peomYSQA4+d04KiQaEOxMAkK\n\tHS9YxpLO9tSgkFlxfP17JE0LYe2fCxXF6q9sbsZleuxXfNOKlWb6zfchu4+Vw0ZEOJ\n\tWWJw8ziHJ/PTL8zPiMunzTX5ZKA/I7nmH+/MSWReEnuPVmKUWpjEhGfnwJ3CIXs5Mt\n\tytMU8yjPjFBrDeP5PT2TX+XAHd2kXDqO50LaS3YuBRAXo3vn4ukMf5zZ9AOVBzU3wO\n\tO0JzUeCHwKv9w==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1702381872; x=1702986672;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=qohYS+7OEys3DNnBs9zpd/ElDPXcE+JR4ISwmV7P3Og=;\n\tb=M2SMZHCTVikD0eOlAHy9Nro4iEPmU8PHBuMSy03g/4CAjvdf/Ljaxp1BsWe3ypzyC+\n\t7mNcTQA/sy9k8pAvZ/C1HBSj9tHjgTuhMW/AEmuFVYxJqTqAeV/Hw8djtOOQckfg/03Q\n\tY/q5v7dK1+2ABNsjsvSiEptxIz7XV3EiJOtyiPtOvBznrztCsw5JYB4SgM40rmOySdc7\n\tlT7BqikQOz6FNtuscRcivo53EpASIWfgVpv9UuqTpU1qYYAG2dMaD/9fIZGEY6M8HY0C\n\tk3O1NTMMGRNbQj36GHXF1qN899yYSsCegZYqYCQ4jyJhjVmKn0/O5vwoyTvEAN1QxgaY\n\t0tqg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=linaro.org\n\theader.i=@linaro.org header.b=\"M2SMZHCT\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1702381872; x=1702986672;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=qohYS+7OEys3DNnBs9zpd/ElDPXcE+JR4ISwmV7P3Og=;\n\tb=GNIQzi5JZBNCAMCsfWAxuA4txlZ5GIVw29Cd2eaQYUSvhieWGk5yoWfHxaLp9/kj7q\n\tgrquriAwbrAms1cMUA1jcQ7iuN6IMqcIzbs4y3VH1icTzsV/FBh2AQWxsr9/5Yn7me8c\n\t1eZsL5ljkotfQERRi9VtI8GZPfBNptIH77laIuO87E7V4sZbNVx1tYojdEHEluN6C8kA\n\thvoW/28ztADDvLFzg2zlVUi/U3eaBj4CSnfaARjY5MYdO6ml0D7Y4EF9LCn5F/9WdcLl\n\tg/pLJQ0bx5Iup2ahDqGYsiEVAL1WNsJ4lwYFEfHbahBaxelqF+604LVGkCgWOaDiruvm\n\tPsug==", "X-Gm-Message-State": "AOJu0Yzn8XyS1QUNNXMgYmkUrxUfHutLjYxvUSSxmZe4kQDA80L0U6ex\n\tya7Mo1EMlQ9URW2tzJZN8FChUUK7OdtrSe5ptOg=", "X-Google-Smtp-Source": "AGHT+IFjUlj6tBPrsOxAB6wAn1fsXhCk+cvM3KeNiT9f+EQdFIsi26zAiVHuQ0Asgl0UGRSyxsZ7Ug==", "X-Received": "by 2002:a05:6512:401b:b0:50d:3b9c:f174 with SMTP id\n\tbr27-20020a056512401b00b0050d3b9cf174mr2781424lfb.108.1702381872177; \n\tTue, 12 Dec 2023 03:51:12 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 Dec 2023 14:50:39 +0300", "Message-Id": "<20231212115046.102726-1-andrey.konovalov@linaro.org>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH v2 0/7] libcamera: introduce Software\n\tISP and Software IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Andrey Konovalov via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Andrey Konovalov <andrey.konovalov@linaro.org>", "Cc": "mripard@redhat.com, g.martti@gmail.com, t.langendam@gmail.com,\n\tsrinivas.kandagatla@linaro.org, pavel@ucw.cz,\n\tbryan.odonoghue@linaro.org, admin@dennisbonke.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Here is a draft implementation of Software ISP and Software IPA\nwhich provide debayering and implementation of image processing\nalgorithms for systems without a hardware ISP, or in cases when\nthere are no public drivers for the hardware ISP present in the\nsystem.\n\nThe implementation of the Software ISP is a reference one.\nA naive AWB alorithm is implemented as part of a function which\ndoes debayering and statistics calculations - the algorithm part\nis to be moved to the IPA in the next version of the patch set.\nAnd for debayering itself there is already a more efficient\nimplementation by Hans de Goede. This patch set is currently using\nthe earlier debayering implementation as it is less lines of code\nand is OK for the initial discussion.\nOnly RAW10P format from the sensor is currently supported, but\nother debayering functions can be easily added (which of them to\ncall is decided based on the input format).\n\nThe Software IPA has only auto exposure and AGC. For the AGC\nthe analogue gain control of the camera sensor is used (if\navailable). The algorithm is very much simplified, and is\nmostly included as a reference code.\n\nThe 6th patch renames some variables in the simple pipeline\nhandler for the Software ISP to use the same buffer handling\ncode as the Converter currently does. This lets one to\navoid adding extra code to the pipeline handler, but also\nmakes the Software ISP and the Converter mutually exclusive.\n\nThe Software ISP / IPA are intended to be used with the simple\npipeline handler. The pipeline handler doesn't interact with\nthe Software IPA directly - the Software IPA is hidden behind\nthe Software ISP interface. To use the Software ISP the build\nmust be configured with\n -Dpipelines=simple/linaro -Dipas=simple/linaro\nand the Converter must not be used (the latter is hardcoded\nin the simple pipeline handler).\nIf the build is configured with just\n -Dpipelines=simple\nthe Software ISP / IPA are not used, and the simple pipeline\nhandler works in the same way as without this patchset.\n\n\"linaro\" in the\n -Dpipelines=simple/linaro -Dipas=simple/linaro\nis the name of the Software ISP / IPA implementation.\n -Dpipelines=simple/<something else> -Dipas=simple/<something else>\nshould work too if another implementation were added. What\nimplementation to use is the build time choice, only one\nimplementation is included into the build.\n\nThis patch set uses SharedMemObject class used by the RPi pipeline\nhandler - the second patch in the series moves the header file\nto a common directory.\n\nThis patch set has been tested on Qualcomm RB5 board with\na mezzanine board equipped with RPi camera v2 (not the\nstandard RB5 camera mezzanine).\n\ngit branch for the patch set v2:\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v03\n\nv1 of the patch set:\nhttps://patchwork.libcamera.org/cover/19262/\n\nChanges in v2 vs v1:\n- patches are restructured and reordered\n- the Software IPA is hidden behind the Software ISP interface. The\n pipeline handler doesn't interact with the Software IPA directly\n- instantiation of the Software ISP / IPA is configurable (at build\n time)\n- comment explaining the implementation limitations is added to\n SwIspLinaro::IspWorker::debayerRaw10P()\n\nAndrey Konovalov (7):\n libcamera: introduce SoftwareIsp class\n libcamera: internal: Move SharedMemObject class to a common directory\n libcamera: ipa: add Soft IPA common files\n libcamera: ipa: Soft IPA: add a Soft IPA implementation\n libcamera: software_isp: add SwIspLinaro implementation of SoftwareIsp\n libcamera: pipeline: simple: rename converterBuffers_ and related vars\n libcamera: pipeline: simple: enable use of Soft ISP and Soft IPA\n\n include/libcamera/internal/meson.build | 3 +\n .../libcamera/internal}/shared_mem_object.h | 4 -\n include/libcamera/internal/software_isp.h | 106 ++++\n .../internal/software_isp/meson.build | 6 +\n .../internal/software_isp/statistics-linaro.h | 17 +\n .../internal/software_isp/swisp_linaro.h | 117 ++++\n include/libcamera/ipa/meson.build | 1 +\n include/libcamera/ipa/soft.mojom | 27 +\n meson_options.txt | 3 +-\n src/ipa/simple/common/meson.build | 17 +\n src/ipa/simple/common/soft_base.cpp | 66 ++\n src/ipa/simple/common/soft_base.h | 47 ++\n src/ipa/simple/linaro/data/meson.build | 9 +\n src/ipa/simple/linaro/data/soft.conf | 3 +\n src/ipa/simple/linaro/meson.build | 26 +\n src/ipa/simple/linaro/soft_linaro.cpp | 210 +++++++\n src/ipa/simple/meson.build | 12 +\n src/libcamera/meson.build | 2 +\n src/libcamera/pipeline/simple/simple.cpp | 165 +++--\n src/libcamera/software_isp.cpp | 62 ++\n src/libcamera/software_isp/meson.build | 20 +\n src/libcamera/software_isp/swisp_linaro.cpp | 589 ++++++++++++++++++\n 22 files changed, 1455 insertions(+), 57 deletions(-)\n rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (98%)\n create mode 100644 include/libcamera/internal/software_isp.h\n create mode 100644 include/libcamera/internal/software_isp/meson.build\n create mode 100644 include/libcamera/internal/software_isp/statistics-linaro.h\n create mode 100644 include/libcamera/internal/software_isp/swisp_linaro.h\n create mode 100644 include/libcamera/ipa/soft.mojom\n create mode 100644 src/ipa/simple/common/meson.build\n create mode 100644 src/ipa/simple/common/soft_base.cpp\n create mode 100644 src/ipa/simple/common/soft_base.h\n create mode 100644 src/ipa/simple/linaro/data/meson.build\n create mode 100644 src/ipa/simple/linaro/data/soft.conf\n create mode 100644 src/ipa/simple/linaro/meson.build\n create mode 100644 src/ipa/simple/linaro/soft_linaro.cpp\n create mode 100644 src/ipa/simple/meson.build\n create mode 100644 src/libcamera/software_isp.cpp\n create mode 100644 src/libcamera/software_isp/meson.build\n create mode 100644 src/libcamera/software_isp/swisp_linaro.cpp" }