Cover Letter Detail
Show a cover letter.
GET /api/covers/18350/?format=api
{ "id": 18350, "url": "https://patchwork.libcamera.org/api/covers/18350/?format=api", "web_url": "https://patchwork.libcamera.org/cover/18350/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>", "date": "2023-03-07T11:48:00", "name": "[libcamera-devel,v3,0/4] libcamera: rkisp1: Fix generateConfiguration", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/18350/mbox/", "series": [ { "id": 3792, "url": "https://patchwork.libcamera.org/api/series/3792/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3792", "date": "2023-03-07T11:48:00", "name": "libcamera: rkisp1: Fix generateConfiguration", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3792/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/18350/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3EC40BDE17\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Mar 2023 11:48:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7D614626A7;\n\tTue, 7 Mar 2023 12:48:20 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBDC46265E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Mar 2023 12:48:18 +0100 (CET)", "from uno.homenet.telecomitalia.it\n\t(host-79-47-54-87.retail.telecomitalia.it [79.47.54.87])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 014514AD;\n\tTue, 7 Mar 2023 12:48:17 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1678189700;\n\tbh=gPbj4tNie2V0t8inWSQQ8KZQI/ggj3xjYG89FO0VtAQ=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=fPk2JMte/SwcDeNpiISviLGR6SLUYoWtGkvwRb0+59a6NZJhE2LJ2ebBWaa+oLWcg\n\tOCoo52pRktg7eD445tl94kiiDV2XgvuyhNasj73G3Tk58M6dP59Tj2BO6rIbf6s6q/\n\tWTUx1hsxTiRJXmK5mU45c9Is5F5NTAWu79ngJTBrHx1OsrJ9CvgY21ldUnBaV/xBib\n\tQb4teZeT8PD0dRPkajqp5HUDH6QGPOuToGYvZ5jaQxq6oTF54PnOEfBkdOcYrPnnny\n\tEcWseBw5Gm6F1C13gjZJ3VuAr5LgZPbbRMX1396OSfEuIF5pbXx9d4LA0FtQUKrG0m\n\tQNaUBdNmkv9Ag==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1678189698;\n\tbh=gPbj4tNie2V0t8inWSQQ8KZQI/ggj3xjYG89FO0VtAQ=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=rJ5LSZuZanpSlhgpthrqgn9CeN1dVg8phFuuzqwUqCGwvITzvhpS1Glo0JlnohVpF\n\twSeqxJhG4MbSFJcXpbK7dep37AzFjIdi/hi6edWPEhvGhnYmz8nThSp9VUisJsC45x\n\tTMfa+JXkDxyYE7cPVxpE3DpggHhsHIGoSpAFdGnM=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rJ5LSZuZ\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 7 Mar 2023 12:48:00 +0100", "Message-Id": "<20230307114804.42291-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 0/4] libcamera: rkisp1: Fix\n\tgenerateConfiguration", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, libcamera@luigi311.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The series started with bug 180:\nhttps://bugs.libcamera.org/show_bug.cgi?id=180\n\nwhich reports how using the self-path for generating a configuration\nfor a single stream results in only StreamFormats up to 1920x1920\nto be produced.\n\nI have then noticed how the current implementation of\nRkISP1Path::generateConfiguration() could produce unusual sizes, such as\n1920x1432 in case the sensor's resolution is larger than the maximum supported\n1920x1920 output.\n\nFinally, if StillCapture is requested, make sure it is assigned to the main\npath in RkISP1::generateConfiguration() to make sure it can produce images\nin full resolution.\n\nTested on Pinephone Pro with imx258 camera.\n\nUpdated branch jmondi/pinephonepro-af on\nhttps://git.libcamera.org/libcamera/jmondi/libcamera.git\n\nv2->v3:\n- Add review tags\n- Improve 3/4 as suggested by Paul\n\nv1->v2:\n- Enumerate StreamFormats for all the available size and not limited to the\n current output size. This allows to enumerate higher resolutions even if the\n desired role has a smaller resolution.\n\n In example:\n gst-launch-1.0 libcamerasrc camera-name=\"/base/i2c\\@ff110000/camera\\@1a\" ! 'video/x-raw,format=NV12,width=4208,height=3120' ! glimagesink\n\n which used to fail now works correctly\n\n- Enumerate all the RAW sizes the sensor can produce but only if the requested\n role is StreamRole::Raw\n\n\nJacopo Mondi (4):\n libcamera: rkisp1: Generate config using main path\n libcamera: rkisp1: Assign sizes to roles\n libcamera: rkisp1: Reserve main path for StillCapture\n libcamera: rkisp1: Fix enumeration of RAW formats\n\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 30 ++++++++++++-------\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 29 +++++++++++++++---\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 1 +\n 3 files changed, 46 insertions(+), 14 deletions(-)\n\n--\n2.39.0" }