Cover Letter Detail
Show a cover letter.
GET /api/covers/17851/?format=api
{ "id": 17851, "url": "https://patchwork.libcamera.org/api/covers/17851/?format=api", "web_url": "https://patchwork.libcamera.org/cover/17851/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221124025133.17875-1-laurent.pinchart@ideasonboard.com>", "date": "2022-11-24T02:51:24", "name": "[libcamera-devel,v4,0/9] Add Bayer format support for RkISP1", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/17851/mbox/", "series": [ { "id": 3634, "url": "https://patchwork.libcamera.org/api/series/3634/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3634", "date": "2022-11-24T02:51:24", "name": "Add Bayer format support for RkISP1", "version": 4, "mbox": "https://patchwork.libcamera.org/series/3634/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/17851/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C6A2BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Nov 2022 02:51:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6721F6331B;\n\tThu, 24 Nov 2022 03:51:52 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 94F41603CE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Nov 2022 03:51:50 +0100 (CET)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1698496\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Nov 2022 03:51:49 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1669258312;\n\tbh=7j+J0hN5+fPe5zoNQarr5dJXIpzVDMvZrG75KMruB7s=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=bj15OiRbXGFBw2XEysJMV8yk8eSA90u/pjrZJv9H5k7ILpYbgDgkzGu/WjKRItFuo\n\tnV+ZHPdkDpCFdVz+YVzeUiERcjAG/DU9UryHBymdTF/9JvPybaNuQBBxCd5Y4jHNv4\n\t9zry/6ohWsAGo++zMcM+Ue7cfGWzwHR7w3KReCyTZGcOn3kDM5Dl13KuJIwiOMSLk4\n\tVbrOdcKhlip9IiaohmjstNGCwbnXJ26AUladUHo8pwEmqiPZVhfY0CgJOVvNVO4Fj6\n\tBY37iYH2asy7jX4ZAXTvO6SdELyWQeFiMFprO3fvDHz1HwfCyevGR0okcc1MN5xSj7\n\tu5jN9rzRtj84w==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1669258310;\n\tbh=7j+J0hN5+fPe5zoNQarr5dJXIpzVDMvZrG75KMruB7s=;\n\th=From:To:Subject:Date:From;\n\tb=HDz3je+0NlvBTEjZrZHyn7O+hhWdUMhEF4rdpMWMwb2fQCoBDchxZtWIMAA8w2tO1\n\tmpZX3A6T15FeieON5RiJ1NP4umBSaHD7LocOt/B4fHD9c4lcOlfTgREolKM9ntNA1Q\n\tSSlkbU/PsO6V+mBznZBW5HM3U9/v72V/qYRDAy8Q=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"HDz3je+0\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 24 Nov 2022 04:51:24 +0200", "Message-Id": "<20221124025133.17875-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.4", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 0/9] Add Bayer format support for RkISP1", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series implements support for raw Bayer capture in the RkISP1\npipeline handler and IPA module. I have taken over Florian's v2, posted\nv3, and addressed review comments in this v4, with further bug fixes.\n\nThe RkISP1 can capture raw frames by bypassing the ISP, feeding the\ninput data directly to the resizer (which has to be bypassed as well,\nwith a 1:1 scaling ratio). In this mode, the ISP doesn't consume\nparameters or produce statistics, which prevents most algorithms from\nrunning. The notable exception is the AGC algorithm which still needs to\nrun in order to set manual exposure time and analogue gain (automatic\nmode is not available).\n\nThe series starts with a few drive-by fixes and cleanups. Patches 1/9\nand 2/9 turn StreamRole into a scoped enum. These could be merged\nindependently from the rest of the series if a v5 is needed for the\nremaining patches.\n\nPatch 3/9 starts adding support for raw capture by addressing the IPA\nside first, allowing algorithms to report if they support raw capture,\nand skipping the ones that don't at runtime when capturing raw frames.\nThe next patch, 4/9, adds support for manual gain and exposure time in\nthe AGC algorithm. I have picked it up from the list (posted as \"[PATCH\nv3] ipa: rkisp1: Add support for manual gain and exposure\"), in order to\nimplement raw support in AGC on top in patch 5/9.\n\nPatches 6/9 and 7/9 then prepare the RkISP1 pipeline handler. Patch 6/9\nis an improvement previously posted to the list (as \"[RFC PATCH v2]\npipeline: rkisp1: Query the driver for formats\") that I found useful,\nand patch 7/9 a bug fix.\n\nFinally, patches 8/9 and 3/9 implement raw capture support in the\npipeline handler. I have split this into runtime support (8/9) and\nconfiguration support (9/9) to ease review. Patch 9/9 could possibly be\nfurther split into three patches for configure(), validate() and\ngenerateConfiguration(), but that's more complicated and I think that,\nwhile relatively big, 13/13 is still reviewable.\n\nThe result has been tested on an NXP i.MX8MP with an IMX219 camera\nsensor. I haven't noticed any regression with non-raw capture, and have\nsuccessfully captured raw frames in different resolutions by specifying\neither a raw role or a raw pixel format on the cam command line. I have\nalso successfully tested manual gain and exposure with YUV formats using\na capture script.\n\nFlorian Sylvestre (2):\n pipeline: rkisp1: Support raw Bayer capture at runtime\n pipeline: rkisp1: Support raw Bayer capture configuration\n\nLaurent Pinchart (5):\n libcamera: stream: Add operator<<() to print StreamRole as a string\n libcamera: stream: Turn StreamRole into scoped enumeration\n ipa: rkisp1: Support raw capture in IPA operations\n ipa: rkisp1: agc: Support raw capture\n pipeline: rkisp1: Fix stream size validation\n\nPaul Elder (2):\n ipa: rkisp1: Add support for manual gain and exposure\n pipeline: rkisp1: Query the driver for formats\n\n include/libcamera/stream.h | 5 +-\n src/android/camera_capabilities.cpp | 2 +-\n src/apps/lc-compliance/capture_test.cpp | 17 +-\n src/gstreamer/gstlibcamerapad.cpp | 20 +-\n src/ipa/rkisp1/algorithms/agc.cpp | 100 +++++--\n src/ipa/rkisp1/algorithms/agc.h | 6 +\n src/ipa/rkisp1/algorithms/algorithm.h | 12 +-\n src/ipa/rkisp1/ipa_context.cpp | 5 +\n src/ipa/rkisp1/ipa_context.h | 15 +-\n src/ipa/rkisp1/rkisp1.cpp | 65 ++++-\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 8 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 275 ++++++++++++------\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 255 ++++++++++++++--\n src/libcamera/pipeline/rkisp1/rkisp1_path.h | 15 +-\n src/libcamera/stream.cpp | 19 ++\n 15 files changed, 665 insertions(+), 154 deletions(-)" }