Cover Letter Detail
Show a cover letter.
GET /api/covers/16043/?format=api
{ "id": 16043, "url": "https://patchwork.libcamera.org/api/covers/16043/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16043/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>", "date": "2022-05-25T22:24:58", "name": "[libcamera-devel,0/5] libcamera: Add colors to the log", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/16043/mbox/", "series": [ { "id": 3140, "url": "https://patchwork.libcamera.org/api/series/3140/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3140", "date": "2022-05-25T22:24:58", "name": "libcamera: Add colors to the log", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3140/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16043/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4A564BD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 May 2022 22:25:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4ADBE65666;\n\tThu, 26 May 2022 00:25:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A52A660422\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 May 2022 00:25:11 +0200 (CEST)", "from pendragon.ideasonboard.com (ip-109-40-242-63.web.vodafone.de\n\t[109.40.242.63])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0B67563;\n\tThu, 26 May 2022 00:25:10 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653517513;\n\tbh=5KpJwGi0oVwG4VCkaLwIuZzkC1VI3uj+O0EO8iTBQRk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=3uoY4GgqNaCxr75UIWWai3TsC3RRNk2UuQbNEctqgS8cd3/bUku6p9s4uJmqA3C22\n\t/f1ayvVf1nodT710eehQi5f5cekTY45QLr9ggC6o1zTH6ZRFFxkkwYSuyiRhFWKYBT\n\tMcJyN0tbInatnbXeycdokBIyQnj+lZllwHSrPIwpy3CDGGlx0kgpQFw+4BXDzuV3GG\n\tRLcjl53crVDFLXE4hK0S4pVqWI+bp3171xpIq/83NoWtGrSkuzLbDquWHa0xaj+g0c\n\tCyCKLCqB1rjPRQVi5/1Ebt63UyLCkie1UTTkXRYQMXDlvfG9PmVs5Nkz0W/EBl3QLb\n\tGrbnbacyvsq0g==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653517511;\n\tbh=5KpJwGi0oVwG4VCkaLwIuZzkC1VI3uj+O0EO8iTBQRk=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=fPAyn+iD2OXlav3zsk3JO+rDAbi+KQrFRyai+za1IkB66YtbSVvc8lxcZtjwgyota\n\t0c72cDPFecOyJV91LaltggotRB6I+YseazhA8zkcmVACoh0Ne3YY2oCvESJ39u3TtB\n\tkok+FMJI0Tg2UBRLwCzTWRQbJhHVwLqwVJQWSzz4=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"fPAyn+iD\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 May 2022 01:24:58 +0300", "Message-Id": "<20220525222503.6460-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/5] libcamera: Add colors to the log", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series addresses a shortcoming of libcamera compared to\nGStreamer or PipeWire, namely colored logs.\n\nThis was attempted by Marco Felsch in \"[PATCH] libcamera: log: add\ncolors to log levels\" but suffered from coloring message\nunconditionally for streams, regardless of whether the stream was backed\nby a TTY, a file or something else.\n\nThis turned out impossible to solve automatically (as far as I can tell)\nas the C++ stream API doesn't expose the underlying file descriptor.\nI've thus taken another approach, by exposing coloring through the\nlibcamera logger API and only enabling it automatically when logging to\nstd::cerr. This can be disabled with the new LIBCAMERA_LOG_NO_COLOR\nenvironment variable.\n\nLaurent Pinchart (5):\n libcamera: base: log: Remove unnecessary local variable\n libcamera: base: log: Replace stderr with std::cerr in documentation\n libcamera: base: log: Log to std::cerr if log file can't be opened\n libcamera: base: log: Add coloring to the log output\n libcamera: base: log: Color the log prefix\n\n Documentation/environment_variables.rst | 21 ++-\n include/libcamera/base/log.h | 5 +-\n include/libcamera/logging.h | 4 +-\n src/libcamera/base/log.cpp | 168 +++++++++++++++++-------\n src/libcamera/camera_manager.cpp | 2 +-\n 5 files changed, 144 insertions(+), 56 deletions(-)\n\n\nbase-commit: 3e7f54a3128d8143afb200d626d3b208d493623a" }