Cover Letter Detail
Show a cover letter.
GET /api/covers/16026/?format=api
{ "id": 16026, "url": "https://patchwork.libcamera.org/api/covers/16026/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16026/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220524225816.6830-1-laurent.pinchart@ideasonboard.com>", "date": "2022-05-24T22:58:04", "name": "[libcamera-devel,RFC,00/12] Replace boost JSON parser with libyaml in Raspberry Pi IPA", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/16026/mbox/", "series": [ { "id": 3135, "url": "https://patchwork.libcamera.org/api/series/3135/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3135", "date": "2022-05-24T22:58:04", "name": "Replace boost JSON parser with libyaml in Raspberry Pi IPA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3135/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16026/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1C3CCBD161\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 May 2022 22:58:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 346B965666;\n\tWed, 25 May 2022 00:58:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7AF4260416\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 May 2022 00:58:24 +0200 (CEST)", "from pendragon.ideasonboard.com (ip-109-40-241-133.web.vodafone.de\n\t[109.40.241.133])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4CBF9DA;\n\tWed, 25 May 2022 00:58:23 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653433106;\n\tbh=M1Wq+XSP/SYd8Pr2DR63athuMH/ZxenzpMnHWSAiPz0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Hew3wptfOWkyiRWAq0UFRHib9N00xciQgP/9G+95WJIUFcHSBshJ+bJvoyA8Exai/\n\ttT27eVUHOLK1SV5y4CG8763RnoK513dCAiK/DnpFLwnRXfFVa0bmdJciM7HtD3xfCR\n\taBG2ahjtX8KBsjgSwOyfMOP2jSpNGhSN90EEyWXNVlq0mXNt1698+3my4qB7MIW+bO\n\tIPLyH7CQX2LWxD8m3HcOwz7WSNGeE6dFxbCiHnYStg1k1mcRlrjmAUQ4qQKvfSwWT1\n\tPUPclQS3QdXpOErGXMvGFgWjqYvNxn1ImuyR+uVaCFqevB3cSIKd9CltxYAZJUEfdB\n\tSn+ojUj7/RHcg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653433104;\n\tbh=M1Wq+XSP/SYd8Pr2DR63athuMH/ZxenzpMnHWSAiPz0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Sw3LHbo5Vfd1gO7NmmR0Tx8Ft3CvPAdRCRdTmVeTrgIKh8wm9J6N+mkgIDMExFor4\n\tMw3urru3HiqMEE2OXQC5t9NYTNdTvfxujYwB7jV0VACpcJjJ/tePP+DkWL781Gzvc7\n\t4U8Mo8mSxpoh6N0oZgaW3U6pbpSRgCONLXgklE8g=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Sw3LHbo5\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 25 May 2022 01:58:04 +0300", "Message-Id": "<20220524225816.6830-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 00/12] Replace boost JSON parser with\n\tlibyaml in Raspberry Pi IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nAs mentioned in the subject, this patch series replaces the boost JSON\nparser with the YamlParser implementation based on libyaml for the\nRaspberry Pi IPA module.\n\nThe series starts with a few cleanups and extensions in YamlParser, with\npatch 01/12 turning the enum Type into an enum class, patch 02/12\nextending the size() function to support dictionaries in addition to\nlists, and patch 03/12 moving the parser from using FILE to File for a\nbetter RAII-style management of files. Patch 04/12 continues with a\nsmall cleanup in the YamlParser unit tests.\n\nPatch 05/12 introduces the first big change in the series: a new\niterator API for YamlObject. This allows iterating over the elements of\na list of dictionaly object. Unlike the boost property_tree\nimplementation that iterates over a pair of std::string key and ptree\nvalue, the YamlObject iterators differ for lists and dictionaries. This\nprovides a more familiar API for lists, at the expense of requiring\nadapter objects (see the asDict() and asList() functions). I'm\ninterested in feedback on this approach, hence the RFC. Patch 06/12\nthen extends the unit tests to cover the iterator API, and patch 07/12\nuses the API in the Android camera HAL. Patch 08/12 completes that part\nof the series by removing the then unused memberNames() function.\n\nThe series continue with two extensions to the YamlParser. In patch\n09/12 the get() function receives a fix to properly check the value\nrange for 32-bit integers, and in patch 10/12 new specializations of\nthe function are added for 16-bit integers, needed by the Raspberry Pi\nIPA.\n\nThe last part of the series converts the Raspberry Pi IPA from boost to\nYamlParser. Small changes are needed in patch 11/12 to convert tabs to\nspaces in the tuning JSON files, as they confuse the YAML parser. Patch\n12/12 then converts the IPA module, and drops the dependency on boost.\n\nWhen compiled in release mode with clang-13, the Raspberry Pi IPA module\n.text section shrank from 1317086 to 963614 bytes.\n\nI haven't been able to test the series on a Raspberry Pi yet (second\nreason for the RFC) as I don't have access to my board at the moment.\n\nLaurent Pinchart (12):\n libcamera: yaml_object: Turn Type into an enum class\n libcamera: yaml_parser: Extend YamlObject::size() to dictionaries\n libcamera: yaml_parser: Switch from FILE to File\n test: yaml-parser: Use write() instead of fwrite()\n libcamera: yaml_parser: Add iterator API\n test: yaml_parser: Extend tests to cover the iterator API\n android: Use the YamlObject iterator API\n libcamera: yaml_parser: Remove memberNames() function\n libcamera: yaml_parser: Fix range checks for 32-bit integers\n libcamera: yaml_parser: Add get() specializations for 16-bit integers\n ipa: raspberrypi: Replace tabs with spaces in tuning data files\n ipa: raspberrypi: Use YamlParser to replace dependency on boost\n\n README.rst | 6 -\n include/libcamera/internal/yaml_parser.h | 133 +++++++++-\n src/android/camera_hal_config.cpp | 22 +-\n src/ipa/raspberrypi/controller/algorithm.cpp | 2 +-\n src/ipa/raspberrypi/controller/algorithm.hpp | 6 +-\n src/ipa/raspberrypi/controller/controller.cpp | 27 +-\n src/ipa/raspberrypi/controller/pwl.cpp | 12 +-\n src/ipa/raspberrypi/controller/pwl.hpp | 5 +-\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 94 +++----\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 10 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 94 ++++---\n src/ipa/raspberrypi/controller/rpi/alsc.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/awb.cpp | 89 +++----\n src/ipa/raspberrypi/controller/rpi/awb.hpp | 8 +-\n .../controller/rpi/black_level.cpp | 12 +-\n .../controller/rpi/black_level.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/ccm.cpp | 28 +--\n src/ipa/raspberrypi/controller/rpi/ccm.hpp | 4 +-\n .../raspberrypi/controller/rpi/contrast.cpp | 18 +-\n .../raspberrypi/controller/rpi/contrast.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/dpc.cpp | 4 +-\n src/ipa/raspberrypi/controller/rpi/dpc.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/geq.cpp | 10 +-\n src/ipa/raspberrypi/controller/rpi/geq.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 12 +-\n src/ipa/raspberrypi/controller/rpi/lux.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/noise.cpp | 6 +-\n src/ipa/raspberrypi/controller/rpi/noise.hpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/sdn.cpp | 6 +-\n src/ipa/raspberrypi/controller/rpi/sdn.hpp | 2 +-\n .../raspberrypi/controller/rpi/sharpen.cpp | 8 +-\n .../raspberrypi/controller/rpi/sharpen.hpp | 2 +-\n src/ipa/raspberrypi/data/imx219.json | 8 +-\n src/ipa/raspberrypi/data/imx219_noir.json | 10 +-\n src/ipa/raspberrypi/data/imx290.json | 18 +-\n src/ipa/raspberrypi/data/imx477.json | 8 +-\n src/ipa/raspberrypi/data/imx477_noir.json | 10 +-\n src/ipa/raspberrypi/data/ov5647.json | 10 +-\n src/ipa/raspberrypi/data/ov5647_noir.json | 12 +-\n src/ipa/raspberrypi/data/se327m12.json | 6 +-\n src/ipa/raspberrypi/meson.build | 1 -\n src/ipa/raspberrypi/raspberrypi.cpp | 1 +\n src/libcamera/yaml_parser.cpp | 232 +++++++++++++-----\n test/yaml-parser.cpp | 109 +++++---\n 44 files changed, 659 insertions(+), 400 deletions(-)\n\n\nbase-commit: 153b468930a9df22debb28889312f8a5c511ee04" }