Cover Letter Detail
Show a cover letter.
GET /api/covers/15265/?format=api
{ "id": 15265, "url": "https://patchwork.libcamera.org/api/covers/15265/?format=api", "web_url": "https://patchwork.libcamera.org/cover/15265/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220110165524.72978-1-jacopo@jmondi.org>", "date": "2022-01-10T16:55:19", "name": "[libcamera-devel,0/5] android: Plumb the YUV processor in", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/15265/mbox/", "series": [ { "id": 2887, "url": "https://patchwork.libcamera.org/api/series/2887/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2887", "date": "2022-01-10T16:55:19", "name": "android: Plumb the YUV processor in", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2887/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/15265/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 392ABBE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 10 Jan 2022 16:54:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0485A60935;\n\tMon, 10 Jan 2022 17:54:30 +0100 (CET)", "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::221])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98CFF6021A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jan 2022 17:54:28 +0100 (CET)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id E319A240012;\n\tMon, 10 Jan 2022 16:54:27 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 10 Jan 2022 17:55:19 +0100", "Message-Id": "<20220110165524.72978-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/5] android: Plumb the YUV processor in", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello\n I've started this series by reviewing Hiro's\n\"[PATCH 1/1] android: camera_device: Configure one stream for identical stream requests\"\nhttps://patchwork.libcamera.org/project/libcamera/list/?series=2880\n\nIn order to validate my review comments I had to find tests which exercized the\nYUV post-processor, and that's the result of the testing process.\n\nI broke Hiro's series in 4 patches and addded one small fix on top.\n\nTested by running 12 of the tests currently excluded from the libcamera\nsubplan.\n\nThese tests require 3 YUV streams to be supported and where so far excluded for\nthis reason:\n\n[1/12] android.hardware.camera2.cts.RobustnessTest#testMandatoryOutputCombinations pass\n[2/12] android.hardware.cts.CameraTest#testFocusDistances pass\n[3/12] android.hardware.cts.CameraTest#testPreviewCallback pass\n[4/12] android.hardware.cts.CameraTest#testPreviewCallbackWithBuffer pass\n[5/12] android.hardware.cts.CameraTest#testPreviewCallbackWithPicture pass\n[6/12] android.hardware.cts.CameraTest#testPreviewFormats pass\n[7/12] android.hardware.cts.CameraTest#testPreviewFpsRange pass\n[8/12] android.hardware.cts.CameraTest#testSetOneShotPreviewCallback pass\n[9/12] android.hardware.cts.CameraTest#testSetPreviewDisplay pass\n[10/12] android.hardware.cts.CameraGLTest#testSetPreviewTextureBothCallbacks pass\n[11/12] android.hardware.cts.CameraGLTest#testSetPreviewTexturePreviewCallback pass\n[12/12] android.hardware.camera2.cts.SurfaceViewPreviewTest#testDeferredSurfaces pass\n\nAs an example output from a test run:\n\n-------------------------------------------------------------------------------\nINFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #0, direction: Output, width: 1920, height: 1080, format: 0x00000022, rotation: 0, crop_rotate_scale_degrees: 0 (NV12)\nINFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #1, direction: Output, width: 1920, height: 1080, format: 0x00000022, rotation: 0, crop_rotate_scale_degrees: 0 (NV12)\nINFO HAL camera_device.cpp:569 '\\_SB_.PCI0.I2C4.CAM1': Stream #2, direction: Output, width: 2560, height: 1920, format: 0x00000021, rotation: 0, crop_rotate_scale_degrees: 0 (MJPEG)\nINFO HAL camera_device.cpp:694 '\\_SB_.PCI0.I2C4.CAM1': Adding 2560x1920-NV12 for MJPEG support\nDEBUG HAL camera_device.cpp:121 Insert 2560x1920-NV12\nDEBUG HAL camera_device.cpp:127 Insert 1920x1080-NV12\nINFO Camera camera.cpp:1028 configuring streams: (0) 2560x1920-NV12 (1) 1920x1080-NV12\n\n...\n\nDEBUG HAL camera_device.cpp:951 '\\_SB_.PCI0.I2C4.CAM1': Queueing request 138253722276496 with 3 streams\nDEBUG HAL camera_device.cpp:1017 '\\_SB_.PCI0.I2C4.CAM1': 1 - (1920x1080)[0x00000022] -> (1920x1080)[NV12] (direct)\nDEBUG HAL camera_device.cpp:1030 '\\_SB_.PCI0.I2C4.CAM1': 2 - (2560x1920)[0x00000021] -> (2560x1920)[NV12] (internal)\nDEBUG HAL camera_device.cpp:1063 '\\_SB_.PCI0.I2C4.CAM1': 0 - (1920x1080)[0x00000022] -> (1920x1080)[NV12] (mapped)\nDEBUG HAL camera_device.cpp:1198 '\\_SB_.PCI0.I2C4.CAM1': Request 138253722217920 completed with 2 streams\n-------------------------------------------------------------------------------\n\nNo regression with the ordinary CTS libcamera plan\n\n=============== Summary ===============\nTotal Run time: 19m 51s\n1/1 modules completed\nTotal Tests : 231\nPASSED : 231\nFAILED : 0\n============== End of Results ==============\n\nThanks\n j\n\n\nHirokazu Honda (2):\n android: camera_stream: Add sourceStream\n android: camera_device: Use YUV post-processor\n\nJacopo Mondi (3):\n android: camera_stream: Create allocator unconditionally\n android: camera_device: Post-pone mapped streams handling\n android: camera_device: Print the correct number of completed streams\n\n src/android/camera_device.cpp | 124 ++++++++++++++++++++++++++++++----\n src/android/camera_stream.cpp | 12 ++--\n src/android/camera_stream.h | 6 +-\n 3 files changed, 122 insertions(+), 20 deletions(-)\n\n--\n2.34.1" }