Cover Letter Detail
Show a cover letter.
GET /api/covers/14836/?format=api
{ "id": 14836, "url": "https://patchwork.libcamera.org/api/covers/14836/?format=api", "web_url": "https://patchwork.libcamera.org/cover/14836/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211129114453.3186042-1-hiroh@chromium.org>", "date": "2021-11-29T11:44:42", "name": "[libcamera-devel,v2,00/11] Introduce clang thread safety annotations", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "mbox": "https://patchwork.libcamera.org/cover/14836/mbox/", "series": [ { "id": 2770, "url": "https://patchwork.libcamera.org/api/series/2770/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2770", "date": "2021-11-29T11:44:42", "name": "Introduce clang thread safety annotations", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2770/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/14836/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1BB0BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Nov 2021 11:45:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CA52605A1;\n\tMon, 29 Nov 2021 12:45:03 +0100 (CET)", "from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com\n\t[IPv6:2607:f8b0:4864:20::102d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E16E60592\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Nov 2021 12:45:02 +0100 (CET)", "by mail-pj1-x102d.google.com with SMTP id gt5so12528102pjb.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Nov 2021 03:45:01 -0800 (PST)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:f254:cda9:46e8:17b7])\n\tby smtp.gmail.com with ESMTPSA id\n\thg4sm17951966pjb.1.2021.11.29.03.44.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 29 Nov 2021 03:44:59 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mnKWEF/6\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=pVtl+48kGHuzFX/w53S0P3Pm25h8VzfbAYUT+V+PZpw=;\n\tb=mnKWEF/6yuOLf1TvLsHdnJoj89uv60WcnU6T/9UtKJQ517mL/HL61Umnv28dG1TZN1\n\t3UCg31Y2uK2U3drosFoW3O9lRrUSblsACVQt7YyZu/dXZ4g6FvFirb2hmk63l3X7NL3t\n\t6Z13OEYDKz196Rm8z5jcMXvPEtTFvN7hhOuC8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=pVtl+48kGHuzFX/w53S0P3Pm25h8VzfbAYUT+V+PZpw=;\n\tb=BjBDxHNx/SYeIYaAHHTanHvPxL0jFSG1kB4JFnCLV2zVijAYQtbmYL9181ObjaeAfa\n\tH4K20SPhwqMgoAiaRs14trhOr0uEtzRtLY62qijG8+7YmzeSEn8jN5F9RaC1+/n5zMj/\n\taaXDHwm7l/qtFK3JG+wIVOS6qzDLDeDISdZZV2zu22Y+H/19EFGoCRgFKfXDq+WNkFXn\n\tcZEJx58rsitw9tpuTj/DbM5eQnYYV9Un6sb8XVrEnCa7QSTknExAs86OWQkBQXm+vwRX\n\tr2ZRLJa0BBcWudWoGeTYM8CQ48PRuTStDqh7GsDEQw3wjeAF9NOGsRex2GuxSl5y1en4\n\tr6Mw==", "X-Gm-Message-State": "AOAM532QL56h+Qi6NXf4ziCJ/+URxj1P8nE0yHoqLJ35oUTrl00umkk6\n\tbp2S7r/GrG03MLYyZja99f1NqpXaE3UiQw==", "X-Google-Smtp-Source": "ABdhPJw0sTltD0t2zDgUMr55GaidLWBcoB8+t5kAwpHnEDNuxzRcsoZMJyf96iuDFdoGMW9Et9B+3w==", "X-Received": "by 2002:a17:90b:512:: with SMTP id\n\tr18mr37157940pjz.64.1638186300114; \n\tMon, 29 Nov 2021 03:45:00 -0800 (PST)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 29 Nov 2021 20:44:42 +0900", "Message-Id": "<20211129114453.3186042-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.34.0.rc2.393.gf8c9666880-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 00/11] Introduce clang thread safety\n\tannotations", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This introduces clang thread safety annotations and applies it\nto libcamera Android HAL adaptation layer. It is necessary to add\nnew classes that wrap std::mutex, std::unique_lock and\nstd::condition_variable with the annotations. It is because no\nC++ standard library annotates all the mutex classes today.\nlibstdc++ doesn't annotate any classes. libc++ annotates for\nstd::mutex, std::lock_guard and std::scoped_lock, but doesn't for\nstd::unique_lock.\n\nTherefore it is possible to use std::mutex if libc++ is used.\nAlthoug I don't do so In this patch series because the existing\ncode using std::mutex is not annotated yet.\n\nDocument: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html\n\nChange in v2:\n- Introduce ConditionVariable\n- Consolidate std::mutex/std::unique_lock and Mutex/MutexLocker\n- Replace Mutx and MutexLocker with new classes, not having\n duplicated classes\n- Separate code fix patches from thread annotation patches\n\nHirokazu Honda (11):\n libcamera: base: Introduce ConditionVariable\n android: Consolidate mutex classes to Mutex and MutexLocker\n v4l2: Consolidate mutex classes to Mutex and MutexLocker\n libcamera: base: Add thread safety annotation macros\n libcamera: base: Add mutex classes with thread safety annotations\n android: camera_hal_manager: Add thread safety annotation\n android: camera_stream: Protect buffers initialization by mutex_\n android: camera_stream: Add thread safety annotation\n android: camera_device: Fix variables access without protection\n android: camera_device: Add thread safety annotation\n android: camera_request: Add thread safety annotation\n\n include/libcamera/base/meson.build | 2 +\n include/libcamera/base/mutex.h | 127 ++++++++++++++++++++\n include/libcamera/base/semaphore.h | 4 +-\n include/libcamera/base/thread.h | 5 +-\n include/libcamera/base/thread_annotations.h | 80 ++++++++++++\n meson.build | 1 +\n src/android/camera_device.cpp | 10 +-\n src/android/camera_device.h | 18 +--\n src/android/camera_hal_manager.h | 14 +--\n src/android/camera_request.h | 8 +-\n src/android/camera_stream.cpp | 15 +--\n src/android/camera_stream.h | 16 +--\n src/libcamera/base/thread.cpp | 3 +-\n src/libcamera/camera_manager.cpp | 3 +-\n src/v4l2/v4l2_camera.h | 4 +-\n src/v4l2/v4l2_camera_proxy.cpp | 8 +-\n src/v4l2/v4l2_camera_proxy.h | 5 +-\n 17 files changed, 269 insertions(+), 54 deletions(-)\n create mode 100644 include/libcamera/base/mutex.h\n create mode 100644 include/libcamera/base/thread_annotations.h\n\n--\n2.34.0.rc2.393.gf8c9666880-goog" }