Cover Letter Detail
Show a cover letter.
GET /api/covers/1483/?format=api
{ "id": 1483, "url": "https://patchwork.libcamera.org/api/covers/1483/?format=api", "web_url": "https://patchwork.libcamera.org/cover/1483/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190620153144.5394-1-jacopo@jmondi.org>", "date": "2019-06-20T15:31:38", "name": "[libcamera-devel,v5,0/6] Add support for V4L2 controls", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/1483/mbox/", "series": [ { "id": 368, "url": "https://patchwork.libcamera.org/api/series/368/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=368", "date": "2019-06-20T15:31:38", "name": "Add support for V4L2 controls", "version": 5, "mbox": "https://patchwork.libcamera.org/series/368/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/1483/comments/", "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 88C5960BA1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 20 Jun 2019 17:30:40 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id DD0DF240015;\n\tThu, 20 Jun 2019 15:30:39 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 20 Jun 2019 17:31:38 +0200", "Message-Id": "<20190620153144.5394-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v5 0/6] Add support for V4L2 controls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 20 Jun 2019 15:30:40 -0000" }, "content": "Hello,\n quite a few changes compared to v4, mostly on the V4L2Control and\nV4L2Controls side to work around the badly performing get() and set()\nmethods implemented in v4.\n\n- Remove V4L2Controls::get() and set() as they iterated on the controls\n vector unecessarly\n- By removing 'set()' now control cannot be updated and reused\n- Make the operations to set and get a V4L2Control value public, to avoid\n having to access them through the V4L2Controls class\n- Change return of V4L2Device::s/getControls() to signal which control failed\n- Documentation improvements as suggested by Laurent.\n\nI have not taken in changes to the vector of controls in V4L2Controls after\nthe discussion in mailing list.\n\nI would also like to provide a test, but VIMC has no control.\nVIVID has many, but iirc we deprecated VIVID in favour of VIMC everywhere we\ncould.\n\nAn example of the new API is provided in 6/6.\n\nThanks\n j\n\nJacopo Mondi (6):\n libcamera: Add V4L2Controls\n libcamera: v4l2_device: List valid controls at open\n libcamera: v4l2_device: Implement get and set controls\n libcamera: camera_sensor: Add V4L2 control operations\n libcamera: ipu3: Set pipe_mode based on stream configuration\n [HACK] ipu3: Set and get a few sensor controls\n\n src/libcamera/camera_sensor.cpp | 65 ++++++\n src/libcamera/include/camera_sensor.h | 6 +\n src/libcamera/include/v4l2_controls.h | 86 ++++++++\n src/libcamera/include/v4l2_device.h | 12 ++\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 59 ++++++\n src/libcamera/v4l2_controls.cpp | 282 ++++++++++++++++++++++++++\n src/libcamera/v4l2_device.cpp | 265 ++++++++++++++++++++++++\n 8 files changed, 776 insertions(+)\n create mode 100644 src/libcamera/include/v4l2_controls.h\n create mode 100644 src/libcamera/v4l2_controls.cpp\n\n--\n2.21.0" }