Cover Letter Detail
Show a cover letter.
GET /api/covers/14108/?format=api
{ "id": 14108, "url": "https://patchwork.libcamera.org/api/covers/14108/?format=api", "web_url": "https://patchwork.libcamera.org/cover/14108/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211012152410.978077-1-naush@raspberrypi.com>", "date": "2021-10-12T15:24:08", "name": "[libcamera-devel,RFC,0/2] Add new build option to override generate SHA", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "mbox": "https://patchwork.libcamera.org/cover/14108/mbox/", "series": [ { "id": 2618, "url": "https://patchwork.libcamera.org/api/series/2618/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2618", "date": "2021-10-12T15:24:08", "name": "Add new build option to override generate SHA", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2618/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/14108/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06306C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 12 Oct 2021 15:24:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 83C4268F4D;\n\tTue, 12 Oct 2021 17:24:29 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4720268F4C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Oct 2021 17:24:27 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id u18so68245666wrg.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Oct 2021 08:24:27 -0700 (PDT)", "from naush-laptop.pitowers.org\n\t([2a00:1098:3142:14:26ae:314c:5c3f:f0df])\n\tby smtp.gmail.com with ESMTPSA id\n\ts14sm10683449wro.76.2021.10.12.08.24.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 12 Oct 2021 08:24:25 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Br2PGLDD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ot8lB/wg003WQ1ZLhd6/FAy4iRawTYKbrjUdORgHQ/I=;\n\tb=Br2PGLDDD9jErMW5oQLcYPQaAst4Rb69pH7lrLchjodSuoO9Rslvpq4vvmIJJbYy3e\n\tqu68is6btr+SmFTIjyOBkjjtNYRmp+48be78WTMkXj/Mj9NzHaxkp5CrjGRL7QumDU6Y\n\tEQY60kxX/MEkX45+0ZEI13yDSl057oBXBy89XqR6dKThoziLfA/fope1jLIcKT3QuK+I\n\tkRZXTTH2duXN8Pw+CtJg+G8J6Y/rRcFOSm2DMkUT3AaAUbM2/KTYZNlo4VzoF/+s189I\n\t03e+AeK01iTZ6ZamuDYH7LvaMd5PHXOCq/ISqCSg+Z6CJu18Acq++2qn3TPT/IW7l5Mq\n\tg2zw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=ot8lB/wg003WQ1ZLhd6/FAy4iRawTYKbrjUdORgHQ/I=;\n\tb=6hGfgyM/MqWzpk37PRGtbzlp1pXmxrhbL5QyPsw6Kfzeej0humt62qv8mVHBWVX6RD\n\tHLyOkaIUvhUSleFMnpa6/cqb0YxjhOLABwu0/xI4F58ANMr9FKaMrBc7hz0/I1Sut5Rl\n\tmMylv+6zQ3dj3e6M/aipciBExuu5cFskAhEGNbka52Bgrc8Kf23+OBgBnw6y+MbOl9jO\n\ttuxmhXnDg0Z2EtpnEW4xu1DBFFMplByeNBeqY248MDFmaEpxp/ixWtwNqBCjwZLsYijN\n\tTsOo+/9dp61GDbrW4IFggFgNecp7UsHYocnFbrKzxjbO1r2X80lDvzqRVx6kFfoVePI9\n\tH2fA==", "X-Gm-Message-State": "AOAM530Fv0Hgt3CyHKKe2EScFkmIXjqdkyvwxdXwMjUACVMK95V+vsEx\n\tq8nhkWBnk4Jn2LxvHpcq08x6KHv6IPmIwA==", "X-Google-Smtp-Source": "ABdhPJxaoTRUmBt02d6qN8JupPI5gudsJfRJSqk8iiLSc2WAYiimoPFrhTV7JwjITzcfwt7KcgwTgQ==", "X-Received": "by 2002:a1c:730a:: with SMTP id\n\td10mr6252882wmb.105.1634052266454; \n\tTue, 12 Oct 2021 08:24:26 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 Oct 2021 16:24:08 +0100", "Message-Id": "<20211012152410.978077-1-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 0/2] Add new build option to override\n\tgenerate SHA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nThis set of changes have come about after a discusion on an issue raised on the Pi\nlibcamera-apps github repo [1]. From my little understanding, various distributions\nuse different methods to build and package libraries. As part of this process,\nthey may build these libraries outside of the upstream tree, and perhaps not\neven in a git repo tree. If this happens, the version string generated during the\nlibcamera build is either empty or (if it is from a downstream tree) useless.\n\nThis change allows the user to override the SHA value with a string passed into\nthe meson build options that would be used in-place of the one generated by the\ngen-version.sh script. This would allow out-of-tree builds to provide a sensible\nsha version string based off the upstream tree.\n\nI'm not too sure if this is the best way to do this, but it is a simple solution.\nIf anyone has other suggestions how we can overcome this, please do let me know.\n\nThanks,\nNaush\n\n[1]: https://github.com/raspberrypi/libcamera-apps/issues/122\n\nNaushir Patuck (2):\n utils: Add an option to override SHA string in gen-version.sh\n build: Add a \"version_sha\" meson build option\n\n meson.build | 4 +++-\n meson_options.txt | 5 +++++\n src/libcamera/meson.build | 3 ++-\n utils/gen-version.sh | 25 ++++++++++++++++++-------\n 4 files changed, 28 insertions(+), 9 deletions(-)" }