Cover Letter Detail
Show a cover letter.
GET /api/covers/14044/?format=api
{ "id": 14044, "url": "https://patchwork.libcamera.org/api/covers/14044/?format=api", "web_url": "https://patchwork.libcamera.org/cover/14044/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211005073114.3997303-1-hiroh@chromium.org>", "date": "2021-10-05T07:31:08", "name": "[libcamera-devel,RFC,0/6] Remove using namespace in header files", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "mbox": "https://patchwork.libcamera.org/cover/14044/mbox/", "series": [ { "id": 2602, "url": "https://patchwork.libcamera.org/api/series/2602/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2602", "date": "2021-10-05T07:31:08", "name": "Remove using namespace in header files", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2602/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/14044/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5AC3CBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Oct 2021 07:31:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C9789691B8;\n\tTue, 5 Oct 2021 09:31:26 +0200 (CEST)", "from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n\t[IPv6:2607:f8b0:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1DCA684C6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Oct 2021 09:31:24 +0200 (CEST)", "by mail-pl1-x631.google.com with SMTP id b22so1723601pls.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 05 Oct 2021 00:31:24 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:debc:d0db:3bd8:f961])\n\tby smtp.gmail.com with ESMTPSA id\n\to14sm16761812pfh.145.2021.10.05.00.31.21\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Oct 2021 00:31:22 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"HdmmOF+s\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=epvkAwYKytUVDvQGVX7nK9C8n6cTt+a33JE1lvs5+NI=;\n\tb=HdmmOF+sJ1T7idxK7uOihLLAksPp21awjC8cP4Kb66Xa+8zNxpqrKRHgCu1Zh+9Za8\n\tBZiXtEbnyUVUtXf7W6GsnhHCjAIHzQv3Bgpftg3tm+xFwWeKVtCOwPHkHIl/ChEGImCN\n\tYIgmOZb06rN8Lg+vQ1ws06WvMFoSWifwdrClQ=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=epvkAwYKytUVDvQGVX7nK9C8n6cTt+a33JE1lvs5+NI=;\n\tb=nxqnvFACz2TfTWfO2Vkdn9F5NegF7n6BDHw1O0vn+zWvL7Gu32eD6UgYD6f4hfcvLx\n\tGzuaufRdAg7uMlvCNFSE4xtgiGZrBhMOMJVRD2vy5poOjnDFzHUmgxTYwPGER3kEm0fW\n\toS6TAThUlK7l3gaUozvuqmX6rP3KRZRHXCa+1fC8AQBGGBpK0yVBlQw6aqhntKPrKT0o\n\tCdpqqIA4Z6iHe7YxOYw/QcI2xJwVLxP8F9StwUquScqitygD3kIziofcula4T6v0EC/Z\n\tDNU5SfDxPsACRExk7bqu/EdcydR+4UzQ2XTV4pOso5iABOQiC1e0rfrKczgVTSw4s5fW\n\tX9JQ==", "X-Gm-Message-State": "AOAM530J75rILBJ6n172qsPfA0UjB6Le5FV30tDHybHE2iHzbDShW/zo\n\tNw297LXJb7czzXBmSjX9ubaBrWG4jSUjig==", "X-Google-Smtp-Source": "ABdhPJwEGpT0scOSTpXC8U0i1B17NC1eLnGAfOVA61C8Rr3VnvkBl69TBGSPjB0pBi4dgC252BCymQ==", "X-Received": "by 2002:a17:902:ed8a:b0:13e:c68e:c2d3 with SMTP id\n\te10-20020a170902ed8a00b0013ec68ec2d3mr3870184plj.77.1633419082937; \n\tTue, 05 Oct 2021 00:31:22 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Oct 2021 16:31:08 +0900", "Message-Id": "<20211005073114.3997303-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.800.g4c38ced690-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 0/6] Remove using namespace in header\n\tfiles", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "According to Google C++ style guide, using-directives (i.e.\n\"using namespace foo\") should not be used. However, libcamera has\nbeen using the scheme in many files. Removing using-directives\nentirely in the code definitely needs the dicussion.\n\nThis patch series resolves the porblem of using using-directives\nin header file, which I expect I can handily get the agreement\nfrom developers. Using-directives in a header file is propagated\nto all the files including the header file. This pollutes\nnamespace severely.\n\n[1] https://google.github.io/styleguide/cppguide.html#Namespaces\n\nHirokazu Honda (6):\n ipa: raspberrypi: agc: Remove using namespace in agc.hpp\n cam: Remove using namespace in stream_options.h\n qcam: Remove using namespace in header files\n v4l2: Remove using namespace in header files\n lc-compliance: Remove using namespace in header files\n test: Remove using namespace in header files\n\n src/cam/stream_options.h | 8 ++--\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 7 ++++\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +--\n src/lc-compliance/environment.cpp | 2 +-\n src/lc-compliance/environment.h | 8 ++--\n src/qcam/dng_writer.h | 10 ++---\n src/qcam/main.cpp | 2 +-\n src/qcam/main_window.h | 40 +++++++++----------\n src/v4l2/v4l2_camera.h | 37 +++++++++--------\n src/v4l2/v4l2_camera_proxy.h | 15 ++++---\n src/v4l2/v4l2_compat_manager.h | 4 +-\n test/camera/camera_reconfigure.cpp | 1 +\n test/camera/capture.cpp | 1 +\n test/camera/configuration_default.cpp | 1 +\n test/camera/configuration_set.cpp | 1 +\n test/camera/statemachine.cpp | 1 +\n test/gstreamer/gstreamer_test.h | 2 -\n test/libtest/buffer_source.cpp | 2 +\n test/libtest/buffer_source.h | 10 ++---\n test/libtest/camera_test.h | 6 +--\n test/mapped-buffer.cpp | 1 +\n test/media_device/media_device_test.h | 6 +--\n test/serialization/serialization_test.h | 10 ++---\n test/v4l2_subdevice/v4l2_subdevice_test.h | 8 ++--\n test/v4l2_videodevice/buffer_sharing.cpp | 2 +\n test/v4l2_videodevice/capture_async.cpp | 2 +\n test/v4l2_videodevice/v4l2_videodevice_test.h | 14 +++----\n 27 files changed, 100 insertions(+), 107 deletions(-)\n\n--\n2.33.0.800.g4c38ced690-goog" }