Cover Letter Detail
Show a cover letter.
GET /api/covers/1381/?format=api
{ "id": 1381, "url": "https://patchwork.libcamera.org/api/covers/1381/?format=api", "web_url": "https://patchwork.libcamera.org/cover/1381/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190610164052.30741-1-jacopo@jmondi.org>", "date": "2019-06-10T16:40:46", "name": "[libcamera-devel,v2,0/6,TEMP] Add support for V4L2 Controls", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/1381/mbox/", "series": [ { "id": 344, "url": "https://patchwork.libcamera.org/api/series/344/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=344", "date": "2019-06-10T16:40:46", "name": "Add support for V4L2 Controls", "version": 2, "mbox": "https://patchwork.libcamera.org/series/344/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/1381/comments/", "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B699635DC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 10 Jun 2019 18:39:45 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 27EE4240008;\n\tMon, 10 Jun 2019 16:39:44 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 10 Jun 2019 18:40:46 +0200", "Message-Id": "<20190610164052.30741-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 0/6] [TEMP] Add support for V4L2\n\tControls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 10 Jun 2019 16:39:45 -0000" }, "content": "Hello,\n first of all, this series is half-backed, sorry about this.\n\nI'm sending it out in this not-ready-to-merge state to ask for a validation of\nthe interface, as it sits between what I had in v1 and what has been suggested\nduring review by Laurent and Kieran.\n\nYou should basically look into the last two patches to have a taste of the\ninterface and look at 3/6 to check out the V4L2Controls wrapper implementation.\nI still have to address comments on V4L2Base, on patch 1/6 and a few things on\n3/6 (like not quering controls everytime they are get or set).\n\nAs I've said, this is just to have feedback on the user interface.\n\nOn the back storage and the V4L2ControlValue vs ControlValue discussion, I\nreally don't care much. I consider the template version more felxible, and the\nproxy class hides from the extern the casts, providing a series of getInt()\ngetBool() etc methods.\n\nMemory is managed by the V4L2Controls class and by the V4L2Base::setControls()\nand V4L2Base::getControls() methods, so it should not cause issues for the\nusers.\n\nAs soon as I receive comments on the API, I'll fix the remaining parts and\neventually send for inclusion.\n\nTested on IPU3 Soraka.\n\nThanks\n j\n\nJacopo Mondi (6):\n libcamera: camera_sensor: Add dev() operation\n libcamera: Provide a V4L2Base class\n libcamera: Add V4L2Controls\n libcamera: v4l2_base: Add V4L2 control support\n libcamera: ipu3: Set pipe_mode based on stream configuration\n [HACK] ipu3: Set and get a few sensor controls\n\n src/libcamera/camera_sensor.cpp | 6 +\n src/libcamera/include/camera_sensor.h | 1 +\n src/libcamera/include/v4l2_base.h | 42 ++\n src/libcamera/include/v4l2_controls.h | 210 ++++++++\n src/libcamera/include/v4l2_device.h | 9 +-\n src/libcamera/include/v4l2_subdevice.h | 9 +-\n src/libcamera/meson.build | 3 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 109 +++++\n src/libcamera/v4l2_base.cpp | 302 ++++++++++++\n src/libcamera/v4l2_controls.cpp | 632 +++++++++++++++++++++++++\n src/libcamera/v4l2_device.cpp | 13 +-\n src/libcamera/v4l2_subdevice.cpp | 12 +-\n 12 files changed, 1318 insertions(+), 30 deletions(-)\n create mode 100644 src/libcamera/include/v4l2_base.h\n create mode 100644 src/libcamera/include/v4l2_controls.h\n create mode 100644 src/libcamera/v4l2_base.cpp\n create mode 100644 src/libcamera/v4l2_controls.cpp\n\n--\n2.21.0" }