Cover Letter Detail
Show a cover letter.
GET /api/covers/13284/?format=api
{ "id": 13284, "url": "https://patchwork.libcamera.org/api/covers/13284/?format=api", "web_url": "https://patchwork.libcamera.org/cover/13284/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210810151211.56702-1-jacopo@jmondi.org>", "date": "2021-08-10T15:12:06", "name": "[libcamera-devel,v4,0/5] libcamera: Initialize controls in the IPA", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/13284/mbox/", "series": [ { "id": 2334, "url": "https://patchwork.libcamera.org/api/series/2334/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2334", "date": "2021-08-10T15:12:06", "name": "libcamera: Initialize controls in the IPA", "version": 4, "mbox": "https://patchwork.libcamera.org/series/2334/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/13284/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9887EBD87D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 Aug 2021 15:11:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0042D6884E;\n\tTue, 10 Aug 2021 17:11:27 +0200 (CEST)", "from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C38F687F0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Aug 2021 17:11:26 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id CED44200004;\n\tTue, 10 Aug 2021 15:11:25 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 Aug 2021 17:12:06 +0200", "Message-Id": "<20210810151211.56702-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v4 0/5] libcamera: Initialize controls in\n\tthe IPA", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "During the review of v1 it has been pointed out by Umang that:\n\n# LIBCAMERA_IPA_FORCE_ISOLATION=1 cam -c1 --list-controls\n[0:10:59.880617099] [11495] ERROR IPU3 ipu3.cpp:1201 Exposure control not initializaed by the IPA\nCamera 1 not found\n\nThe issue boils down to the fact the control deserialization procedure\nre-creates ControlId to populate the deserialized ControlIdMap.\n\nAs we have globally available ControlIdMap, the ControlId * should be taken from\nthere when possible, in order to allow lookup by id.\n\nWith the new patches:\n\n# LIBCAMERA_IPA_FORCE_ISOLATION=1 cam -c1 --list-controls\nUsing camera \\_SB_.PCI0.I2C2.CAM0 as cam0\nControl: ScalerCrop: [(0x0)/1344x736..(0x0)/4224x3136]\nControl: PipelineDepth: [2..3]\nControl: TestPatternMode: [0..2]\nControl: FrameDurationLimits: [31425..320388]\nControl: ExposureTime: [41..33306]\n\nNext, when addressing the update of ControlInfoMap due to a camera configuration\nthe de-serializer caching mechanism will probably play a role. But that's for\nlater.\n\nThanks\n j\n\nv4->v4:\n- Minor style and grammar fixes\n- [1/5]: Expand ControlInfoMap::validate() and ASSERT in the caller\n- Tested with CTS\n\nv2->v3:\n- Fix spelling in commit messages as suggested by Paul and collect tags\n\n- [1/5]:\n - ControlInfoMap::validate()\n - Rework ControlInfoMap documentation as suggested by Laurent\n\n- [2/5]:\n - Moved test earlier and simplified code\n\n- [3/5]\n - Drop 'enum class' and use Laurent's suggested naming\n - Simplify de-serializer code that uses a localIdMap as suggested by Laurent\n\n- [4/5]\n - Change IPAIPU3::init() prototype\n\n init(libcamera.IPASettings settings,\n libcamera.IPACameraSensorInfo sensorInfo,\n libcamera.ControlInfoMap sensorControls)\n\n - Move exposureTime_ initialization in PH back to initControls()\n\nv1->v2:\n- [1/5]. [2/5], [3/5]: new patches\n- [4/5]\n - Do not remove IPASettings but include it it IPAInitInfo\n - Rework a todo item as suggested by Laurent\n - Remove an non necessay initialization\n - [5/5]\n - Collect tags\n\nJacopo Mondi (5):\n libcamera: controls: Create ControlInfoMap with ControlIdMap\n test: control serialization: Test lookup by ControlId\n libcamera: controls: Use ControlIdMap in deserialization\n libcamera: ipu3: Initialize controls in the IPA\n ipa: ipu3: Tidy-up includes\n\n include/libcamera/controls.h | 13 +-\n .../libcamera/internal/control_serializer.h | 1 +\n include/libcamera/internal/v4l2_device.h | 1 +\n include/libcamera/ipa/ipa_controls.h | 9 +-\n include/libcamera/ipa/ipu3.mojom | 5 +-\n include/libcamera/ipa/raspberrypi.h | 40 +++---\n src/ipa/ipu3/ipu3.cpp | 78 ++++++++++-\n src/ipa/ipu3/ipu3_agc.cpp | 2 +-\n src/ipa/ipu3/ipu3_agc.h | 3 -\n src/ipa/ipu3/ipu3_awb.cpp | 3 +-\n src/libcamera/control_serializer.cpp | 66 ++++++++--\n src/libcamera/controls.cpp | 121 ++++++++----------\n src/libcamera/ipa_controls.cpp | 29 +++++\n src/libcamera/pipeline/ipu3/ipu3.cpp | 98 +++++++-------\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 2 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n src/libcamera/v4l2_device.cpp | 3 +-\n test/serialization/control_serialization.cpp | 9 ++\n .../ipa_data_serializer_test.cpp | 14 +-\n 20 files changed, 320 insertions(+), 182 deletions(-)\n\n--\n2.32.0" }